X-Git-Url: http://git.tuebingen.mpg.de/?a=blobdiff_plain;ds=sidebyside;f=vss.c;h=30285aeff5441e540f66dc92afc8b0717a60d9b5;hb=d54fa6e3d72bb509ed098dc65f4ad26f5aae7aab;hp=4a1db40d716c9022c7a38e0653ee50a515a53e4f;hpb=7649f22106cec2c6eb8bb10f279401e1af5451d0;p=paraslash.git

diff --git a/vss.c b/vss.c
index 4a1db40d..30285aef 100644
--- a/vss.c
+++ b/vss.c
@@ -1024,7 +1024,8 @@ err:
  */
 static void vss_send(struct vss_task *vsst)
 {
-	int i, fec_active = 0;
+	int i;
+	bool fec_active = false;
 	struct timeval due;
 	struct fec_client *fc, *tmp_fc;
 
@@ -1032,14 +1033,13 @@ static void vss_send(struct vss_task *vsst)
 		return;
 	if (chk_barrier("eof", &vsst->eof_barrier, &due, 1) < 0)
 		return;
-	if (chk_barrier("data send", &vsst->data_send_barrier,
-			&due, 1) < 0)
+	if (chk_barrier("data send", &vsst->data_send_barrier, &due, 1) < 0)
 		return;
 	list_for_each_entry_safe(fc, tmp_fc, &fec_client_list, node) {
 		if (fc->state == FEC_STATE_DISABLED)
 			continue;
 		if (!next_slice_is_due(fc, NULL)) {
-			fec_active = 1;
+			fec_active = true;
 			continue;
 		}
 		if (compute_next_fec_slice(fc, vsst) <= 0)
@@ -1049,7 +1049,7 @@ static void vss_send(struct vss_task *vsst)
 		fc->current_slice_num++;
 		fc->fcp->send_fec(fc->sc, (char *)fc->enc_buf,
 			fc->group.slice_bytes + FEC_HEADER_SIZE);
-		fec_active = 1;
+		fec_active = true;
 	}
 	if (mmd->current_chunk >= mmd->afd.afhi.chunks_total) { /* eof */
 		if (!fec_active)
@@ -1067,13 +1067,12 @@ static void vss_send(struct vss_task *vsst)
 			mmd->events++;
 			set_mmd_offset();
 		}
-		/*
-		 * We call the send function also in case of empty chunks as
-		 * they might have still some data queued which can be sent in
-		 * this case.
-		 */
 		vss_get_chunk(mmd->current_chunk, vsst, &buf, &len);
 		for (i = 0; senders[i].name; i++) {
+			/*
+			 * We call ->send() even if len is zero because senders
+			 * might have data queued which can be sent now.
+			 */
 			if (!senders[i].send)
 				continue;
 			senders[i].send(mmd->current_chunk, mmd->chunks_sent,