X-Git-Url: http://git.tuebingen.mpg.de/?a=blobdiff_plain;f=aft.c;h=04846a7658e34979f6bdcab62669b2c1c826a1a6;hb=4a262fc2d915538dd5ebaa58fa5ec7403de650cd;hp=3c33aae0c747513a39ddd4426a413a30e5644b58;hpb=191d16070b9511f5b32b1ede7a9d0db1ffb3da54;p=paraslash.git

diff --git a/aft.c b/aft.c
index 3c33aae0..04846a76 100644
--- a/aft.c
+++ b/aft.c
@@ -205,40 +205,38 @@ static int verify_dotfile(const char *rest)
 	return 1;
 }
 
-static int verify_path(const char *path, char **resolved_path)
+static int verify_path(const char *orig_path, char **resolved_path)
 {
-	const char *orig_path = path;
 	char c;
 	const char prefix[] = AFS_AUDIO_FILE_DIR "/";
+	const char *path = orig_path;
 	const size_t prefix_len = strlen(prefix);
 
-	PARA_DEBUG_LOG("path: %s\n", path);
 	c = *path++;
 	if (!c)
-		return -E_BAD_PATH;
+		goto bad_path;
 	while (c) {
 		if (c == '/') {
 			c = *path++;
 			switch (c) {
 			default:
 				continue;
-			case '/': case '\0':
-				break;
+			case '/': /* double slash */
+				goto bad_path;
 			case '.':
-				if (verify_dotfile(path) > 0)
-					continue;
+				if (verify_dotfile(path) < 0)
+					goto bad_path;
 			}
-			*resolved_path = NULL;
-			return -E_BAD_PATH;
 		}
 		c = *path++;
 	}
-	if (*orig_path == '/')
-		*resolved_path = prefix_path("", 0, orig_path);
-	else
+	if (*orig_path != '/')
 		*resolved_path = prefix_path(prefix, prefix_len, orig_path);
-	PARA_DEBUG_LOG("resolved: %s\n", *resolved_path);
-	return *resolved_path? 1: -E_BAD_PATH;
+	else
+		*resolved_path = para_strdup(orig_path);
+	return 1;
+bad_path:
+	return -E_BAD_PATH;
 }
 
 enum afhi_offsets {
@@ -288,7 +286,7 @@ static unsigned sizeof_chunk_info_buf(struct audio_format_info *afhi)
 }
 
 /** The offsets of the data contained in the AFTCOL_CHUNKS column. */
-enum chunk_info_offsets {
+enum chunk_info_offsets{
 	/** The total number of chunks (4 bytes). */
 	CHUNKS_TOTAL_OFFSET = 0,
 	/** The length of the audio file header (4 bytes). */
@@ -353,7 +351,6 @@ int aft_get_row_of_path(char *path, struct osl_row **row)
 {
 	struct osl_object obj = {.data = path, .size = strlen(path) + 1};
 
-	PARA_NOTICE_LOG("audio_file_table: %p\n", audio_file_table);
 	return osl_get_row(audio_file_table, AFTCOL_PATH, &obj, row);
 }
 
@@ -981,7 +978,7 @@ static int com_ls_callback(const struct osl_object *query,
 			prepare_ls_row);
 	if (ret < 0)
 		goto out;
-	ret = opts->num_patterns? -E_NO_MATCH : 1;
+	ret = opts->num_patterns? -E_NO_MATCH : 0;
 	if (!opts->num_matching_paths) {
 		PARA_NOTICE_LOG("no match, ret: %d\n", ret);
 		goto out;
@@ -1004,6 +1001,7 @@ static int com_ls_callback(const struct osl_object *query,
 	ret = 1;
 out:
 	ls_output->data = b.buf;
+	PARA_NOTICE_LOG("ls_outoute.data: %p\n", ls_output->data);
 	ls_output->size = b.size;
 	free(opts->data);
 	free(opts->data_ptr);
@@ -1123,8 +1121,8 @@ int com_afs_ls(int fd, int argc, char * const * const argv)
 	opts.num_patterns = argc - i;
 	ret = send_option_arg_callback_request(&query, opts.num_patterns,
 		argv + i, com_ls_callback, &ls_output);
-	if (ret >= 0 && ls_output.data) {
-		send_buffer(fd, (char *)ls_output.data);
+	if (ret > 0) {
+		ret = send_buffer(fd, (char *)ls_output.data);
 		free(ls_output.data);
 	}
 	return ret;
@@ -1348,8 +1346,6 @@ static int com_add_callback(const struct osl_object *query,
 	default_afsi.last_played = time(NULL) - 365 * 24 * 60 * 60;
 	default_afsi.audio_format_id = read_u8(buf + AFTROW_AUDIO_FORMAT_OFFSET);
 
-	if (flags & ADD_FLAG_VERBOSE)
-		PARA_NOTICE_LOG("adding %s\n", path);
 	objs[AFTCOL_AFSI].data = &afsi_buf;
 	objs[AFTCOL_AFSI].size = AFSI_SIZE;
 	save_afsi(&default_afsi, &objs[AFTCOL_AFSI]);
@@ -1393,7 +1389,6 @@ static int hash_sister_callback(const struct osl_object *query,
 	return 1;
 }
 
-
 static int add_one_audio_file(const char *arg, const void *private_data)
 {
 	int ret;
@@ -1401,15 +1396,15 @@ static int add_one_audio_file(const char *arg, const void *private_data)
 	const struct private_add_data *pad = private_data;
 	struct audio_format_info afhi, *afhi_ptr = NULL;
 	struct osl_row *pb = NULL, *hs = NULL; /* path brother/hash sister */
-	struct osl_object map, obj, query, result;
-	char *path;
+	struct osl_object map, obj = {.data = NULL}, query, result;
+	char *path = NULL;
 	HASH_TYPE hash[HASH_SIZE];
 
 	afhi.header_offset = 0;
 	afhi.header_len = 0;
 	ret = verify_path(arg, &path);
 	if (ret < 0)
-		return ret;
+		goto out_free;
 	query.data = path;
 	query.size = strlen(path) + 1;
 	ret = send_callback_request(path_brother_callback, &query, &result);
@@ -1455,14 +1450,13 @@ static int add_one_audio_file(const char *arg, const void *private_data)
 	 */
 	if (!hs || (pad->flags & ADD_FLAG_FORCE)) {
 		ret = compute_afhi(path, map.data, map.size, &afhi);
-		if (ret < 0) {
-			ret = send_va_buffer(pad->fd,
-				"audio format of %s not recognized\n", path);
+		if (ret < 0)
 			goto out_unmap;
-		}
 		format_num = ret;
 		afhi_ptr = &afhi;
 	}
+	if (pad->flags & ADD_FLAG_VERBOSE)
+		send_va_buffer(pad->fd, "adding %s\n", path);
 	munmap(map.data, map.size);
 	save_audio_file_info(hash, path, afhi_ptr, pad->flags, format_num, &obj);
 	/* Ask afs to consider this entry for adding. */
@@ -1472,11 +1466,14 @@ static int add_one_audio_file(const char *arg, const void *private_data)
 out_unmap:
 	munmap(map.data, map.size);
 out_free:
+	if (ret < 0)
+		send_va_buffer(pad->fd, "failed to add %s (%s)\n", path?
+			path : arg, PARA_STRERROR(-ret));
 	free(obj.data);
 	free(path);
 	if (afhi_ptr)
 		free(afhi_ptr->chunk_table);
-	return ret;
+	return 1; /* it's not an error if not all files could be added */
 }
 
 int com_add(int fd, int argc, char * const * const argv)
@@ -1485,7 +1482,6 @@ int com_add(int fd, int argc, char * const * const argv)
 	struct private_add_data pad = {.fd = fd, .flags = 0};
 	struct stat statbuf;
 
-	PARA_NOTICE_LOG("argv[1]: %s\n", argv[1]);
 	for (i = 1; i < argc; i++) {
 		const char *arg = argv[i];
 		if (arg[0] != '-')
@@ -1510,22 +1506,23 @@ int com_add(int fd, int argc, char * const * const argv)
 	if (argc <= i)
 		return -E_AFT_SYNTAX;
 	for (; i < argc; i++) {
-		ret = stat(argv[i], &statbuf);
-		if (ret < 0)
-			return -E_AFS_STAT;
-		if (S_ISDIR(statbuf.st_mode)) {
-			ret = for_each_file_in_dir(argv[i],
-				add_one_audio_file, &pad);
-			if (ret < 0)
-				return ret;
-			continue;
-		}
-		ret = add_one_audio_file(argv[i], &pad);
+		char *path = para_strdup(argv[i]);
+		size_t len = strlen(path);
+		while (len > 1 && path[--len] == '/')
+			path[len] = '\0';
+		ret = stat(path, &statbuf);
 		if (ret < 0)
-			goto out;
+			PARA_NOTICE_LOG("failed to stat %s (%s)", path,
+				strerror(errno));
+		else
+			if (S_ISDIR(statbuf.st_mode))
+				for_each_file_in_dir(path, add_one_audio_file,
+					&pad);
+			else
+				add_one_audio_file(path, &pad);
+		free(path);
 	}
 	ret = 1;
-out:
 	return ret;
 
 }