X-Git-Url: http://git.tuebingen.mpg.de/?a=blobdiff_plain;f=dss.c;h=3a14e51d8fca8c954d2c0161952a9fd0896ee6ea;hb=5083502f5fbe2d2b427451aff54c0cdc1831d7c0;hp=b18be4d190f2faa29f5c0199dc0be65997a68b7e;hpb=4526f9ad9852a680fd93d1405f813c11054336bc;p=dss.git diff --git a/dss.c b/dss.c index b18be4d..3a14e51 100644 --- a/dss.c +++ b/dss.c @@ -324,9 +324,14 @@ static int exec_rm(void) { struct snapshot *s = snapshot_currently_being_removed; char *new_name = being_deleted_name(s); - char *argv[] = {"rm", "-rf", new_name, NULL}; + char *argv[4]; int ret; + argv[0] = "rm"; + argv[1] = "-rf"; + argv[2] = new_name; + argv[3] = NULL; + assert(snapshot_removal_status == HS_PRE_SUCCESS); assert(remove_pid == 0); @@ -908,13 +913,12 @@ static int parse_config_file(int override) goto out; } if (config_file_exists) { - struct cmdline_parser_params params = { - .override = override, - .initialize = 0, - .check_required = 1, - .check_ambiguity = 0, - .print_errors = 1 - }; + struct cmdline_parser_params params; + params.override = override; + params.initialize = 0; + params.check_required = 1; + params.check_ambiguity = 0; + params.print_errors = 1; if (override) { /* invalidate all rsync options */ int i; @@ -1019,12 +1023,14 @@ static int use_rsync_locally(char *logname) static int rename_resume_snap(int64_t creation_time) { - struct snapshot_list sl = {.num_snapshots = 0}; + struct snapshot_list sl; struct snapshot *s = NULL; char *new_name = incomplete_name(creation_time); int ret; const char *why; + sl.num_snapshots = 0; + ret = 0; if (conf.no_resume_given) goto out; @@ -1215,9 +1221,13 @@ out: static void exit_hook(int exit_code) { - char *argv[] = {conf.exit_hook_arg, dss_strerror(-exit_code), NULL}; + char *argv[3]; pid_t pid; + argv[0] = conf.exit_hook_arg; + argv[1] = dss_strerror(-exit_code); + argv[2] = NULL; + DSS_NOTICE_LOG("executing %s %s\n", argv[0], argv[1]); dss_exec(&pid, conf.exit_hook_arg, argv); } @@ -1386,13 +1396,13 @@ static int setup_signal_handling(void) int main(int argc, char **argv) { int ret; - struct cmdline_parser_params params = { - .override = 0, - .initialize = 1, - .check_required = 0, - .check_ambiguity = 0, - .print_errors = 1 - }; + struct cmdline_parser_params params; + + params.override = 0; + params.initialize = 1; + params.check_required = 0; + params.check_ambiguity = 0; + params.print_errors = 1; cmdline_parser_ext(argc, argv, &conf, ¶ms); /* aborts on errors */ ret = parse_config_file(0); @@ -1403,13 +1413,12 @@ int main(int argc, char **argv) * Parse the command line options again, but this time check * that all required options are given. */ - params = (struct cmdline_parser_params) { - .override = 1, - .initialize = 1, - .check_required = 1, - .check_ambiguity = 1, - .print_errors = 1 - }; + struct cmdline_parser_params params; + params.override = 1; + params.initialize = 1; + params.check_required = 1; + params.check_ambiguity = 1; + params.print_errors = 1; cmdline_parser_ext(argc, argv, &conf, ¶ms); /* aborts on errors */ } if (conf.daemon_given)