X-Git-Url: http://git.tuebingen.mpg.de/?a=blobdiff_plain;f=exec.c;h=7fc4ae069e0ad70902aaa1c9ff2e9721212e7392;hb=5440b8c0464829022a0ba5dd5daa931b15712a11;hp=86362c381fd8b3fe236caeddd4facec88130c901;hpb=86a605e4502fda6ef7fcac4cdf9f765d86438413;p=paraslash.git

diff --git a/exec.c b/exec.c
index 86362c38..7fc4ae06 100644
--- a/exec.c
+++ b/exec.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2003-2008 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2003-2009 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -37,7 +37,7 @@ static int para_exec(pid_t *pid, const char *file, char *const *const args, int
 	if (fds[2] > 0 && pipe(err) < 0)
 		goto err_out;
 	if (!fds[0] || !fds[1] || !fds[2]) {
-		ret = para_open("/dev/null", O_RDONLY, 42);
+		ret = para_open("/dev/null", O_RDWR, 42);
 		if (ret < 0)
 			goto err_out;
 		null = ret;
@@ -135,15 +135,13 @@ err_out:
  */
 int para_exec_cmdline_pid(pid_t *pid, const char *cmdline, int *fds)
 {
-	int argc, ret;
+	int ret;
 	char **argv;
-	char *tmp = para_strdup(cmdline);
 
-	if (!tmp)
-		exit(EXIT_FAILURE);
-	argc = split_args(tmp, &argv, " \t");
+	ret = create_argv(cmdline, " \t", &argv);
+	if (ret < 0)
+		return ret;
 	ret = para_exec(pid, argv[0], argv, fds);
-	free(argv);
-	free(tmp);
+	free_argv(argv);
 	return ret;
 }