X-Git-Url: http://git.tuebingen.mpg.de/?a=blobdiff_plain;f=gui.c;h=6eea455fdcd6175c4c4615c27b280e794be3a907;hb=e5d3cf2538f6fcb6a6f5271736c5e5b3dea4e7b1;hp=57cfe638dd5ba247763472b7bca4a2e5fd80748e;hpb=77a2aba5465a10dbe3d9fdb4bf306d1546a31ffa;p=paraslash.git

diff --git a/gui.c b/gui.c
index 57cfe638..6eea455f 100644
--- a/gui.c
+++ b/gui.c
@@ -34,8 +34,6 @@ static int signal_pipe;
 
 static struct gui_window {
 	WINDOW *win;
-	size_t cols;
-	size_t lines;
 } top, bot, sb, in, sep;
 
 #define RINGBUFFER_SIZE 512
@@ -45,7 +43,6 @@ struct rb_entry {
 	int color;
 };
 static struct ringbuffer *bot_win_rb;
-#define NUM_LINES(len) (1 + (len) / bot.cols)
 
 static unsigned scroll_position;
 
@@ -54,6 +51,7 @@ static pid_t cmd_pid;
 static int command_fds[2] = {-1, -1};
 static int stat_pipe = -1;
 static struct gui_args_info conf;
+static int loglevel;
 
 enum {GETCH_MODE, COMMAND_MODE, EXTERNAL_MODE};
 
@@ -203,6 +201,31 @@ static int find_cmd_byname(char *name)
 	return -1;
 }
 
+/*
+ * Even though ncurses provides getmaxx and getmaxy, these functions/macros are
+ * not described in the XSI Curses standard.
+ */
+static int get_num_lines(struct gui_window *w)
+{
+	int lines;
+	__a_unused int cols; /* avoid "set but not used" warnings */
+
+	getmaxyx(w->win, lines, cols);
+	return lines;
+}
+
+static int get_num_cols(struct gui_window *w)
+{
+	__a_unused int lines; /* avoid "set but not used" warnings */
+	int cols;
+
+	getmaxyx(w->win, lines, cols);
+	return cols;
+}
+
+/** Number of lines of the window are occupied by an output line. */
+#define NUM_LINES(len) (1 + (len) / get_num_cols(&bot))
+
 /* isendwin() returns false before initscr() was called */
 static bool curses_active(void)
 {
@@ -265,24 +288,6 @@ static char *km_keyname(int c)
 	return buf;
 }
 
-static char *configfile_exists(void)
-{
-	static char *config_file;
-	char *tmp;
-
-	if (!conf.config_file_given) {
-		if (!config_file) {
-			char *home = para_homedir();
-			config_file = make_message("%s/.paraslash/gui.conf",
-				home);
-			free(home);
-		}
-		tmp = config_file;
-	} else
-		tmp = conf.config_file_arg;
-	return file_exists(tmp)? tmp: NULL;
-}
-
 /* Print given number of spaces to curses window. */
 static void add_spaces(WINDOW* win, unsigned int num)
 {
@@ -354,7 +359,7 @@ __printf_2_3 static void print_in_bar(int color, const char *fmt,...)
 	xvasprintf(&msg, fmt, ap);
 	va_end(ap);
 	wmove(in.win, 0, 0);
-	align_str(in.win, msg, in.cols, LEFT);
+	align_str(in.win, msg, get_num_cols(&in), LEFT);
 	free(msg);
 	wrefresh(in.win);
 }
@@ -365,7 +370,7 @@ static void print_status_bar(void)
 
 	tmp = para_strdup("para_gui " PACKAGE_VERSION " (hit ? for help)");
 	wmove(sb.win, 0, 0);
-	align_str(sb.win, tmp, sb.cols, CENTER);
+	align_str(sb.win, tmp, get_num_cols(&sb), CENTER);
 	free(tmp);
 }
 
@@ -376,7 +381,8 @@ static void print_status_bar(void)
  */
 static int first_visible_rbe(unsigned *lines)
 {
-	int i;
+	int i, bot_lines = get_num_lines(&bot);
+
 	*lines = 0;
 	for (i = scroll_position; i < RINGBUFFER_SIZE; i++) {
 		struct rb_entry *rbe = ringbuffer_get(bot_win_rb, i);
@@ -384,10 +390,10 @@ static int first_visible_rbe(unsigned *lines)
 		if (!rbe)
 			return i - 1;
 		rbe_lines = NUM_LINES(rbe->len);
-		if (rbe_lines > bot.lines)
+		if (rbe_lines > bot_lines)
 			return -1;
 		*lines += rbe_lines;
-		if (*lines >= bot.lines)
+		if (*lines >= bot_lines)
 			return i;
 	}
 	return RINGBUFFER_SIZE - 1;
@@ -398,7 +404,7 @@ returns number of first visible rbe, *lines is the number of lines drawn.
  */
 static int draw_top_rbe(unsigned *lines)
 {
-	int ret, fvr = first_visible_rbe(lines);
+	int bot_cols, bot_lines, ret, fvr = first_visible_rbe(lines);
 	struct rb_entry *rbe;
 	size_t bytes_to_skip, cells_to_skip, width;
 
@@ -408,9 +414,10 @@ static int draw_top_rbe(unsigned *lines)
 	rbe = ringbuffer_get(bot_win_rb, fvr);
 	if (!rbe)
 		return -1;
-	if (*lines > bot.lines) {
+	getmaxyx(bot.win, bot_lines, bot_cols);
+	if (*lines > bot_lines) {
 		/* rbe is partially visible multi-line */
-		cells_to_skip = (*lines - bot.lines) * bot.cols;
+		cells_to_skip = (*lines - bot_lines) * bot_cols;
 		ret = skip_cells(rbe->msg, cells_to_skip, &bytes_to_skip);
 		if (ret < 0)
 			return ret;
@@ -430,14 +437,14 @@ static int draw_top_rbe(unsigned *lines)
 static void redraw_bot_win(void)
 {
 	unsigned lines;
-	int i;
+	int i, bot_lines = get_num_lines(&bot);
 
 	wmove(bot.win, 0, 0);
 	wclear(bot.win);
 	i = draw_top_rbe(&lines);
 	if (i <= 0)
 		goto out;
-	while (i > 0 && lines < bot.lines) {
+	while (i > 0 && lines < bot_lines) {
 		struct rb_entry *rbe = ringbuffer_get(bot_win_rb, --i);
 		if (!rbe) {
 			lines++;
@@ -510,8 +517,6 @@ static int add_output_line(char *line, void *data)
 	return 1;
 }
 
-static int loglevel;
-
 static __printf_2_3 void curses_log(int ll, const char *fmt,...)
 {
 	va_list ap;
@@ -572,11 +577,12 @@ static void print_stat_item(int i)
 	char *tmp;
 	struct stat_item_data d = theme.data[i];
 	char *c = stat_content[i];
+	int top_lines = get_num_lines(&top);
 
 	if (!curses_active() || !d.len || !c)
 		return;
 	tmp = make_message("%s%s%s", d.prefix, c, d.postfix);
-	wmove(top.win, d.y * top.lines / 100, d.x * COLS / 100);
+	wmove(top.win, d.y * top_lines / 100, d.x * COLS / 100);
 	wrefresh(top.win);
 	wattron(top.win, COLOR_PAIR(i + 1));
 	align_str(top.win, tmp, d.len * COLS / 100, d.align);
@@ -615,7 +621,27 @@ print:
 	return 1;
 }
 
-static int read_stat_pipe(fd_set *rfds)
+static void print_all_items(void)
+{
+	int i;
+
+	if (!curses_active())
+		return;
+	FOR_EACH_STATUS_ITEM(i)
+		print_stat_item(i);
+}
+
+static void clear_all_items(void)
+{
+	int i;
+
+	FOR_EACH_STATUS_ITEM(i) {
+		free(stat_content[i]);
+		stat_content[i] = para_strdup("");
+	}
+}
+
+static void status_post_select(fd_set *rfds)
 {
 	static char *buf;
 	static int bufsize, loaded;
@@ -623,11 +649,11 @@ static int read_stat_pipe(fd_set *rfds)
 	size_t sz;
 
 	if (stat_pipe < 0)
-		return 0;
+		return;
 	if (loaded >= bufsize) {
 		if (bufsize > 1000 * 1000) {
 			loaded = 0;
-			return 0;
+			return;
 		}
 		bufsize += bufsize + 1000;
 		buf = para_realloc(buf, bufsize);
@@ -639,33 +665,20 @@ static int read_stat_pipe(fd_set *rfds)
 	ret2 = for_each_stat_item(buf, loaded, update_item);
 	if (ret < 0 || ret2 < 0) {
 		loaded = 0;
-		return ret2 < 0? ret2 : ret;
+		PARA_NOTICE_LOG("closing stat pipe: %s\n", para_strerror(-ret));
+		close(stat_pipe);
+		stat_pipe = -1;
+		clear_all_items();
+		free(stat_content[SI_BASENAME]);
+		stat_content[SI_BASENAME] =
+			para_strdup("stat command terminated!?");
+		print_all_items();
+		return;
 	}
 	sz = ret2; /* what is left */
 	if (sz > 0 && sz < loaded)
 		memmove(buf, buf + loaded - sz, sz);
 	loaded = sz;
-	return 1;
-}
-
-static void print_all_items(void)
-{
-	int i;
-
-	if (!curses_active())
-		return;
-	FOR_EACH_STATUS_ITEM(i)
-		print_stat_item(i);
-}
-
-static void clear_all_items(void)
-{
-	int i;
-
-	FOR_EACH_STATUS_ITEM(i) {
-		free(stat_content[i]);
-		stat_content[i] = para_strdup("");
-	}
 }
 
 /*
@@ -675,35 +688,31 @@ static void init_wins(int top_lines)
 {
 	int top_y = 0, bot_y = top_lines + 1, sb_y = LINES - 2,
 		in_y = LINES - 1, sep_y = top_lines;
-
-	top.lines = top_lines;
-	bot.lines = LINES - top.lines - 3;
-	sb.lines = in.lines = sep.lines = 1;
-
-	top.cols = bot.cols = sb.cols = in.cols = sep.cols = COLS;
+	int bot_lines = LINES - top_lines - 3, sb_lines = 1, in_lines = 1,
+		sep_lines = 1;
 
 	assume_default_colors(theme.default_fg, theme.default_bg);
 	if (top.win) {
-		wresize(top.win, top.lines, top.cols);
+		wresize(top.win, top_lines, COLS);
 		mvwin(top.win, top_y, 0);
 
-		wresize(sb.win, sb.lines, sb.cols);
+		wresize(sb.win, sb_lines, COLS);
 		mvwin(sb.win, sb_y, 0);
 
-		wresize(sep.win, sep.lines, sep.cols);
+		wresize(sep.win, sep_lines, COLS);
 		mvwin(sep.win, sep_y, 0);
 
-		wresize(bot.win, bot.lines, bot.cols);
+		wresize(bot.win, bot_lines, COLS);
 		mvwin(bot.win, bot_y, 0);
 
-		wresize(in.win, in.lines, in.cols);
+		wresize(in.win, in_lines, COLS);
 		mvwin(in.win, in_y, 0);
 	} else {
-		sep.win = newwin(sep.lines, sep.cols, sep_y, 0);
-		top.win = newwin(top.lines, top.cols, top_y, 0);
-		bot.win = newwin(bot.lines, bot.cols, bot_y, 0);
-		sb.win = newwin(sb.lines, sb.cols, sb_y, 0);
-		in.win = newwin(in.lines, in.cols, in_y, 0);
+		sep.win = newwin(sep_lines, COLS, sep_y, 0);
+		top.win = newwin(top_lines, COLS, top_y, 0);
+		bot.win = newwin(bot_lines, COLS, bot_y, 0);
+		sb.win = newwin(sb_lines, COLS, sb_y, 0);
+		in.win = newwin(in_lines, COLS, in_y, 0);
 		if (!top.win || !bot.win || !sb.win || !in.win || !sep.win)
 			die(EXIT_FAILURE, "Error: Cannot create curses windows\n");
 		wclear(bot.win);
@@ -851,12 +860,68 @@ static void check_key_map_args_or_die(void)
 	free(tmp);
 }
 
+static void parse_config_file_or_die(bool override)
+{
+	bool err;
+	char *config_file;
+	struct gui_cmdline_parser_params params = {
+		.override = override,
+		.initialize = 0,
+		.check_required = !override,
+		.check_ambiguity = 0,
+		.print_errors = 1,
+	};
+
+	if (conf.config_file_given)
+		config_file = para_strdup(conf.config_file_arg);
+	else {
+		char *home = para_homedir();
+		config_file = make_message("%s/.paraslash/gui.conf", home);
+		free(home);
+	}
+	if (!file_exists(config_file)) {
+		if (!conf.config_file_given)
+			err = false;
+		else {
+			PARA_EMERG_LOG("config file %s does not exist\n",
+				config_file);
+			err = true;
+		}
+		goto out;
+	}
+	gui_cmdline_parser_config_file(config_file, &conf, &params);
+	loglevel = get_loglevel_by_name(conf.loglevel_arg);
+	check_key_map_args_or_die();
+	theme_init(conf.theme_arg, &theme);
+	err = false;
+out:
+	free(config_file);
+	if (err)
+		exit(EXIT_FAILURE);
+}
+
+/* reread configuration, terminate on errors */
+static void reread_conf(void)
+{
+	/*
+	 * gengetopt might print to stderr and exit on errors. So we have to
+	 * shutdown curses first.
+	 */
+	shutdown_curses();
+	parse_config_file_or_die(true /* override */);
+	init_curses();
+	print_in_bar(COLOR_MSG, "config file reloaded\n");
+}
+
 /*
  * React to various signal-related events
  */
-static void handle_signal(int sig)
+static void signal_post_select(fd_set *rfds)
 {
-	switch (sig) {
+	int ret = para_next_signal(rfds);
+	if (ret <= 0)
+		return;
+	switch (ret) {
 	case SIGTERM:
 		die(EXIT_FAILURE, "only the good die young (caught SIGTERM)\n");
 		return;
@@ -875,7 +940,7 @@ static void handle_signal(int sig)
 		return;
 	case SIGUSR1:
 		PARA_NOTICE_LOG("got SIGUSR1, rereading configuration\n");
-		com_reread_conf();
+		reread_conf();
 		return;
 	case SIGCHLD:
 		check_sigchld();
@@ -914,120 +979,62 @@ success:
 
 #define COMMAND_BUF_SIZE 32768
 
-/*
- * This is the core select loop. Besides the (internal) signal
- * pipe, the following other fds are checked according to the mode:
- *
- * GETCH_MODE: check stdin, return when key is pressed
- *
- * COMMAND_MODE: check command fds and stdin. Return when peer has closed both
- * stdout and stderr or when any key is pressed.
- *
- * EXTERNAL_MODE: Check only signal pipe. Used when an external command
- * is running. During that time curses is disabled.  Returns when
- * cmd_pid == 0.
- */
-static int do_select(int mode)
+static void command_pre_select(int mode, fd_set *rfds, int *max_fileno)
 {
-	fd_set rfds;
-	int ret, i, max_fileno;
-	char command_buf[2][COMMAND_BUF_SIZE] = {"", ""};
-	int cbo[2] = {0, 0}; /* command buf offsets */
-	struct timeval tv;
-	unsigned flags[2] = {0, 0}; /* for for_each_line() */
+	/* check command pipe only in COMMAND_MODE */
+	if (mode != COMMAND_MODE)
+		return;
+	if (command_fds[0] >= 0)
+		para_fd_set(command_fds[0], rfds, max_fileno);
+	if (command_fds[1] >= 0)
+		para_fd_set(command_fds[1], rfds, max_fileno);
+}
 
-repeat:
-	tv.tv_sec = conf.timeout_arg  / 1000;
-	tv.tv_usec = (conf.timeout_arg % 1000) * 1000;
-//	ret = refresh_status();
-	FD_ZERO(&rfds);
-	max_fileno = 0;
-	status_pre_select(&rfds, &max_fileno, &tv);
-	/* signal pipe */
-	para_fd_set(signal_pipe, &rfds, &max_fileno);
-	/* command pipe only for COMMAND_MODE */
-	if (mode == COMMAND_MODE) {
-		if (command_fds[0] >= 0)
-			para_fd_set(command_fds[0], &rfds, &max_fileno);
-		if (command_fds[1] >= 0)
-			para_fd_set(command_fds[1], &rfds, &max_fileno);
-	}
-	if (mode == GETCH_MODE || mode == COMMAND_MODE)
-		para_fd_set(STDIN_FILENO, &rfds, &max_fileno);
-	ret = para_select(max_fileno + 1, &rfds, NULL, &tv);
-	if (ret <= 0)
-		goto check_return; /* skip fd checks */
-	/* signals */
-	ret = para_next_signal(&rfds);
-	if (ret > 0)
-		handle_signal(ret);
-	/* read command pipe if ready */
-	if (mode == COMMAND_MODE) {
-		for (i = 0; i < 2; i++) {
-			size_t sz;
-			if (command_fds[i] < 0)
-				continue;
-			ret = read_nonblock(command_fds[i],
-				command_buf[i] + cbo[i],
-				COMMAND_BUF_SIZE - 1 - cbo[i], &rfds, &sz);
-			cbo[i] += sz;
-			sz = cbo[i];
-			cbo[i] = for_each_line(flags[i], command_buf[i], cbo[i],
-				add_output_line, &i);
-			if (sz != cbo[i]) { /* at least one line found */
-				wrefresh(bot.win);
-				flags[i] = 0;
-			}
-			if (ret < 0) {
-				PARA_NOTICE_LOG("closing command fd %d: %s\n",
-					i, para_strerror(-ret));
-				close(command_fds[i]);
-				command_fds[i] = -1;
-				flags[i] = 0;
-				cbo[i] = 0;
-				if (command_fds[!i] < 0) /* both fds closed */
-					return 0;
-			}
-			if (cbo[i] == COMMAND_BUF_SIZE - 1) {
-				PARA_NOTICE_LOG("discarding overlong line\n");
-				cbo[i] = 0;
-				flags[i] = FELF_DISCARD_FIRST;
-			}
+static int command_post_select(int mode, fd_set *rfds)
+{
+	int i, ret;
+	static char command_buf[2][COMMAND_BUF_SIZE];
+	static int cbo[2]; /* command buf offsets */
+	static unsigned flags[2]; /* for for_each_line() */
+
+	if (mode != COMMAND_MODE)
+		return 0;
+	for (i = 0; i < 2; i++) {
+		size_t sz;
+		if (command_fds[i] < 0)
+			continue;
+		ret = read_nonblock(command_fds[i],
+			command_buf[i] + cbo[i],
+			COMMAND_BUF_SIZE - 1 - cbo[i], rfds, &sz);
+		cbo[i] += sz;
+		sz = cbo[i];
+		cbo[i] = for_each_line(flags[i], command_buf[i], cbo[i],
+			add_output_line, &i);
+		if (sz != cbo[i]) { /* at least one line found */
+			wrefresh(bot.win);
+			flags[i] = 0;
 		}
-	}
-	ret = read_stat_pipe(&rfds);
-	if (ret < 0) {
-		PARA_NOTICE_LOG("closing stat pipe: %s\n", para_strerror(-ret));
-		close(stat_pipe);
-		stat_pipe = -1;
-		clear_all_items();
-		free(stat_content[SI_BASENAME]);
-		stat_content[SI_BASENAME] =
-			para_strdup("stat command terminated!?");
-		print_all_items();
-	}
-check_return:
-	switch (mode) {
-	case COMMAND_MODE:
-		ret = wgetch(top.win);
-		if (ret != ERR && ret != KEY_RESIZE) {
-			if (cmd_pid)
-				kill(cmd_pid, SIGTERM);
-			return -1;
+		if (ret < 0) {
+			PARA_NOTICE_LOG("closing command fd %d: %s",
+				i, para_strerror(-ret));
+			close(command_fds[i]);
+			command_fds[i] = -1;
+			flags[i] = 0;
+			cbo[i] = 0;
+			if (command_fds[!i] < 0) /* both fds closed */
+				return -1;
+		}
+		if (cbo[i] == COMMAND_BUF_SIZE - 1) {
+			PARA_NOTICE_LOG("discarding overlong line");
+			cbo[i] = 0;
+			flags[i] = FELF_DISCARD_FIRST;
 		}
-		break;
-	case GETCH_MODE:
-		ret = wgetch(top.win);
-		if (ret != ERR && ret != KEY_RESIZE)
-			return ret;
-		break;
-	case EXTERNAL_MODE:
-		if (cmd_pid == 0)
-			return 0;
 	}
-	goto repeat;
+	return 1;
 }
 
+static int do_select(int mode);
+
 /* read from command pipe and print data to bot window */
 static void exec_and_display_cmd(const char *cmd)
 {
@@ -1089,6 +1096,131 @@ static void external_cmd(char *cmd)
 	init_curses();
 }
 
+static void handle_command(int c)
+{
+	int i;
+
+	/* first check user-defined key bindings */
+	for (i = 0; i < conf.key_map_given; ++i) {
+		char *tmp, *handler, *arg;
+
+		tmp = para_strdup(conf.key_map_arg[i]);
+		if (!split_key_map(tmp, &handler, &arg)) {
+			free(tmp);
+			return;
+		}
+		if (strcmp(tmp, km_keyname(c))) {
+			free(tmp);
+			continue;
+		}
+		if (*handler == 'd')
+			display_cmd(arg);
+		else if (*handler == 'x')
+			external_cmd(arg);
+		else if (*handler == 'p')
+			para_cmd(arg);
+		else if (*handler == 'i') {
+			int num = find_cmd_byname(arg);
+			if (num >= 0)
+				command_list[num].handler();
+		}
+		free(tmp);
+		return;
+	}
+	/* not found, check internal key bindings */
+	for (i = 0; command_list[i].handler; i++) {
+		if (!strcmp(km_keyname(c), command_list[i].key)) {
+			command_list[i].handler();
+			return;
+		}
+	}
+	print_in_bar(COLOR_ERRMSG, "key '%s' is not bound, press ? for help",
+		km_keyname(c));
+}
+
+static void input_pre_select(int mode, fd_set *rfds, int *max_fileno)
+{
+	if (mode == GETCH_MODE || mode == COMMAND_MODE)
+		para_fd_set(STDIN_FILENO, rfds, max_fileno);
+}
+
+static int input_post_select(int mode)
+{
+	int ret;
+
+	switch (mode) {
+	case COMMAND_MODE:
+		ret = wgetch(top.win);
+		if (ret != ERR && ret != KEY_RESIZE) {
+			if (cmd_pid)
+				kill(cmd_pid, SIGTERM);
+			return -1;
+		}
+		return 0;
+	case GETCH_MODE:
+		ret = wgetch(top.win);
+		if (ret != ERR && ret != KEY_RESIZE)
+			return ret;
+		return 0;
+	case EXTERNAL_MODE:
+		if (cmd_pid == 0)
+			return -1;
+		return 0;
+	default:
+		assert(false); /* bug */
+	}
+}
+
+static void signal_pre_select(fd_set *rfds, int *max_fileno)
+{
+	para_fd_set(signal_pipe, rfds, max_fileno);
+}
+
+/*
+ * This is the core select loop. Besides the (internal) signal
+ * pipe, the following other fds are checked according to the mode:
+ *
+ * GETCH_MODE: check stdin, return when key is pressed
+ *
+ * COMMAND_MODE: check command fds and stdin. Return when peer has closed both
+ * stdout and stderr or when any key is pressed.
+ *
+ * EXTERNAL_MODE: Check only signal pipe. Used when an external command
+ * is running. During that time curses is disabled.  Returns when
+ * cmd_pid == 0.
+ */
+static int do_select(int mode)
+{
+	fd_set rfds;
+	int ret, max_fileno;
+	struct timeval tv;
+
+repeat:
+	tv.tv_sec = conf.timeout_arg  / 1000;
+	tv.tv_usec = (conf.timeout_arg % 1000) * 1000;
+//	ret = refresh_status();
+	FD_ZERO(&rfds);
+	max_fileno = 0;
+	status_pre_select(&rfds, &max_fileno, &tv);
+	signal_pre_select(&rfds, &max_fileno);
+	command_pre_select(mode, &rfds, &max_fileno);
+	input_pre_select(mode, &rfds, &max_fileno);
+	ret = para_select(max_fileno + 1, &rfds, NULL, &tv);
+	if (ret <= 0)
+		goto check_return; /* skip fd checks */
+	signal_post_select(&rfds);
+	/* read command pipe if ready */
+	ret = command_post_select(mode, &rfds);
+	if (ret < 0)
+		return 0;
+	status_post_select(&rfds);
+check_return:
+	ret = input_post_select(mode);
+	if (ret != 0)
+		return ret;
+	goto repeat;
+}
+
 static void print_scroll_msg(void)
 {
 	unsigned lines_total, filled = ringbuffer_filled(bot_win_rb);
@@ -1100,13 +1232,13 @@ static void print_scroll_msg(void)
 
 static void com_scroll_top(void)
 {
-	int i = RINGBUFFER_SIZE - 1;
+	int i = RINGBUFFER_SIZE - 1, bot_lines = get_num_lines(&bot);
 	unsigned lines = 0;
 
 	while (i > 0 && !ringbuffer_get(bot_win_rb, i))
 		i--;
 	/* i is oldest entry */
-	for (; lines < bot.lines && i >= 0; i--) {
+	for (; lines < bot_lines && i >= 0; i--) {
 		struct rb_entry *rbe = ringbuffer_get(bot_win_rb, i);
 		if (!rbe)
 			break;
@@ -1136,9 +1268,9 @@ static void com_cancel_scrolling(void)
 static void com_page_down(void)
 {
 	unsigned lines = 0;
-	int i = scroll_position;
+	int i = scroll_position, bot_lines = get_num_lines(&bot);
 
-	while (lines < bot.lines && --i > 0) {
+	while (lines < bot_lines && --i > 0) {
 		struct rb_entry *rbe = ringbuffer_get(bot_win_rb, i);
 		if (!rbe)
 			break;
@@ -1156,7 +1288,7 @@ static void com_page_down(void)
 static void com_page_up(void)
 {
 	unsigned lines;
-	int fvr = first_visible_rbe(&lines);
+	int fvr = first_visible_rbe(&lines), bot_lines = get_num_lines(&bot);
 
 	if (fvr < 0 || fvr + 1 >= ringbuffer_filled(bot_win_rb)) {
 		print_in_bar(COLOR_ERRMSG, "top of buffer is shown\n");
@@ -1165,7 +1297,7 @@ static void com_page_up(void)
 	scroll_position = fvr + 1;
 	for (; scroll_position > 0; scroll_position--) {
 		first_visible_rbe(&lines);
-		if (lines == bot.lines)
+		if (lines == bot_lines)
 			break;
 	}
 	redraw_bot_win();
@@ -1175,7 +1307,7 @@ static void com_page_up(void)
 static void com_scroll_down(void)
 {
 	struct rb_entry *rbe;
-	int rbe_lines;
+	int rbe_lines, bot_lines = get_num_lines(&bot);
 
 	if (!scroll_position) {
 		print_in_bar(COLOR_ERRMSG, "bottom of buffer is shown\n");
@@ -1185,7 +1317,7 @@ static void com_scroll_down(void)
 	rbe = ringbuffer_get(bot_win_rb, scroll_position);
 	rbe_lines = NUM_LINES(rbe->len);
 	wscrl(bot.win, rbe_lines);
-	wmove(bot.win, bot.lines - rbe_lines, 0);
+	wmove(bot.win, bot_lines - rbe_lines, 0);
 	wattron(bot.win, COLOR_PAIR(rbe->color));
 	waddstr(bot.win, rbe->msg);
 	wrefresh(bot.win);
@@ -1254,34 +1386,9 @@ static void com_ll_incr(void)
 	print_in_bar(COLOR_MSG, "loglevel set to %d\n", loglevel);
 }
 
-/*
- * reread configuration, terminate on errors
- */
 static void com_reread_conf(void)
 {
-	char *cf = configfile_exists();
-	struct gui_cmdline_parser_params params = {
-		.override = 1,
-		.initialize = 1,
-		.check_required = 0,
-		.check_ambiguity = 0,
-		.print_errors = 0,
-	};
-
-	if (!cf) {
-		PARA_WARNING_LOG("there is no configuration to read\n");
-		return;
-	}
-	PARA_INFO_LOG("rereading command line options and config file\n");
-	/*
-	 * Despite .print_errors is set to 0, gengetopt will print to stderr
-	 * anyway, and exit on errors. So we have to shutdown curses first.
-	 */
-	shutdown_curses();
-	gui_cmdline_parser_config_file(cf, &conf, &params);
-	init_curses();
-	PARA_NOTICE_LOG("config file reloaded\n");
-	check_key_map_args_or_die();
+	reread_conf();
 }
 
 static void com_help(void)
@@ -1323,21 +1430,25 @@ static void com_help(void)
 
 static void com_shrink_top_win(void)
 {
-	if (top.lines <= theme.top_lines_min) {
+	int top_lines = get_num_lines(&top);
+
+	if (top_lines <= theme.top_lines_min) {
 		PARA_WARNING_LOG("can not decrease top window\n");
 		return;
 	}
-	init_wins(top.lines - 1);
+	init_wins(top_lines - 1);
 	print_in_bar(COLOR_MSG, "%s", "decreased top window");
 }
 
 static void com_enlarge_top_win(void)
 {
-	if (bot.lines < 3) {
+	int top_lines = get_num_lines(&top), bot_lines = get_num_lines(&bot);
+
+	if (bot_lines < 3) {
 		PARA_WARNING_LOG("can not increase top window\n");
 		return;
 	}
-	init_wins(top.lines + 1);
+	init_wins(top_lines + 1);
 	print_in_bar(COLOR_MSG, "increased top window");
 }
 
@@ -1369,48 +1480,6 @@ static void com_prev_theme(void)
 	com_refresh();
 }
 
-static void handle_command(int c)
-{
-	int i;
-
-	/* first check user-defined key bindings */
-	for (i = 0; i < conf.key_map_given; ++i) {
-		char *tmp, *handler, *arg;
-
-		tmp = para_strdup(conf.key_map_arg[i]);
-		if (!split_key_map(tmp, &handler, &arg)) {
-			free(tmp);
-			return;
-		}
-		if (strcmp(tmp, km_keyname(c))) {
-			free(tmp);
-			continue;
-		}
-		if (*handler == 'd')
-			display_cmd(arg);
-		else if (*handler == 'x')
-			external_cmd(arg);
-		else if (*handler == 'p')
-			para_cmd(arg);
-		else if (*handler == 'i') {
-			int num = find_cmd_byname(arg);
-			if (num >= 0)
-				command_list[num].handler();
-		}
-		free(tmp);
-		return;
-	}
-	/* not found, check internal key bindings */
-	for (i = 0; command_list[i].handler; i++) {
-		if (!strcmp(km_keyname(c), command_list[i].key)) {
-			command_list[i].handler();
-			return;
-		}
-	}
-	print_in_bar(COLOR_ERRMSG, "key '%s' is not bound, press ? for help",
-		km_keyname(c));
-}
-
 __noreturn static void print_help_and_die(void)
 {
 	struct ggo_help h = DEFINE_GGO_HELP(gui);
@@ -1423,30 +1492,13 @@ __noreturn static void print_help_and_die(void)
 int main(int argc, char *argv[])
 {
 	int ret;
-	char *cf;
 
 	gui_cmdline_parser(argc, argv, &conf); /* exits on errors */
 	loglevel = get_loglevel_by_name(conf.loglevel_arg);
 	version_handle_flag("gui", conf.version_given);
 	if (conf.help_given || conf.detailed_help_given)
 		print_help_and_die();
-	cf = configfile_exists();
-	if (!cf && conf.config_file_given)
-		die(EXIT_FAILURE, "can not read config file %s\n",
-			conf.config_file_arg);
-	if (cf) {
-		struct gui_cmdline_parser_params params = {
-			.override = 0,
-			.initialize = 0,
-			.check_required = 0,
-			.check_ambiguity = 0,
-			.print_errors = 1,
-		};
-		gui_cmdline_parser_config_file(cf, &conf, &params);
-		loglevel = get_loglevel_by_name(conf.loglevel_arg);
-	}
-	check_key_map_args_or_die();
-	theme_init(conf.theme_arg, &theme);
+	parse_config_file_or_die(false /* override */);
 	setup_signal_handling();
 	bot_win_rb = ringbuffer_new(RINGBUFFER_SIZE);
 	setlocale(LC_CTYPE, "");