X-Git-Url: http://git.tuebingen.mpg.de/?a=blobdiff_plain;f=server.c;h=9c11b23cbb4801f15e08ae3c1a0a559322b38578;hb=4fbe16430b4776814128d7110682c69d1b047c57;hp=2018b8eece1988206e2992f560b65fa73059ff5e;hpb=e32a0e7295c6386b421956553ae577a7df1abf8e;p=paraslash.git

diff --git a/server.c b/server.c
index 2018b8ee..9c11b23c 100644
--- a/server.c
+++ b/server.c
@@ -45,6 +45,7 @@
 #include "afh.h"
 #include "string.h"
 #include "afs.h"
+#include "net.h"
 #include "server.h"
 #include "list.h"
 #include "send.h"
@@ -52,7 +53,6 @@
 #include "vss.h"
 #include "config.h"
 #include "close_on_fork.h"
-#include "net.h"
 #include "daemon.h"
 #include "ipc.h"
 #include "fd.h"
@@ -86,7 +86,15 @@ struct lls_parse_result *server_lpr = NULL;
 /* Command line options (no config file options). Used in handle_sighup(). */
 static struct lls_parse_result *cmdline_lpr;
 
-/** A random value used in child context for authentication. */
+/**
+ * A random number used to "authenticate" the afs connection.
+ *
+ * para_server picks this number by random before it forks the afs process. The
+ * command handlers know this number as well and write it to the afs socket,
+ * together with the id of the shared memory area which contains the payload of
+ * the afs command. A local process has to know this number to abuse the afs
+ * service provided by the local socket.
+ */
 uint32_t afs_socket_cookie;
 
 /** The mutex protecting the shared memory area containing the mmd struct. */
@@ -100,8 +108,9 @@ pid_t afs_pid = 0;
 
 /** The task responsible for server command handling. */
 struct server_command_task {
-	/** TCP port on which para_server listens for connections. */
-	int listen_fd;
+	unsigned num_listen_fds; /* only one by default */
+	/** TCP socket(s) on which para_server listens for connections. */
+	int *listen_fds;
 	/** Copied from para_server's main function. */
 	int argc;
 	/** Argument vector passed to para_server's main function. */
@@ -177,7 +186,6 @@ void parse_config_or_die(bool reload)
 	struct lls_parse_result *cf_lpr, *merged_lpr;
 	char *home = para_homedir();
 
-	daemon_close_log();
 	if (OPT_GIVEN(CONFIG_FILE))
 		cf = para_strdup(OPT_STRING_VAL(CONFIG_FILE));
 	else
@@ -339,20 +347,22 @@ static void init_signal_task(void)
 
 static void command_pre_select(struct sched *s, void *context)
 {
+	unsigned n;
 	struct server_command_task *sct = context;
-	para_fd_set(sct->listen_fd, &s->rfds, &s->max_fileno);
+
+	for (n = 0; n < sct->num_listen_fds; n++)
+		para_fd_set(sct->listen_fds[n], &s->rfds, &s->max_fileno);
 }
 
-static int command_post_select(struct sched *s, void *context)
+static int command_task_accept(unsigned listen_idx, fd_set *rfds,
+		struct server_command_task *sct)
 {
-	struct server_command_task *sct = context;
-
 	int new_fd, ret, i;
 	char *peer_name;
 	pid_t child_pid;
 	uint32_t *chunk_table;
 
-	ret = para_accept(sct->listen_fd, &s->rfds, NULL, 0, &new_fd);
+	ret = para_accept(sct->listen_fds[listen_idx], rfds, NULL, 0, &new_fd);
 	if (ret <= 0)
 		goto out;
 	mmd->num_connects++;
@@ -403,23 +413,61 @@ out:
 	return 0;
 }
 
+static int command_post_select(struct sched *s, void *context)
+{
+	struct server_command_task *sct = context;
+	unsigned n;
+	int ret;
+
+	for (n = 0; n < sct->num_listen_fds; n++) {
+		ret = command_task_accept(n, &s->rfds, sct);
+		if (ret < 0) {
+			free(sct->listen_fds);
+			return ret;
+		}
+	}
+	return 0;
+}
+
 static void init_server_command_task(int argc, char **argv)
 {
 	int ret;
 	static struct server_command_task server_command_task_struct,
 		*sct = &server_command_task_struct;
+	unsigned n;
+	uint32_t port = OPT_UINT32_VAL(PORT);
+
 
 	PARA_NOTICE_LOG("initializing tcp command socket\n");
 	sct->argc = argc;
 	sct->argv = argv;
-	ret = para_listen_simple(IPPROTO_TCP, OPT_UINT32_VAL(PORT));
-	if (ret < 0)
-		goto err;
-	sct->listen_fd = ret;
-	ret = mark_fd_nonblocking(sct->listen_fd);
-	if (ret < 0)
-		goto err;
-	add_close_on_fork_list(sct->listen_fd); /* child doesn't need the listener */
+	if (!OPT_GIVEN(LISTEN_ADDRESS)) {
+		sct->num_listen_fds = 1;
+		sct->listen_fds = para_malloc(sizeof(int));
+		ret = para_listen_simple(IPPROTO_TCP, port);
+		if (ret < 0)
+			goto err;
+		sct->listen_fds[0] = ret;
+	} else {
+		sct->num_listen_fds = OPT_GIVEN(LISTEN_ADDRESS);
+		sct->listen_fds = para_malloc(sct->num_listen_fds * sizeof(int));
+		for (n = 0; n < OPT_GIVEN(LISTEN_ADDRESS); n++) {
+			const char *arg;
+			arg = lls_string_val(n, OPT_RESULT(LISTEN_ADDRESS));
+			ret = para_listen(IPPROTO_TCP, arg, port);
+			if (ret < 0)
+				goto err;
+			sct->listen_fds[n] = ret;
+		}
+	}
+	for (n = 0; n < sct->num_listen_fds; n++) {
+		ret = mark_fd_nonblocking(sct->listen_fds[n]);
+		if (ret < 0)
+			goto err;
+		/* child doesn't need the listener */
+		add_close_on_fork_list(sct->listen_fds[n]);
+	}
+
 	sct->task = task_register(&(struct task_info) {
 		.name = "server command",
 		.pre_select = command_pre_select,
@@ -454,7 +502,7 @@ static int init_afs(int argc, char **argv)
 		i = argc - lls_num_inputs(cmdline_lpr) - 1;
 		sprintf(argv[i], "para_server (afs)");
 		close(afs_server_socket[0]);
-		afs_init(afs_socket_cookie, afs_server_socket[1]);
+		afs_init(afs_server_socket[1]);
 	}
 	close(afs_server_socket[1]);
 	if (read(afs_server_socket[0], &c, 1) <= 0) {