X-Git-Url: http://git.tuebingen.mpg.de/?a=blobdiff_plain;f=write_common.c;h=316c87ef1f818469c061cf9dc12635d1613fd4ad;hb=f8f6605a4f02a15378a36618dbfacfc862fc6192;hp=8fb6c3d10797c4fc7ea4119de5c990271f177482;hpb=00e4d4da1b2c00da139b09d3ed4ab9ad9fba2691;p=paraslash.git

diff --git a/write_common.c b/write_common.c
index 8fb6c3d1..316c87ef 100644
--- a/write_common.c
+++ b/write_common.c
@@ -27,6 +27,8 @@ static void wng_pre_select(__a_unused struct sched *s, struct task *t)
 
 	FOR_EACH_WRITER_NODE(i, g) {
 		struct writer_node *wn = &g->writer_nodes[i];
+		if (!wn->writer->pre_select)
+			continue;
 		t->error = wn->writer->pre_select(s, wn);
 		if (t->error < 0)
 			return;
@@ -61,7 +63,7 @@ static void wng_post_select(struct sched *s, struct task *t)
 	}
 	if (*g->loaded && min_written) {
 //		PARA_INFO_LOG("moving %zd bytes\n", *g->loaded);
-		memmove(g->buf, g->buf + min_written, *g->loaded);
+		memmove(*g->bufp, *g->bufp + min_written, *g->loaded);
 	}
 }
 
@@ -86,8 +88,6 @@ int wng_open(struct writer_node_group *g)
 		ret = wn->writer->open(wn);
 		if (ret < 0)
 			goto err_out;
-		wn->chunk_bytes = ret;
-		g->max_chunk_bytes = PARA_MAX(g->max_chunk_bytes, ret);
 	}
 	sprintf(g->task.status, "%s", "writer node group");
 	register_task(&g->task);
@@ -99,7 +99,9 @@ err_out:
 		struct writer_node *wn = &g->writer_nodes[--i];
 		wn->writer->close(wn);
 	}
+	free(g->writer_nodes);
 	g->num_writers = 0;
+	g->task.error = -E_TASK_UNREGISTERED;
 	return ret;
 }
 
@@ -144,9 +146,9 @@ struct writer_node_group *wng_new(unsigned num_writers)
 }
 
 /**
- * call the init function of each supported paraslash writer
+ * Call the init function of each supported paraslash writer.
  */
-void init_supported_writers(void)
+void writer_init(void)
 {
 	int i;
 
@@ -211,7 +213,11 @@ struct writer_node_group *setup_default_wng(void)
 	wng->writer_nodes[0].conf = writers[DEFAULT_WRITER].parse_config("");
 	return wng;
 }
-
+/**
+ * Print the help text of all writers to stdout.
+ *
+ * \param detailed Whether to print the detailed help text.
+ */
 void print_writer_helps(int detailed)
 {
 	int i;