From: Andre Noll Date: Mon, 13 Jun 2016 15:54:37 +0000 (+0200) Subject: Fix rsync exit handling in create mode. X-Git-Tag: v0.1.7~15 X-Git-Url: http://git.tuebingen.mpg.de/?a=commitdiff_plain;ds=sidebyside;h=0f2b297697d2c5d0ab9ee71d51c2e47fb4508aba;hp=0f2b297697d2c5d0ab9ee71d51c2e47fb4508aba;p=dss.git Fix rsync exit handling in create mode. The logic in handle_rsync_exit() is horribly broken in case dss is run in create mode and the rsync process terminates unsuccessfully. First we claim to restart rsync, which is wrong. Next we call the post-create hook despite the documentation says that this hook is only run on *successful* termination. Finally, we dereference a NULL pointer to print the path of the snapshot. Fortunately, all three issues are easy to fix by special casing create mode in handle_rsync_exit(). ---