From: Andre Noll Date: Sat, 27 Jan 2018 11:08:04 +0000 (+0100) Subject: aft: Avoid implicit fallthrough in switch statement. X-Git-Tag: v0.6.2~41 X-Git-Url: http://git.tuebingen.mpg.de/?a=commitdiff_plain;ds=sidebyside;h=23dd2200dd4fc74025ae87f5c2127f3b0ff71e9b;p=paraslash.git aft: Avoid implicit fallthrough in switch statement. The missing return statement causes gcc-7 to complain: aft.c:2579:3: warning: this statement may fall through [-Wimplicit-fallthrough=] And indeed, this fall through was not intended when the code in question was introduced some months ago in commit a7a8d30e (Update status items on blob events). The issue is benign though, because also after falling through we return 0. --- diff --git a/aft.c b/aft.c index 44337306..1234ee5a 100644 --- a/aft.c +++ b/aft.c @@ -2577,6 +2577,7 @@ static int aft_event_handler(enum afs_events event, struct para_buffer *pb, * every time. */ make_status_items(); + return 0; } default: return 0; }