From: Andre Noll <maan@tuebingen.mpg.de>
Date: Fri, 21 Apr 2017 19:22:34 +0000 (+0200)
Subject: audioc: Avoid double free in audioc_i9e_line_handler().
X-Git-Tag: v0.6.0~2^2
X-Git-Url: http://git.tuebingen.mpg.de/?a=commitdiff_plain;h=1789666b13d830b97f7b95fa5296ecc4fb199b22;p=paraslash.git

audioc: Avoid double free in audioc_i9e_line_handler().

If connect_audiod() returns negative, we free "args" twice. Found by
the clang static analyzer.
---

diff --git a/audioc.c b/audioc.c
index f2e20bab..38a8db5d 100644
--- a/audioc.c
+++ b/audioc.c
@@ -200,7 +200,7 @@ static int audioc_i9e_line_handler(char *line)
 	ret = connect_audiod(socket_name, args);
 	free(args);
 	if (ret < 0)
-		goto out;
+		return ret;
 	at->fd = ret;
 	ret = mark_fd_nonblocking(at->fd);
 	if (ret < 0)
@@ -217,8 +217,6 @@ static int audioc_i9e_line_handler(char *line)
 	return 1;
 close:
 	close(at->fd);
-out:
-	free(args);
 	return ret;
 }