Make struct admissible uids local.

[adu.git] / select.c

diff --git a/select.c b/select.c
index 801aba4fe2bc9af8924c97c2a1a78c0810534bd0..e3d97b11ef7893f09ba89008aa1994b30318fc39 100644 (file)
--- a/select.c
+++ b/select.c
@@ -77,9 +77,6 @@ static const uint64_t count_unit_divisors[] = {
 
 static const char size_unit_abbrevs[] = " BKMGT";
 static const char count_unit_abbrevs[] = "  kmgt";
-struct select_args_info select_conf;
-static struct uid_range *admissible_uids;
-
 static enum enum_size_unit format_size_value(enum enum_size_unit unit,
                uint64_t value, int print_unit, char *result)
 {
@@ -136,7 +133,7 @@ again:
        ret = osl(osl_get_object(dir_table, row, DT_NAME, &obj));
        if (ret < 0)
                goto out;
-       pfx = (conf.print_base_dir_given || val)? (char *)obj.data :  ".";
+       pfx = (select_conf.print_base_dir_given || val)? (char *)obj.data :  ".";
        tmp = make_message("%s/%s", pfx, result? result : "");
        free(result);
        result = tmp;
@@ -339,13 +336,13 @@ static void print_global_summary(void)
        enum enum_count_unit ud, uf;
        enum enum_size_unit us;
 
-       if (conf.no_global_summary_given)
+       if (select_conf.no_global_summary_given)
                return;
        ud = format_count_value(select_conf.count_unit_arg, num_dirs, 0, d);
        uf = format_count_value(select_conf.count_unit_arg, num_files, 0, f);
        us = format_size_value(select_conf.size_unit_arg, num_bytes, 0, s);
 
-       if (!conf.no_headers_given)
+       if (!select_conf.no_headers_given)
                printf("Global summary "
                        "(dirs(%c)/files(%c)/size(%c))\n",
                        count_unit_abbrevs[ud],
@@ -434,7 +431,7 @@ static void print_user_summary(void)
 {
        if (select_conf.no_user_summary_given)
                return;
-       if (!conf.no_headers_given)
+       if (!select_conf.no_headers_given)
                printf("User summary "
                        "(pw_name/uid/dirs%s/files%s/size%s):\n",
                        count_unit_buf, count_unit_buf, size_unit_buf);
@@ -446,7 +443,7 @@ static int print_user_list(struct user_info *ui, __a_unused void *data)
 {
        int ret;
        struct user_stats_info usi;
-       enum enum_user_list ula = conf.user_list_arg;
+       enum enum_user_list ula = select_conf.user_list_arg;
        int print_size_list = (ula == user_list_arg_size
                || ula == user_list_arg_both);
 
@@ -454,7 +451,7 @@ static int print_user_list(struct user_info *ui, __a_unused void *data)
                usi.count = select_conf.limit_arg;
                usi.ui = ui;
                usi.flags = USF_PRINT_DIRNAME | USF_PRINT_BYTES | USF_COMPUTE_SUMMARY;
-               if (!conf.no_headers_given)
+               if (!select_conf.no_headers_given)
                        printf("%s (uid %u), by size%s:\n",
                                ui->pw_name? ui->pw_name : "?", (unsigned)ui->uid,
                                size_unit_buf);
@@ -465,7 +462,7 @@ static int print_user_list(struct user_info *ui, __a_unused void *data)
                printf("\n");
        }
        if (ula == user_list_arg_file_count || ula == user_list_arg_both) {
-               if (!conf.no_headers_given)
+               if (!select_conf.no_headers_given)
                        printf("%s (uid %u), by file count%s:\n",
                                ui->pw_name? ui->pw_name : "?", (unsigned)ui->uid,
                                count_unit_buf);
@@ -499,14 +496,14 @@ static int print_global_lists(void)
 {
        struct global_stats_info gsi;
        int ret;
-       enum enum_global_list gla = conf.global_list_arg;
+       enum enum_global_list gla = select_conf.global_list_arg;
        int print_size_list = (gla == global_list_arg_size
                || gla == global_list_arg_both);
 
        if (print_size_list) {
                gsi.count = select_conf.limit_arg;
                gsi.flags = GSF_PRINT_DIRNAME | GSF_PRINT_BYTES | GSF_COMPUTE_SUMMARY;
-               if (!conf.no_headers_given)
+               if (!select_conf.no_headers_given)
                        printf("By size%s:\n", size_unit_buf);
                ret = adu_loop_reverse(dir_table, DT_BYTES, &gsi,
                        global_stats_loop_function, &gsi.ret, &gsi.osl_errno);
@@ -519,7 +516,7 @@ static int print_global_lists(void)
                gsi.flags = GSF_PRINT_DIRNAME | GSF_PRINT_FILES;
                if (!print_size_list)
                        gsi.flags |= GSF_COMPUTE_SUMMARY;
-               if (!conf.no_headers_given)
+               if (!select_conf.no_headers_given)
                        printf("By file count%s:\n", count_unit_buf);
                ret = adu_loop_reverse(dir_table, DT_FILES, &gsi,
                        global_stats_loop_function, &gsi.ret, &gsi.osl_errno);
@@ -527,7 +524,7 @@ static int print_global_lists(void)
                        return ret;
                printf("\n");
        }
-       if (gla == global_list_arg_none && !conf.no_global_summary_given) {
+       if (gla == global_list_arg_none && !select_conf.no_global_summary_given) {
                /* must compute summary */
                gsi.count = select_conf.limit_arg;
                gsi.flags = GSF_COMPUTE_SUMMARY;
@@ -552,7 +549,7 @@ static int print_statistics(void)
        return 1;
 }
 
-static int read_uid_file(void)
+static int read_uid_file(struct uid_range *admissible_uids)
 {
        size_t size;
        uint32_t n;
@@ -590,15 +587,17 @@ out:
 int com_select(void)
 {
        int ret;
-       struct select_cmdline_parser_params params = {
-               .override = 1,
-               .initialize = 1,
-               .check_required = 1,
-               .check_ambiguity = 1,
-               .print_errors = 1
-       };
+       struct uid_range *admissible_uids = NULL;
 
        if (conf.select_options_given) {
+               struct select_cmdline_parser_params params = {
+                       .override = 1,
+                       .initialize = 1,
+                       .check_required = 1,
+                       .check_ambiguity = 1,
+                       .print_errors = 1
+               };
+
                if (select_cmdline_parser_string_ext(conf.select_options_arg,
                        &select_conf, "select", &params))
                        return -E_SYNTAX;
@@ -620,7 +619,7 @@ int com_select(void)
        if (ret < 0)
                return ret;
        check_signals();
-       ret = read_uid_file();
+       ret = read_uid_file(admissible_uids);
        if (ret < 0)
                return ret;
        check_signals();