X-Git-Url: http://git.tuebingen.mpg.de/?p=adu.git;a=blobdiff_plain;f=interactive.c;h=61b4f293562bfe8077f9bcc25f528887605bb7ce;hp=7b5ca7606e07bd7bef18a4c5ce26ede623cda632;hb=560d397a66ba141f18e13557feae78ca94a25f98;hpb=df11124a676c84be661ab3dc3f255aa864fd79f7

diff --git a/interactive.c b/interactive.c
index 7b5ca76..61b4f29 100644
--- a/interactive.c
+++ b/interactive.c
@@ -1,9 +1,18 @@
+/*
+ * Copyright (C) 2008 Andre Noll <maan@tuebingen.mpg.de>
+ *
+ * Licensed under the GPL v2. For licencing details see COPYING.
+ */
+
+/** \file interactive.c \brief Commands for interactive mode. */
+
 #include <ctype.h> /* isspace() */
 
 #include "adu.h"
 #include "format.h"
 #include "user.h"
 #include "string.h"
+#include "cmdline.h"
 #include "select.cmdline.h"
 #include "select.h"
 #include "error.h"
@@ -26,13 +35,16 @@ struct interactive_command {
 static struct uid_range *admissible_uids;
 static struct format_info *fi;
 
+/** The set of supported interactive commands. */
 #define INTERACTIVE_COMMANDS \
 	INTERACTIVE_COMMAND(set, "change the current configuration") \
 	INTERACTIVE_COMMAND(reset, "reset configuration to defaults") \
 	INTERACTIVE_COMMAND(help, "show list of commands and one-line descriptions") \
-	INTERACTIVE_COMMAND(run, "start the query according to the current configuration")
+	INTERACTIVE_COMMAND(run, "start the query according to the current configuration") \
+	INTERACTIVE_COMMAND(source, "read and execute interactive commands from a file")
 
 
+/** \cond doxygen is not smart enough for this */
 #define INTERACTIVE_COMMAND(name, desc) \
 	static int icom_ ## name (char *line);
 
@@ -51,7 +63,9 @@ struct interactive_command icmds[] = {
 	INTERACTIVE_COMMANDS
 	{.name  = NULL}
 };
+/** \endcond */
 
+/** Iterate over the list of all interactive commands. */
 #define FOR_EACH_COMMAND(c) for (c = icmds; c->name; c++)
 
 static int read_input_line(char *line, size_t size)
@@ -73,6 +87,9 @@ static int icom_help(__a_unused char *line)
 	return 1;
 }
 
+/**
+ * Print the list of commands with short descriptions.
+ */
 void print_interactive_help(void)
 {
 	struct interactive_command *c;
@@ -93,7 +110,6 @@ static int icom_reset(__a_unused char *line)
 
 static int icom_set(char *line)
 {
-	int ret;
 	struct select_cmdline_parser_params params = {
 		.override = 1,
 		.initialize = 0,
@@ -110,12 +126,24 @@ static int icom_set(char *line)
 	fi = NULL;
 	free(admissible_uids);
 	admissible_uids = NULL;
-	ret = parse_select_options(line, &params, &admissible_uids, &fi);
-	if (ret >= 0)
-		return ret;
-	return icom_reset(NULL);
+	return parse_select_options(line, &params, &admissible_uids, &fi);
 }
 
+/**
+ * Wrapper for isspace.
+ * NetBSD needs this.
+ */
+/*
+ * The values should be cast to an unsigned char first, then to int.
+ * Why? Because the isdigit (as do all other is/to functions/macros)
+ * expect a number from 0 upto and including 255 as their (int) argument.
+ * Because char is signed on most systems, casting it to int immediately
+ * gives the functions an argument between -128 and 127 (inclusive),
+ * which they will use as an array index, and which will thus fail
+ * horribly for characters which have their most significant bit set.
+ */
+#define adu_isspace(c) isspace((int)(unsigned char)(c))
+
 static int exec_interactive_command(char *line)
 {
 	const char const *delim = "\t\n\f\r\v ";
@@ -128,7 +156,7 @@ static int exec_interactive_command(char *line)
 		return 1;
 	len = strlen(line);
 
-	while (len && isspace(line[len - 1])) {
+	while (len && adu_isspace(line[len - 1])) {
 		line[len - 1] = '\0';
 		len--;
 	}
@@ -164,10 +192,34 @@ static int exec_interactive_command(char *line)
 	return ret;
 }
 
+static int icom_source(char *args)
+{
+	char line[255];
+	FILE *src = fopen(args, "r");
+	int ret;
+
+	if (!src)
+		return -ERRNO_TO_ERROR(errno);
+	while (fgets(line, sizeof(line), src)) {
+		ret = exec_interactive_command(line);
+		if (ret < 0)
+			goto out;
+	}
+	ret = 1;
+out:
+	fclose(src);
+	return ret;
+}
+
+/**
+ * The main function for interactive mode.
+ *
+ * \return Standard.
+ */
 int com_interactive(void)
 {
 	char line[255];
-	int ret = 1;
+	int ret;
 
 	select_cmdline_parser_init(&select_conf);
 	ret = parse_select_options(NULL, NULL, &admissible_uids, &fi);
@@ -180,6 +232,7 @@ int com_interactive(void)
 		ret = exec_interactive_command(line);
 		if (ret < 0)
 			printf("%s\n", adu_strerror(-ret));
+		fflush(NULL);
 	}
 	return ret;
 }