From d880112b1483b45f1e7db632cb09bbe05fb2df86 Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Thu, 20 Dec 2012 14:38:41 +0100 Subject: [PATCH] rsync: Remove hardcoded --quiet option. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When running in daemon mode, the stdout and stderr stream of dss and all its child processes are redirected to /dev/null. In particular any output from the rsync process is discarded. Therefore, whenever a new snapshot is created, dss currently passes --quiet to the underlying rsync command, along with --archive and --delete. However, as was pointed out by Sebastian Schultheiß, if the rsync command fails for unknown reasons, the --quiet option complicates debugging for the questionable benefit of saving the I/O for a few writes to /dev/null. This patch removes the --quiet option. --- dss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dss.c b/dss.c index 11c1d06..813d73d 100644 --- a/dss.c +++ b/dss.c @@ -1148,7 +1148,7 @@ static void create_rsync_argv(char ***argv, int64_t *num) *argv = dss_malloc((15 + conf.rsync_option_given) * sizeof(char *)); (*argv)[i++] = dss_strdup("rsync"); - (*argv)[i++] = dss_strdup("-aq"); + (*argv)[i++] = dss_strdup("-a"); (*argv)[i++] = dss_strdup("--delete"); for (j = 0; j < conf.rsync_option_given; j++) (*argv)[i++] = dss_strdup(conf.rsync_option_arg[j]); -- 2.39.2