From 1cb173045c9bbc707407021860a74a2dbc01af65 Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Sat, 3 Jan 2015 17:03:27 +0000 Subject: [PATCH 1/1] osl.c: Fix assertion in create_table_index(). Classic "=" vs. "==" bug. Since offset is positive, and not used any more after the assert statement, the line has always been a no-op. Found by cppcheck. --- osl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osl.c b/osl.c index 0a2863d..4569b1b 100644 --- a/osl.c +++ b/osl.c @@ -516,7 +516,7 @@ static int create_table_index(struct osl_table *t) strcpy(buf + offset + IDX_CD_NAME, cd->name); offset += index_column_description_size(cd->name); } - assert(offset = size); + assert(offset == size); filename = index_filename(t->desc); if (filename) ret = write_file(filename, buf, size); -- 2.39.2