Complete the afs callback conversion.
[paraslash.git] / afs.c
diff --git a/afs.c b/afs.c
index 05c2c21367e93f851cf4ac6d89deece65ac23d06..2260344e873ac67ef730d75b21173776b2ec70ee 100644 (file)
--- a/afs.c
+++ b/afs.c
@@ -157,11 +157,11 @@ struct callback_result {
  * \sa send_option_arg_callback_request(), send_standard_callback_request().
  */
 int send_callback_request(callback_function *f, struct osl_object *query,
-               struct osl_object *result)
+               callback_result_handler *result_handler,
+               void *private_result_data)
 {
        struct callback_query *cq;
-       struct callback_result *cr;
-       int ret, fd = -1, query_shmid, result_shmid;
+       int num_results = 0, ret, fd = -1, query_shmid, result_shmid;
        void *query_shm, *result_shm;
        char buf[sizeof(afs_socket_cookie) + sizeof(int)];
        size_t query_shm_size = sizeof(*cq);
@@ -195,37 +195,45 @@ int send_callback_request(callback_function *f, struct osl_object *query,
        ret = send_bin_buffer(fd, buf, sizeof(buf));
        if (ret < 0)
                goto out;
-       ret = recv_bin_buffer(fd, buf, sizeof(buf));
-       if (ret < 0)
-               goto out;
-       if (ret != sizeof(int)) {
-               ret = -E_AFS_SHORT_READ;
-               goto out;
-       }
-       ret = *(int *) buf;
-       if (ret <= 0)
-               goto out;
-       result_shmid = ret;
-       ret = shm_attach(result_shmid, ATTACH_RO, &result_shm);
-       if (ret >= 0) {
-               assert(result);
-               cr = result_shm;
-               result->size = cr->result_size;
-               result->data = para_malloc(result->size);
-               memcpy(result->data, result_shm + sizeof(*cr), result->size);
-               ret = shm_detach(result_shm);
+       for (;;) {
+               ret = recv_bin_buffer(fd, buf, sizeof(int));
+               if (ret <= 0)
+                       goto out;
+               if (ret != sizeof(int)) {
+                       ret = -E_AFS_SHORT_READ;
+                       goto out;
+               }
+               ret = *(int *) buf;
+               if (ret <= 0)
+                       goto out;
+               result_shmid = ret;
+               ret = shm_attach(result_shmid, ATTACH_RO, &result_shm);
+               if (ret >= 0) {
+                       struct callback_result *cr = result_shm;
+                       struct osl_object result;
+                       num_results++;
+                       result.size = cr->result_size;
+                       result.data = result_shm + sizeof(*cr);
+                       if (result.size) {
+                               assert(result_handler);
+                               ret = result_handler(&result, private_result_data);
+                               if (shm_detach(result_shm) < 0)
+                                       PARA_ERROR_LOG("can not detach result\n");
+                       }
+               } else
+                       PARA_ERROR_LOG("attach result failed: %d\n", ret);
+               if (shm_destroy(result_shmid) < 0)
+                       PARA_ERROR_LOG("destroy result failed\n");
                if (ret < 0)
-                       PARA_ERROR_LOG("can not detach result\n");
-       } else
-               PARA_ERROR_LOG("attach result failed: %d\n", ret);
-       if (shm_destroy(result_shmid) < 0)
-               PARA_ERROR_LOG("destroy result failed\n");
-       ret = 1;
+                       break;
+       }
 out:
        if (shm_destroy(query_shmid) < 0)
                PARA_ERROR_LOG("%s\n", "shm destroy error");
        if (fd >= 0)
                close(fd);
+       if (ret >= 0)
+               ret = num_results;
 //     PARA_DEBUG_LOG("callback_ret: %d\n", ret);
        return ret;
 }
@@ -248,7 +256,8 @@ out:
  */
 int send_option_arg_callback_request(struct osl_object *options,
                int argc,  char * const * const argv, callback_function *f,
-               struct osl_object *result)
+               callback_result_handler *result_handler,
+               void *private_result_data)
 {
        char *p;
        int i, ret;
@@ -266,7 +275,8 @@ int send_option_arg_callback_request(struct osl_object *options,
                strcpy(p, argv[i]); /* OK */
                p += strlen(argv[i]) + 1;
        }
-       ret = send_callback_request(f, &query, result);
+       ret = send_callback_request(f, &query, result_handler,
+               private_result_data);
        free(query.data);
        return ret;
 }
@@ -286,9 +296,11 @@ int send_option_arg_callback_request(struct osl_object *options,
  * send_option_arg_callback_request().
  */
 int send_standard_callback_request(int argc,  char * const * const argv,
-               callback_function *f, struct osl_object *result)
+               callback_function *f, callback_result_handler *result_handler,
+               void *private_result_data)
 {
-       return send_option_arg_callback_request(NULL, argc, argv, f, result);
+       return send_option_arg_callback_request(NULL, argc, argv, f, result_handler,
+               private_result_data);
 }
 
 static int action_if_pattern_matches(struct osl_row *row, void *data)
@@ -407,7 +419,8 @@ static int fd2buf(int fd, unsigned max_size, struct osl_object *obj)
  * send_callback_request() otherwise.
  */
 int stdin_command(int fd, struct osl_object *arg_obj, callback_function *f,
-               unsigned max_len, struct osl_object *result)
+               unsigned max_len, callback_result_handler *result_handler,
+               void *private_result_data)
 {
        struct osl_object query, stdin_obj;
        int ret;
@@ -423,7 +436,7 @@ int stdin_command(int fd, struct osl_object *arg_obj, callback_function *f,
        memcpy(query.data, arg_obj->data, arg_obj->size);
        memcpy((char *)query.data + arg_obj->size, stdin_obj.data, stdin_obj.size);
        free(stdin_obj.data);
-       ret = send_callback_request(f, &query, result);
+       ret = send_callback_request(f, &query, result_handler, private_result_data);
        free(query.data);
        return ret;
 }
@@ -560,54 +573,63 @@ static int activate_mood_or_playlist(char *arg, int *num_admissible)
        return 1;
 }
 
-static int com_select_callback(const struct osl_object *query,
-               struct osl_object *result)
+static void com_select_callback(int fd, const struct osl_object *query)
 {
-       struct para_buffer pb = {.buf = NULL};
+       struct para_buffer pb = {
+               .max_size = SHMMAX,
+               .private_data = &fd,
+               .max_size_handler = pass_buffer_as_shm
+       };
        char *arg = query->data;
-       int num_admissible, ret;
+       int num_admissible, ret, ret2;
 
        ret = clear_score_table();
-       if (ret < 0)
-               return ret;
+       if (ret < 0) {
+               ret2 = para_printf(&pb, "%s\n", para_strerror(-ret));
+               goto out;
+       }
        if (current_play_mode == PLAY_MODE_MOOD)
                close_current_mood();
        else
                playlist_close();
        ret = activate_mood_or_playlist(arg, &num_admissible);
        if (ret < 0) {
-               para_printf(&pb, "%s\n", para_strerror(-ret));
-               para_printf(&pb, "switching back to %s\n", current_mop?
+               ret2 = para_printf(&pb, "%s\nswitching back to %s\n",
+                       para_strerror(-ret), current_mop?
                        current_mop : "dummy");
                ret = activate_mood_or_playlist(current_mop, &num_admissible);
                if (ret < 0) {
-                       para_printf(&pb, "failed, switching to dummy\n");
+                       if (ret2 >= 0)
+                               ret2 = para_printf(&pb, "failed, switching to dummy\n");
                        activate_mood_or_playlist(NULL, &num_admissible);
                }
-       }
-       para_printf(&pb, "activated %s (%d admissible files)\n", current_mop?
-               current_mop : "dummy mood", num_admissible);
-       result->data = pb.buf;
-       result->size = pb.size;
-       return 1;
+       } else
+               ret2 = para_printf(&pb, "activated %s (%d admissible files)\n", current_mop?
+                       current_mop : "dummy mood", num_admissible);
+out:
+       if (ret2 >= 0 && pb.offset)
+               pass_buffer_as_shm(pb.buf, pb.offset, &fd);
+       free(pb.buf);
+}
+
+int send_result(struct osl_object *result, void *private_result_data)
+{
+       int fd = *(int *)private_result_data;
+       if (!result->size)
+               return 1;
+       return send_bin_buffer(fd, result->data, result->size);
 }
 
 int com_select(int fd, int argc, char * const * const argv)
 {
-       int ret;
-       struct osl_object query, result;
+       struct osl_object query;
 
        if (argc != 2)
                return -E_AFS_SYNTAX;
        query.data = argv[1];
        query.size = strlen(argv[1]) + 1;
-       ret = send_callback_request(com_select_callback, &query,
-               &result);
-       if (ret > 0 && result.data && result.size) {
-               ret = send_va_buffer(fd, "%s", (char *)result.data);
-               free(result.data);
-       }
-       return ret;
+       return send_callback_request(com_select_callback, &query,
+               &send_result, &fd);
 }
 
 static void init_admissible_files(char *arg)
@@ -783,6 +805,36 @@ static void command_pre_select(struct sched *s, struct task *t)
        t->ret = 1;
 }
 
+int pass_buffer_as_shm(char *buf, size_t size, void *private_data)
+{
+       int ret, shmid, fd = *(int *)private_data;
+       void *shm;
+       struct callback_result *cr;
+
+       if (!buf || !size)
+               return 0;
+       ret = shm_new(size + sizeof(struct callback_result));
+       if (ret < 0)
+               return ret;
+       shmid = ret;
+       ret = shm_attach(shmid, ATTACH_RW, &shm);
+       if (ret < 0)
+               goto err;
+       cr = shm;
+       cr->result_size = size;
+       memcpy(shm + sizeof(*cr), buf, size);
+       ret = shm_detach(shm);
+       if (ret < 0)
+               goto err;
+       ret = send_bin_buffer(fd, (char *)&shmid, sizeof(int));
+       if (ret >= 0)
+               return ret;
+err:
+       if (shm_destroy(shmid) < 0)
+               PARA_ERROR_LOG("destroy result failed\n");
+       return ret;
+}
+
 /*
  * On errors, negative value is written to fd.
  * On success: If query produced a result, the result_shmid is written to fd.
@@ -790,52 +842,19 @@ static void command_pre_select(struct sched *s, struct task *t)
  */
 static int call_callback(int fd, int query_shmid)
 {
-       void *query_shm, *result_shm;
+       void *query_shm;
        struct callback_query *cq;
-       struct callback_result *cr;
-       struct osl_object query, result = {.data = NULL};
-       int result_shmid = -1, ret, ret2;
+       struct osl_object query;
+       int ret;
 
        ret = shm_attach(query_shmid, ATTACH_RW, &query_shm);
        if (ret < 0)
-               goto out;
+               return ret;
        cq = query_shm;
        query.data = (char *)query_shm + sizeof(*cq);
        query.size = cq->query_size;
-       ret = cq->handler(&query, &result);
-       ret2 = shm_detach(query_shm);
-       if (ret2 < 0 && ret >= 0)
-               ret = ret2;
-       if (ret < 0)
-               goto out;
-       ret = 0;
-       if (!result.data || !result.size)
-               goto out;
-       ret = shm_new(result.size + sizeof(struct callback_result));
-       if (ret < 0)
-               goto out;
-       result_shmid = ret;
-       ret = shm_attach(result_shmid, ATTACH_RW, &result_shm);
-       if (ret < 0)
-               goto out;
-       cr = result_shm;
-       cr->result_size = result.size;
-       memcpy(result_shm + sizeof(*cr), result.data, result.size);
-       ret = shm_detach(result_shm);
-       if (ret < 0)
-               goto out;
-       ret = result_shmid;
-out:
-       free(result.data);
-       ret2 = send_bin_buffer(fd, (char *)&ret, sizeof(int));
-       if (ret < 0 || ret2 < 0) {
-               if (result_shmid >= 0)
-                       if (shm_destroy(result_shmid) < 0)
-                               PARA_ERROR_LOG("destroy result failed\n");
-               if (ret >= 0)
-                       ret = ret2;
-       }
-       return ret;
+       cq->handler(fd, &query);
+       return 1;
 }
 
 static void execute_server_command(void)
@@ -869,10 +888,8 @@ static void execute_afs_command(int fd, uint32_t expected_cookie)
        char buf[sizeof(cookie) + sizeof(query_shmid)];
        int ret = recv_bin_buffer(fd, buf, sizeof(buf));
 
-       if (ret < 0) {
-               PARA_NOTICE_LOG("%s\n", para_strerror(-ret));
-               return;
-       }
+       if (ret < 0)
+               goto err;
        if (ret != sizeof(buf)) {
                PARA_NOTICE_LOG("short read (%d bytes, expected %lu)\n",
                        ret, (long unsigned) sizeof(buf));
@@ -890,8 +907,11 @@ static void execute_afs_command(int fd, uint32_t expected_cookie)
                        query_shmid);
                return;
        }
-       /* Ignore return value: Errors might be OK here. */
-       call_callback(fd, query_shmid);
+       ret = call_callback(fd, query_shmid);
+       if (ret >= 0)
+               return;
+err:
+       PARA_NOTICE_LOG("%s\n", para_strerror(-ret));
 }
 
 /** Shutdown connection if query has not arrived until this many seconds. */
@@ -1000,11 +1020,11 @@ __noreturn void afs_init(uint32_t cookie, int socket_fd)
        exit(EXIT_FAILURE);
 }
 
-static int create_tables_callback(const struct osl_object *query,
-               __a_unused struct osl_object *result)
+static void create_tables_callback(int fd, const struct osl_object *query)
 {
        uint32_t table_mask = *(uint32_t *)query->data;
        int i, ret;
+       char *buf;
 
        close_afs_tables();
        for (i = 0; i < NUM_AFS_TABLES; i++) {
@@ -1016,10 +1036,16 @@ static int create_tables_callback(const struct osl_object *query,
                        continue;
                ret = t->create(database_dir);
                if (ret < 0)
-                       return ret;
+                       goto out;
        }
        ret = open_afs_tables();
-       return ret < 0? ret: 0;
+out:
+       if (ret >= 0)
+               buf = make_message("successfully created afs table(s)\n");
+       else
+               buf = make_message("%s\n", para_strerror(-ret));
+       pass_buffer_as_shm(buf, strlen(buf), &fd);
+       free(buf);
 }
 
 int com_init(int fd, int argc, char * const * const argv)
@@ -1047,10 +1073,10 @@ int com_init(int fd, int argc, char * const * const argv)
                                return -E_BAD_TABLE_NAME;
                }
        }
-       ret = send_callback_request(create_tables_callback, &query, NULL);
+       ret = send_callback_request(create_tables_callback, &query, NULL, NULL);
        if (ret < 0)
-               return ret;
-       return send_va_buffer(fd, "successfully created afs table(s)\n");
+               return send_va_buffer(fd, "%s\n", para_strerror(-ret));
+       return ret;
 }
 
 /**
@@ -1071,7 +1097,6 @@ int com_check(int fd, int argc, char * const * const argv)
 {
        unsigned flags = 0;
        int i, ret;
-       struct osl_object result;
 
        for (i = 1; i < argc; i++) {
                const char *arg = argv[i];
@@ -1100,37 +1125,19 @@ int com_check(int fd, int argc, char * const * const argv)
        if (!flags)
                flags = ~0U;
        if (flags & CHECK_AFT) {
-               ret = send_callback_request(aft_check_callback, NULL, &result);
+               ret = send_callback_request(aft_check_callback, NULL, send_result, &fd);
                if (ret < 0)
                        return ret;
-               if (ret > 0) {
-                       ret = send_buffer(fd, (char *) result.data);
-                       free(result.data);
-                       if (ret < 0)
-                               return ret;
-               }
        }
        if (flags & CHECK_PLAYLISTS) {
-               ret = send_callback_request(playlist_check_callback, NULL, &result);
+               ret = send_callback_request(playlist_check_callback, NULL, send_result, &fd);
                if (ret < 0)
                        return ret;
-               if (ret > 0) {
-                       ret = send_buffer(fd, (char *) result.data);
-                       free(result.data);
-                       if (ret < 0)
-                               return ret;
-               }
        }
        if (flags & CHECK_MOODS) {
-               ret = send_callback_request(mood_check_callback, NULL, &result);
+               ret = send_callback_request(mood_check_callback, NULL, send_result, &fd);
                if (ret < 0)
                        return ret;
-               if (ret > 0) {
-                       ret = send_buffer(fd, (char *) result.data);
-                       free(result.data);
-                       if (ret < 0)
-                               return ret;
-               }
        }
        return 1;
 }