fade.c: simplify open_mixer()

[paraslash.git] / audioc.c

diff --git a/audioc.c b/audioc.c
index 216afa2f11aeebc132d23ad2a96664daf9e384cd..551c34e63b80d86c05be4103a02c9209c5fd0051 100644 (file)
--- a/audioc.c
+++ b/audioc.c
@@ -27,12 +27,12 @@
 
 INIT_AUDIOC_ERRLISTS;
 
+/** the gengetopt structure containing command line args */
 struct audioc_args_info conf;
-char *tmpfifo;
 
 INIT_STDERR_LOGGING(conf.loglevel_arg);
 
-static char *concat_args(const int argc, char * const *argv)
+static char *concat_args(unsigned argc, char * const *argv)
 {
        int i; char *buf = NULL;
        for (i = 0; i < argc; i++) {
@@ -59,13 +59,28 @@ static char *configfile_exists(void)
        return NULL;
 }
 
+/**
+ * the client program to connect to para_audiod
+ *
+ * \param argc usual argument count
+ * \param argv usual argument vector
+ *
+ * It creates a temporary local socket in order to communicate with para_audiod.
+ * Authentication consists in sending a ucred buffer that contains the user id.
+ *
+ * Any output received through the local socket is sent to stdout.
+ *
+ * \return EXIT_SUCCESS or EXIT_FAILURE
+ *
+ * \sa send_cred_buffer(), para_audioc(1), para_audiod(1).
+ */
 int main(int argc, char *argv[])
 {
        struct sockaddr_un unix_addr;
-       int ret = -E_AUDIOC_SYNTAX, fd, loaded = 0;
+       int ret = -E_AUDIOC_SYNTAX, fd;
        char *cf, *socket_name, *randname = para_tmpname(), *tmpsocket_name = NULL,
                *buf = NULL, *hn = para_hostname(), *args, *home = para_homedir();
-
+       size_t bufsize = conf.bufsize_arg, loaded = 0;
 
        if (audioc_cmdline_parser(argc, argv, &conf))
                goto out;
@@ -80,7 +95,7 @@ int main(int argc, char *argv[])
        args = conf.inputs_num?
                concat_args(conf.inputs_num, conf.inputs) :
                para_strdup("stat");
-       buf = para_malloc(conf.bufsize_arg);
+       buf = para_malloc(bufsize);
        if (conf.socket_given)
                socket_name = para_strdup(conf.socket_arg);
        else
@@ -113,7 +128,7 @@ int main(int argc, char *argv[])
                fd_set rfd, wfd;
                FD_ZERO(&rfd);
                FD_ZERO(&wfd);
-               if (loaded < conf.bufsize_arg)
+               if (loaded < bufsize)
                        para_fd_set(fd, &rfd, &max_fileno);
                if (loaded > 0) {
                        para_fd_set(STDOUT_FILENO, &wfd, &max_fileno);
@@ -125,9 +140,9 @@ int main(int argc, char *argv[])
                ret = para_select(max_fileno + 1, &rfd, &wfd, NULL);
                if (ret < 0)
                        goto out;
-               if (loaded < conf.bufsize_arg && FD_ISSET(fd, &rfd)) {
+               if (loaded < bufsize && FD_ISSET(fd, &rfd)) {
                        len = recv_bin_buffer(fd, buf + loaded,
-                               conf.bufsize_arg - loaded);
+                               bufsize - loaded);
                        if (len <= 0) {
                                ret = len < 0? -E_AUDIOC_READ : 0;
                                goto out;