Fix various dead stores found by the clang static analyzer.

[paraslash.git] / mood.c

diff --git a/mood.c b/mood.c
index 57f3f00ab5b4e11ee4f9d78bb82f683eed361092..540d0c70bc7d20b0951e0dffa5deb10c7394104c 100644 (file)
--- a/mood.c
+++ b/mood.c
@@ -537,10 +537,10 @@ static int check_mood(struct osl_row *mood_row, void *data)
        struct osl_object mood_def;
        struct mood_line_parser_data mlpd = {.line_num = 0};
 
        struct osl_object mood_def;
        struct mood_line_parser_data mlpd = {.line_num = 0};
 

-       int ret2, ret = mood_get_name_and_def_by_row(mood_row, &mood_name, &mood_def);
+       int ret = mood_get_name_and_def_by_row(mood_row, &mood_name, &mood_def);

 
        if (ret < 0) {
 
        if (ret < 0) {

-               ret2 = para_printf(pb, "failed to get mood definition: %s\n",
+               para_printf(pb, "failed to get mood definition: %s\n",

                        para_strerror(-ret));
                return ret;
        }
                        para_strerror(-ret));
                return ret;
        }


@@ -552,7 +552,7 @@ static int check_mood(struct osl_row *mood_row, void *data)
        ret = for_each_line_ro(mood_def.data, mood_def.size,
                parse_mood_line, &mlpd);
        if (ret < 0)
        ret = for_each_line_ro(mood_def.data, mood_def.size,
                parse_mood_line, &mlpd);
        if (ret < 0)

-               ret2 = para_printf(pb, "%s line %u: %s\n", mood_name, mlpd.line_num,
+               para_printf(pb, "%s line %u: %s\n", mood_name, mlpd.line_num,

                        para_strerror(-ret));
 out:
        osl_close_disk_object(&mood_def);
                        para_strerror(-ret));
 out:
        osl_close_disk_object(&mood_def);