X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=aacdec.c;h=89781c528d9f107a65d75cf120cd9eb412c47271;hp=c36f6877c901c2a6e9bf9fdc41284147c627045d;hb=5430c77f1fdf97d92796f44623d257b8124bde24;hpb=2349dbb8c69a97f271c8cb8440016ac5afc34dab

diff --git a/aacdec.c b/aacdec.c
index c36f6877..89781c52 100644
--- a/aacdec.c
+++ b/aacdec.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2007 Andre Noll <maan@systemlinux.org>
  *
  *     This program is free software; you can redistribute it and/or modify
  *     it under the terms of the GNU General Public License as published by
@@ -25,14 +25,17 @@
 #include "para.h"
 
 #include "list.h"
+#include "sched.h"
 #include "filter.h"
 #include "error.h"
 #include "string.h"
 #include "aac.h"
 
-#define MAX_CHANNELS 6
 /** the output buffer size */
-#define AAC_OUTBUF_SIZE (FAAD_MIN_STREAMSIZE * MAX_CHANNELS)
+#define AAC_OUTBUF_SIZE (32 * 1024)
+
+/** give up decoding after that many errors */
+#define MAX_ERRORS 20
 
 /**
  * data specific to the aacdec filter
@@ -40,27 +43,37 @@
  * \sa filter, filter_node
  */
 struct private_aacdec_data {
+	/** the return value of aac_open */
 	NeAACDecHandle handle;
+	/** info about the currently decoded frame */
 	NeAACDecFrameInfo frame_info;
-
+	/** whether this instance of the aac decoder is already initialized */
 	int initialized;
+	/**
+	 * return value of aac_find_esds(). Used to call the right aacdec
+	 * init function
+	 */
 	int decoder_length;
+	/** number of times the decoder returned an error */
+	unsigned error_count;
+	/** number of bytes already consumed from the imput stream */
 	size_t consumed_total;
+	/** return value of aac_find_entry_point */
 	size_t entry;
 };
 
 static ssize_t aacdec(char *input_buffer, size_t len, struct filter_node *fn)
 {
 	struct private_aacdec_data *padd = fn->private_data;
-	struct filter_chain_info *fci = fn->fci;
+	struct filter_chain *fc = fn->fc;
 	int i, ret;
 	unsigned char *p, *outbuffer;
 	unsigned char *inbuf = (unsigned char*)input_buffer;
 	size_t skip, consumed = 0;
 
-	if (fn->loaded > fn->bufsize * 4 / 5)
+	if (fn->loaded > fn->bufsize * 3 / 5)
 		return 0;
-	if (len < 1000 && !*fci->eof)
+	if (len < 2048 && !*fc->input_eof)
 		return 0;
 
 	if (!padd->initialized) {
@@ -86,10 +99,10 @@ static ssize_t aacdec(char *input_buffer, size_t len, struct filter_node *fn)
 					&channels) < 0)
 				goto out;
 		}
-		fci->samplerate = rate;
-		fci->channels = channels;
+		fc->samplerate = rate;
+		fc->channels = channels;
 		PARA_INFO_LOG("rate: %u, channels: %d\n",
-			fci->samplerate, fci->channels);
+			fc->samplerate, fc->channels);
 		padd->initialized = 1;
 	}
 	if (padd->decoder_length > 0) {
@@ -111,7 +124,7 @@ static ssize_t aacdec(char *input_buffer, size_t len, struct filter_node *fn)
 		if (padd->consumed_total < padd->entry)
 			consumed = padd->entry - padd->consumed_total;
 	}
-	for (; consumed < len;consumed++)
+	for (; consumed < len; consumed++)
 		if ((inbuf[consumed] & 0xfe) == 0x20)
 			break;
 	if (consumed >= len)
@@ -119,8 +132,10 @@ static ssize_t aacdec(char *input_buffer, size_t len, struct filter_node *fn)
 	p = inbuf + consumed;
 	outbuffer = NeAACDecDecode(padd->handle, &padd->frame_info, p,
 		len - consumed);
-	ret = -E_AAC_DECODE;
-	if (padd->frame_info.error != 0) {
+	if (padd->frame_info.error) {
+		ret = -E_AAC_DECODE;
+		if (padd->error_count++ > MAX_ERRORS)
+			goto out;
 		PARA_ERROR_LOG("frame_error: %d, consumed: %zu + %zd + %lu\n",
 			padd->frame_info.error, padd->consumed_total,
 			consumed, padd->frame_info.bytesconsumed);
@@ -129,14 +144,18 @@ static ssize_t aacdec(char *input_buffer, size_t len, struct filter_node *fn)
 		consumed++; /* catch 21 */
 		goto success;
 	}
+	padd->error_count = 0;
 	consumed += padd->frame_info.bytesconsumed;
 	ret = consumed;
 	if (!padd->frame_info.samples)
 		goto out;
+	ret = -E_AAC_OVERRUN;
+	if (padd->frame_info.samples * 2 + fn->loaded > fn->bufsize)
+		goto out;
 	for (i = 0; i < padd->frame_info.samples; i++) {
 		short *s = (short *)outbuffer;
-		fn->buf[fn->loaded++] = s[i] & 0xff;
-		fn->buf[fn->loaded++] = (s[i] >> 8) & 0xff;
+		write_int16_host_endian(fn->buf + fn->loaded, s[i]);
+		fn->loaded += 2;
 	}
 success:
 	ret = consumed;
@@ -170,6 +189,8 @@ static void aacdec_close(struct filter_node *fn)
 /**
  * the init function of the aacdec filter
  *
+ * \param f pointer to the filter struct to initialize
+ *
  * \sa filter::init
  */
 void aacdec_init(struct filter *f)