X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=acl.c;h=087ea0c805c102bace697596061978b64aa22f72;hp=14edcf7d87c08617e175e0fff44e3c572e305160;hb=c9c96581d5a29830f555079e861dcac8d48722d5;hpb=5d67c3dcd623fb61ca6ec4b427eeeb51daeca71e

diff --git a/acl.c b/acl.c
index 14edcf7d..087ea0c8 100644
--- a/acl.c
+++ b/acl.c
@@ -6,6 +6,8 @@
 
 /** \file acl.c Access control lists for paraslash senders. */
 
+#include <regex.h>
+
 #include "para.h"
 #include "error.h"
 #include "string.h"
@@ -90,13 +92,17 @@ static void acl_add_entry(struct list_head *acl, char *addr, int netmask)
  * \param addr The address to delete.
  * \param netmask The netmask of the entry to be removed from the list.
  */
-static void acl_del_entry(struct list_head *acl, char *addr, int netmask)
+static void acl_del_entry(struct list_head *acl, char *addr, unsigned netmask)
 {
 	struct access_info *ai, *tmp;
+	struct in_addr to_delete;
+
+	inet_pton(AF_INET, addr, &to_delete);
 
 	list_for_each_entry_safe(ai, tmp, acl, node) {
-		if (!strcmp(addr, inet_ntoa(ai->addr)) &&
-				ai->netmask == netmask) {
+
+		if (v4_addr_match(to_delete.s_addr, ai->addr.s_addr,
+					PARA_MIN(netmask, ai->netmask))) {
 			PARA_NOTICE_LOG("removing %s/%i from access list\n",
 					addr, ai->netmask);
 			list_del(&ai->node);
@@ -136,30 +142,16 @@ char *acl_get_contents(struct list_head *acl)
  */
 void acl_init(struct list_head *acl, char * const *acl_info, int num)
 {
-	int i;
+	char	addr[16];
+	int	mask, i;
 
 	INIT_LIST_HEAD(acl);
-	for (i = 0; i < num; i++) {
-		char *arg = para_strdup(acl_info[i]);
-		char *p = strchr(arg, '/');
-		int netmask;
-
-		if (!p)
-			goto err;
-		*p = '\0';
-		if (!is_valid_ipv4_address(arg))
-			goto err;
-		netmask = atoi(++p);
-		if (netmask < 0 || netmask > 32)
-			goto err;
-		acl_add_entry(acl, arg, netmask);
-		goto success;
-err:
-		PARA_CRIT_LOG("syntax error: %s\n", acl_info[i]);
-success:
-		free(arg);
-		continue;
-	}
+	for (i = 0; i < num; i++)
+		if (parse_cidr(acl_info[i], addr, sizeof(addr), &mask) == NULL)
+			PARA_CRIT_LOG("ACL syntax error: %s, ignoring\n",
+				      acl_info[i]);
+		else
+			acl_add_entry(acl, addr, mask);
 }
 
 /**