X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=afh.c;h=c82d17fd19acc5c1484d883b4021a59d4718c599;hp=86f34ace67e0efcba11fb9ddfe1a2f23ca2416b7;hb=6442f07bb08eb6e557086587f997b1785ea18ef7;hpb=97727c2e95cce064e03f495e97119cae447397d7

diff --git a/afh.c b/afh.c
index 86f34ace..c82d17fd 100644
--- a/afh.c
+++ b/afh.c
@@ -60,22 +60,30 @@ static int cat_file(void *audio_file_data, struct afh_info *afhi)
 	int ret;
 	struct timeval stream_start;
 	long unsigned i, first_chunk, last_chunk;
-	char *buf;
+	const char *buf;
 	size_t size;
 
 
-	if (conf.begin_chunk_arg < 0)
-		return -ERRNO_TO_PARA_ERROR(EINVAL);
-	first_chunk = conf.begin_chunk_arg;
-
-	if (conf.end_chunk_given) {
-		if (conf.end_chunk_arg < 0)
+	if (conf.begin_chunk_arg < 0) {
+		if (-conf.begin_chunk_arg > afhi->chunks_total)
 			return -ERRNO_TO_PARA_ERROR(EINVAL);
-		if (conf.end_chunk_arg >= afhi->chunks_total)
-			return -ERRNO_TO_PARA_ERROR(EINVAL);
-		last_chunk = conf.end_chunk_arg;
+		first_chunk = afhi->chunks_total + conf.begin_chunk_arg;
+	} else
+		first_chunk = conf.begin_chunk_arg;
+	if (conf.end_chunk_given) {
+		if (conf.end_chunk_arg < 0) {
+			if (-conf.end_chunk_arg > afhi->chunks_total)
+				return -ERRNO_TO_PARA_ERROR(EINVAL);
+			last_chunk = afhi->chunks_total + conf.end_chunk_arg;
+		} else {
+			if (conf.end_chunk_arg >= afhi->chunks_total)
+				return -ERRNO_TO_PARA_ERROR(EINVAL);
+			last_chunk = conf.end_chunk_arg;
+		}
 	} else
 		last_chunk = afhi->chunks_total - 1;
+	if (first_chunk >= last_chunk)
+		return -ERRNO_TO_PARA_ERROR(EINVAL);
 	if (!afhi->chunks_total)
 		return 1;
 	afh_get_header(afhi, audio_file_data, &buf, &size);
@@ -104,6 +112,8 @@ static int cat_file(void *audio_file_data, struct afh_info *afhi)
 					return ret;
 			}
 		}
+		if (!size)
+			continue;
 		PARA_INFO_LOG("writing chunk %lu\n", i);
 		ret = write_all(STDOUT_FILENO, buf, &size);
 		if (ret < 0)
@@ -112,9 +122,17 @@ static int cat_file(void *audio_file_data, struct afh_info *afhi)
 	return 1;
 }
 
+/**
+ * The main function of para_afh.
+ *
+ * \param argc Usual argument count.
+ * \param argv Usual argument vector.
+ *
+ * \return \p EXIT_FAILURE or \p EXIT_SUCCESS.
+ */
 int main(int argc, char **argv)
 {
-	int ret, audio_format_num;
+	int ret, audio_format_num, fd;
 	void *audio_file_data;
 	size_t audio_file_size;
 	struct afh_info afhi;
@@ -126,10 +144,11 @@ int main(int argc, char **argv)
 		goto out;
 	afh_init();
 	ret = mmap_full_file(conf.inputs[0], O_RDONLY, &audio_file_data,
-		&audio_file_size, NULL);
+		&audio_file_size, &fd);
 	if (ret < 0)
 		goto out;
-	ret = compute_afhi(conf.inputs[0], audio_file_data, audio_file_size, &afhi);
+	ret = compute_afhi(conf.inputs[0], audio_file_data, audio_file_size,
+		fd, &afhi);
 	if (ret < 0)
 		goto out;
 	audio_format_num = ret;