X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=afs.c;h=263f1818a2763522fd04bacbc153ccdaffce1f35;hp=3f3780519ab0ddddcba6ff876ead15324b9951ec;hb=e83cbfdcc9f5671cab0b1dae5cb81b956d0ab5ce;hpb=fddf60223e26c1dc1e02b432652c4ca6a237c278

diff --git a/afs.c b/afs.c
index 3f378051..263f1818 100644
--- a/afs.c
+++ b/afs.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2007-2011 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2007-2012 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -192,7 +192,7 @@ static int dispatch_result(int result_shmid, callback_result_handler *handler,
  * shmid are passed to that function as an osl object. The private_result_data
  * pointer is passed as the second argument to \a result_handler.
  *
- * \return Standard.
+ * \return Number of shared memory areas dispatched on success, negative on errors.
  *
  * \sa send_option_arg_callback_request(), send_standard_callback_request().
  */
@@ -205,7 +205,7 @@ int send_callback_request(callback_function *f, struct osl_object *query,
 	void *query_shm;
 	char buf[sizeof(afs_socket_cookie) + sizeof(int)];
 	size_t query_shm_size = sizeof(*cq);
-	int dispatch_error = 0;
+	int dispatch_error = 0, num_dispatched = 0;
 
 	if (query)
 		query_shm_size += query->size;
@@ -261,6 +261,7 @@ int send_callback_request(callback_function *f, struct osl_object *query,
 		if (ret < 0)
 			PARA_CRIT_LOG("destroy result failed: %s\n",
 				para_strerror(-ret));
+		num_dispatched++;
 	}
 out:
 	if (shm_destroy(query_shmid) < 0)
@@ -268,7 +269,7 @@ out:
 	if (fd >= 0)
 		close(fd);
 //	PARA_DEBUG_LOG("callback_ret: %d\n", ret);
-	return ret;
+	return ret < 0? ret : num_dispatched;
 }
 
 /**
@@ -363,7 +364,10 @@ static int action_if_pattern_matches(struct osl_row *row, void *data)
 			continue;
 		if (ret)
 			return -E_FNMATCH;
-		return pmd->action(pmd->table, row, name, pmd->data);
+		ret = pmd->action(pmd->table, row, name, pmd->data);
+		if (ret >= 0)
+			pmd->num_matches++;
+		return ret;
 	}
 	return 1;
 }
@@ -727,11 +731,11 @@ static void afs_signal_post_select(struct sched *s, struct task *t)
 	}
 	PARA_EMERG_LOG("terminating on signal %d\n", signum);
 shutdown:
-	sched_shutdown();
+	sched_shutdown(s);
 	t->error = -E_AFS_SIGNAL;
 }
 
-static void register_signal_task(void)
+static void register_signal_task(struct sched *s)
 {
 	struct signal_task *st = &signal_task_struct;
 
@@ -745,7 +749,7 @@ static void register_signal_task(void)
 	st->task.pre_select = signal_pre_select;
 	st->task.post_select = afs_signal_post_select;
 	sprintf(st->task.status, "signal task");
-	register_task(&st->task);
+	register_task(s, &st->task);
 }
 
 static struct list_head afs_client_list;
@@ -906,7 +910,7 @@ static void command_post_select(struct sched *s, struct task *t)
 	ret = execute_server_command(&s->rfds);
 	if (ret < 0) {
 		PARA_EMERG_LOG("%s\n", para_strerror(-ret));
-		sched_shutdown();
+		sched_shutdown(s);
 		return;
 	}
 	/* Check the list of connected clients. */
@@ -941,7 +945,7 @@ static void command_post_select(struct sched *s, struct task *t)
 	para_list_add(&client->node, &afs_client_list);
 }
 
-static void register_command_task(uint32_t cookie)
+static void register_command_task(uint32_t cookie, struct sched *s)
 {
 	struct command_task *ct = &command_task_struct;
 	ct->fd = setup_command_socket_or_die();
@@ -950,7 +954,7 @@ static void register_command_task(uint32_t cookie)
 	ct->task.pre_select = command_pre_select;
 	ct->task.post_select = command_post_select;
 	sprintf(ct->task.status, "afs command task");
-	register_task(&ct->task);
+	register_task(s, &ct->task);
 }
 
 /**
@@ -964,7 +968,7 @@ __noreturn void afs_init(uint32_t cookie, int socket_fd)
 	static struct sched s;
 	int i, ret;
 
-	register_signal_task();
+	register_signal_task(&s);
 	INIT_LIST_HEAD(&afs_client_list);
 	for (i = 0; i < NUM_AFS_TABLES; i++)
 		afs_tables[i].init(&afs_tables[i]);
@@ -978,7 +982,7 @@ __noreturn void afs_init(uint32_t cookie, int socket_fd)
 	PARA_INFO_LOG("server_socket: %d, afs_socket_cookie: %u\n",
 		server_socket, (unsigned) cookie);
 	init_admissible_files(conf.afs_initial_mode_arg);
-	register_command_task(cookie);
+	register_command_task(cookie, &s);
 	s.default_timeout.tv_sec = 0;
 	s.default_timeout.tv_usec = 999 * 1000;
 	ret = schedule(&s);
@@ -1046,7 +1050,8 @@ int com_init(struct stream_cipher_context *scc, int argc, char * const * const a
 	ret = send_callback_request(create_tables_callback, &query,
 		sc_send_result, scc);
 	if (ret < 0)
-		return sc_send_va_buffer(scc, "%s\n", para_strerror(-ret));
+		/* ignore return value */
+		sc_send_va_buffer(scc, "%s\n", para_strerror(-ret));
 	return ret;
 }