X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=afs.c;h=353626ee7cd37602e1faaeb37004ba278eb9e3f1;hp=0c7526c74110fb59da4cc20b815972421090cc12;hb=68ec1b4e13c62fd94b713bc4983ff86ed9f7f4ef;hpb=d894e0cc7ce94d09847a8a35f47127968d4268f1

diff --git a/afs.c b/afs.c
index 0c7526c7..353626ee 100644
--- a/afs.c
+++ b/afs.c
@@ -75,11 +75,15 @@ struct command_task {
 	struct task task;
 };
 
+extern struct misc_meta_data *mmd;
+
 static int server_socket;
 static struct command_task command_task_struct;
 static struct signal_task signal_task_struct;
 
 static enum play_mode current_play_mode;
+static char *current_mop; /* mode or playlist specifier. NULL means dummy mooe */
+
 
 /**
  * A random number used to "authenticate" the connection.
@@ -431,7 +435,7 @@ int stdin_command(int fd, struct osl_object *arg_obj, callback_function *f,
 	return ret;
 }
 
-int pass_afd(int fd, char *buf, size_t size)
+static int pass_afd(int fd, char *buf, size_t size)
 {
 	struct msghdr msg = {.msg_iov = NULL};
 	struct cmsghdr *cmsg;
@@ -456,7 +460,7 @@ int pass_afd(int fd, char *buf, size_t size)
 
 	/* Sum of the length of all control messages in the buffer */
 	msg.msg_controllen = cmsg->cmsg_len;
-	PARA_NOTICE_LOG("passing %zu bytes and fd %d\n", size, fd);
+	PARA_DEBUG_LOG("passing %zu bytes and fd %d\n", size, fd);
 	ret = sendmsg(server_socket, &msg, 0);
 	if (ret < 0) {
 		ret = -ERRNO_TO_PARA_ERROR(errno);
@@ -468,14 +472,13 @@ int pass_afd(int fd, char *buf, size_t size)
 /**
  * Open the audio file with highest score.
  *
- * \param afd Audio file data is returned here.
- *
- * This stores all information for streaming the "best" audio file
- * in the \a afd structure.
+ * This stores all information for streaming the "best" audio file in a shared
+ * memory area. The id of that area and an open file descriptor for the next
+ * audio file are passed to the server process.
  *
- * \return Positive on success, negative on errors.
+ * \return Standard.
  *
- * \sa close_audio_file(), open_and_update_audio_file().
+ * \sa open_and_update_audio_file().
  */
 int open_next_audio_file(void)
 {
@@ -483,16 +486,16 @@ int open_next_audio_file(void)
 	struct audio_file_data afd;
 	int ret, shmid;
 	char buf[8];
+	long score;
 
-	PARA_NOTICE_LOG("getting next af\n");
-	ret = score_get_best(&aft_row, &afd.score);
+	PARA_NOTICE_LOG("getting next audio file\n");
+	ret = score_get_best(&aft_row, &score);
 	if (ret < 0)
 		return ret;
-	ret = open_and_update_audio_file(aft_row, &afd);
+	ret = open_and_update_audio_file(aft_row, score, &afd);
 	if (ret < 0)
 		return ret;
 	shmid = ret;
-	PARA_NOTICE_LOG("shmid: %u\n", shmid);
 	if (!write_ok(server_socket)) {
 		PARA_EMERG_LOG("afs_socket not writable\n");
 		goto destroy;
@@ -500,6 +503,7 @@ int open_next_audio_file(void)
 	*(uint32_t *)buf = NEXT_AUDIO_FILE;
 	*(uint32_t *)(buf + 4) = (uint32_t)shmid;
 	ret = pass_afd(afd.fd, buf, 8);
+	close(afd.fd);
 	if (ret >= 0)
 		return ret;
 	PARA_ERROR_LOG("%s\n", PARA_STRERROR(-ret));
@@ -508,8 +512,6 @@ destroy:
 	return ret;
 }
 
-static char *current_mop; /* mode or playlist specifier. NULL means dummy mooe */
-
 /* Never fails if arg == NULL */
 static int activate_mood_or_playlist(char *arg, int *num_admissible)
 {
@@ -536,10 +538,19 @@ static int activate_mood_or_playlist(char *arg, int *num_admissible)
 	current_play_mode = mode;
 	if (arg != current_mop) {
 		free(current_mop);
-		if (arg)
+		if (arg) {
 			current_mop = para_strdup(arg);
-		else
+			mmd_lock();
+			strncpy(mmd->afs_mode_string, arg,
+				sizeof(mmd->afs_mode_string));
+			mmd->afs_mode_string[sizeof(mmd->afs_mode_string) - 1] = '\0';
+			mmd_unlock();
+		} else {
+			mmd_lock();
+			strcpy(mmd->afs_mode_string, "dummy");
+			mmd_unlock();
 			current_mop = NULL;
+		}
 	}
 	return 1;
 }
@@ -566,7 +577,7 @@ static int com_select_callback(const struct osl_object *query,
 		ret = activate_mood_or_playlist(current_mop, &num_admissible);
 		if (ret < 0) {
 			para_printf(&pb, "failed, switching to dummy\n");
-			change_current_mood(NULL); /* always successful */
+			activate_mood_or_playlist(NULL, &num_admissible);
 		}
 	}
 	para_printf(&pb, "activated %s (%d admissible files)\n", current_mop?
@@ -594,21 +605,15 @@ int com_select(int fd, int argc, char * const * const argv)
 	return ret;
 }
 
-static void init_admissible_files(void)
+static void init_admissible_files(char *arg)
 {
-	int ret = 0;
-	char *arg = conf.afs_initial_mode_arg;
-	ret = activate_mood_or_playlist(arg, NULL);
-	if (ret >= 0)
-		return;
-	PARA_ERROR_LOG("%s\n", PARA_STRERROR(-ret));
-	PARA_NOTICE_LOG("defaulting to dummy mood\n");
-	activate_mood_or_playlist(NULL, NULL); /* always successful */
+	if (activate_mood_or_playlist(arg, NULL) < 0)
+		activate_mood_or_playlist(NULL, NULL); /* always successful */
 }
 
 static int setup_command_socket_or_die(void)
 {
-	int ret;
+	int ret, socket_fd;
 	char *socket_name = conf.afs_socket_arg;
 	struct sockaddr_un unix_addr;
 
@@ -619,13 +624,18 @@ static int setup_command_socket_or_die(void)
 		PARA_EMERG_LOG("%s: %s\n", PARA_STRERROR(-ret), socket_name);
 		exit(EXIT_FAILURE);
 	}
-	if (listen(ret , 5) < 0) {
-		PARA_EMERG_LOG("%s", "can not listen on socket\n");
+	socket_fd = ret;
+	if (listen(socket_fd , 5) < 0) {
+		PARA_EMERG_LOG("can not listen on socket\n");
 		exit(EXIT_FAILURE);
 	}
-	PARA_INFO_LOG("listening on command socket %s (fd %d)\n", socket_name,
-		ret);
-	return ret;
+	ret = mark_fd_nonblock(socket_fd);
+	if (ret < 0) {
+		close(socket_fd);
+		return ret;
+	}
+	PARA_INFO_LOG("listening on socket %s (fd %d)\n", socket_name, ret);
+	return socket_fd;
 }
 
 static void close_afs_tables(void)
@@ -669,18 +679,20 @@ static int open_afs_tables(void)
 	int i, ret;
 
 	get_database_dir();
+	PARA_NOTICE_LOG("opening %u osl tables in %s\n", NUM_AFS_TABLES,
+		database_dir);
 	for (i = 0; i < NUM_AFS_TABLES; i++) {
 		ret = afs_tables[i].open(database_dir);
 		if (ret >= 0)
 			continue;
 		PARA_ERROR_LOG("%s init: %s\n", afs_tables[i].name,
 			PARA_STRERROR(-ret));
+		break;
 	}
 	if (ret >= 0)
 		return ret;
-	do
-		afs_tables[i].close();
-	while (i--);
+	while (i)
+		afs_tables[--i].close();
 	return ret;
 }
 
@@ -700,6 +712,9 @@ static void signal_pre_select(struct sched *s, struct task *t)
 static void signal_post_select(struct sched *s, struct task *t)
 {
 	struct signal_task *st = t->private_data;
+	t->ret = -E_AFS_PARENT_DIED;
+	if (getppid() == 1)
+		goto err;
 	t->ret = 1;
 	if (!FD_ISSET(st->fd, &s->rfds))
 		return;
@@ -710,10 +725,14 @@ static void signal_post_select(struct sched *s, struct task *t)
 	if (st->signum == SIGHUP) {
 		close_afs_tables();
 		t->ret = open_afs_tables();
+		if (t->ret < 0)
+			goto err;
+		init_admissible_files(current_mop);
 		return;
 	}
-	PARA_NOTICE_LOG("caught signal %d\n", st->signum);
 	t->ret = -E_AFS_SIGNAL;
+err:
+	PARA_NOTICE_LOG("%s\n", PARA_STRERROR(-t->ret));
 	unregister_tasks();
 }
 
@@ -736,9 +755,13 @@ static void register_signal_task(void)
 
 static struct list_head afs_client_list;
 
+/** Describes on connected afs client. */
 struct afs_client {
+	/** Position in the afs client list. */
 	struct list_head node;
+	/** The socket file descriptor for this client. */
 	int fd;
+	/** The time the client connected. */
 	struct timeval connect_time;
 };
 
@@ -820,10 +843,11 @@ static void execute_server_command(void)
 		return;
 	}
 	buf[ret] = '\0';
-	PARA_NOTICE_LOG("received: %s\n", buf);
+	PARA_DEBUG_LOG("received: %s\n", buf);
 	if (!strcmp(buf, "new")) {
 		ret = open_next_audio_file();
-		PARA_NOTICE_LOG("ret: %d\n", ret);
+		if (ret < 0)
+			PARA_ERROR_LOG("%s\n", PARA_STRERROR(-ret));
 		return;
 	}
 	PARA_ERROR_LOG("unknown command\n");
@@ -870,7 +894,7 @@ static void command_post_select(struct sched *s, struct task *t)
 	struct command_task *ct = t->private_data;
 	struct sockaddr_un unix_addr;
 	struct afs_client *client, *tmp;
-
+	int fd;
 	if (FD_ISSET(server_socket, &s->rfds))
 		execute_server_command();
 
@@ -897,8 +921,15 @@ static void command_post_select(struct sched *s, struct task *t)
 		PARA_NOTICE_LOG("%s\n", PARA_STRERROR(-t->ret));
 		goto out;
 	}
+	fd = t->ret;
+	t->ret = mark_fd_nonblock(fd);
+	if (t->ret < 0) {
+		PARA_NOTICE_LOG("%s\n", PARA_STRERROR(-t->ret));
+		close(fd);
+		goto out;
+	}
 	client = para_malloc(sizeof(*client));
-	client->fd = t->ret;
+	client->fd = fd;
 	client->connect_time = *now;
 	para_list_add(&client->node, &afs_client_list);
 out:
@@ -950,10 +981,10 @@ __noreturn void afs_init(uint32_t cookie, int socket_fd)
 		exit(EXIT_FAILURE);
 	PARA_INFO_LOG("server_socket: %d, afs_socket_cookie: %u\n",
 		server_socket, (unsigned) cookie);
-	init_admissible_files();
+	init_admissible_files(conf.afs_initial_mode_arg);
 	register_tasks(cookie);
 	s.default_timeout.tv_sec = 0;
-	s.default_timeout.tv_usec = 99 * 1000;
+	s.default_timeout.tv_usec = 999 * 1000;
 	ret = sched(&s);
 	if (ret < 0)
 		PARA_EMERG_LOG("%s\n", PARA_STRERROR(-ret));