X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=afs.c;h=9ef44d7bba82f44b4a615ed5144d7239b0e7218c;hp=955b8f207d5305418674f6a0f2e30f904d110517;hb=9de1287d67c9562e9140c6dc7deb0c01c4e10cc0;hpb=4a0c8e1fb760134609dcf2c06cd1b9b76953d606

diff --git a/afs.c b/afs.c
index 955b8f20..9ef44d7b 100644
--- a/afs.c
+++ b/afs.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2007-2011 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2007-2012 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -286,6 +286,9 @@ out:
  * command. This function allows to pass such a structure together with a list
  * of further arguments (often a list of audio files) to the parent process.
  *
+ * \return The return value of the underlying call to \ref
+ * send_callback_request().
+ *
  * \sa send_standard_callback_request(), send_callback_request().
  */
 int send_option_arg_callback_request(struct osl_object *options,
@@ -360,7 +363,10 @@ static int action_if_pattern_matches(struct osl_row *row, void *data)
 			continue;
 		if (ret)
 			return -E_FNMATCH;
-		return pmd->action(pmd->table, row, name, pmd->data);
+		ret = pmd->action(pmd->table, row, name, pmd->data);
+		if (ret >= 0)
+			pmd->num_matches++;
+		return ret;
 	}
 	return 1;
 }
@@ -724,11 +730,11 @@ static void afs_signal_post_select(struct sched *s, struct task *t)
 	}
 	PARA_EMERG_LOG("terminating on signal %d\n", signum);
 shutdown:
-	sched_shutdown();
+	sched_shutdown(s);
 	t->error = -E_AFS_SIGNAL;
 }
 
-static void register_signal_task(void)
+static void register_signal_task(struct sched *s)
 {
 	struct signal_task *st = &signal_task_struct;
 
@@ -742,7 +748,7 @@ static void register_signal_task(void)
 	st->task.pre_select = signal_pre_select;
 	st->task.post_select = afs_signal_post_select;
 	sprintf(st->task.status, "signal task");
-	register_task(&st->task);
+	register_task(s, &st->task);
 }
 
 static struct list_head afs_client_list;
@@ -903,7 +909,7 @@ static void command_post_select(struct sched *s, struct task *t)
 	ret = execute_server_command(&s->rfds);
 	if (ret < 0) {
 		PARA_EMERG_LOG("%s\n", para_strerror(-ret));
-		sched_shutdown();
+		sched_shutdown(s);
 		return;
 	}
 	/* Check the list of connected clients. */
@@ -938,7 +944,7 @@ static void command_post_select(struct sched *s, struct task *t)
 	para_list_add(&client->node, &afs_client_list);
 }
 
-static void register_command_task(uint32_t cookie)
+static void register_command_task(uint32_t cookie, struct sched *s)
 {
 	struct command_task *ct = &command_task_struct;
 	ct->fd = setup_command_socket_or_die();
@@ -947,7 +953,7 @@ static void register_command_task(uint32_t cookie)
 	ct->task.pre_select = command_pre_select;
 	ct->task.post_select = command_post_select;
 	sprintf(ct->task.status, "afs command task");
-	register_task(&ct->task);
+	register_task(s, &ct->task);
 }
 
 /**
@@ -961,7 +967,7 @@ __noreturn void afs_init(uint32_t cookie, int socket_fd)
 	static struct sched s;
 	int i, ret;
 
-	register_signal_task();
+	register_signal_task(&s);
 	INIT_LIST_HEAD(&afs_client_list);
 	for (i = 0; i < NUM_AFS_TABLES; i++)
 		afs_tables[i].init(&afs_tables[i]);
@@ -975,7 +981,7 @@ __noreturn void afs_init(uint32_t cookie, int socket_fd)
 	PARA_INFO_LOG("server_socket: %d, afs_socket_cookie: %u\n",
 		server_socket, (unsigned) cookie);
 	init_admissible_files(conf.afs_initial_mode_arg);
-	register_command_task(cookie);
+	register_command_task(cookie, &s);
 	s.default_timeout.tv_sec = 0;
 	s.default_timeout.tv_usec = 999 * 1000;
 	ret = schedule(&s);
@@ -1043,7 +1049,8 @@ int com_init(struct stream_cipher_context *scc, int argc, char * const * const a
 	ret = send_callback_request(create_tables_callback, &query,
 		sc_send_result, scc);
 	if (ret < 0)
-		return sc_send_va_buffer(scc, "%s\n", para_strerror(-ret));
+		/* ignore return value */
+		sc_send_va_buffer(scc, "%s\n", para_strerror(-ret));
 	return ret;
 }
 
@@ -1146,7 +1153,8 @@ void afs_event(enum afs_events event, struct para_buffer *pb,
  * \param pb Unused.
  * \param data Unused.
  *
- * This table does not honor events.
+ * \return The images table does not honor events, so this handler always
+ * returns success.
  */
 __a_const int images_event_handler(__a_unused enum afs_events event,
 	__a_unused  struct para_buffer *pb, __a_unused void *data)
@@ -1161,7 +1169,8 @@ __a_const int images_event_handler(__a_unused enum afs_events event,
  * \param pb Unused.
  * \param data Unused.
  *
- * This table does not honor events.
+ * \return The lyrics table does not honor events, so this handler always
+ * returns success.
  */
 __a_const int lyrics_event_handler(__a_unused enum afs_events event,
 	__a_unused struct para_buffer *pb, __a_unused void *data)