X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=aft.c;h=001026db4e956caa8b46256797d29cddced6ddf5;hp=2b7a7af7efaa8d8fb72b55eb48616103c04cf1eb;hb=7d30b7e68ff5219312622d6b5c3c2b8e8866585d;hpb=ddae5908a9f0554d9eea303f3c8a97d7e8b754a1

diff --git a/aft.c b/aft.c
index 2b7a7af7..001026db 100644
--- a/aft.c
+++ b/aft.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2007 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2007-2008 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -660,6 +660,7 @@ int open_and_update_audio_file(struct osl_row *aft_row, long score,
 		AFTCOL_CHUNKS, &chunk_table_obj);
 	if (ret < 0)
 		return ret;
+	afd->afhi.chunk_table = NULL;
 	ret = mmap_full_file(path, O_RDONLY, &map.data,
 		&map.size, &afd->fd);
 	if (ret < 0)
@@ -697,10 +698,8 @@ int open_and_update_audio_file(struct osl_row *aft_row, long score,
 	aced.old_afsi = &old_afsi;
 	afs_event(AFSI_CHANGE, NULL, &aced);
 	ret = save_afd(afd);
-	free(afd->afhi.chunk_table);
-	if (ret < 0)
-		goto err;
 err:
+	free(afd->afhi.chunk_table);
 	osl_close_disk_object(&chunk_table_obj);
 	return ret;
 }
@@ -2005,11 +2004,14 @@ int com_touch(int fd, int argc, char * const * const argv)
 		return -E_AFT_SYNTAX;
 	ret = send_option_arg_callback_request(&query, argc - i,
 		argv + i, com_touch_callback, &result);
-	if (ret > 0) {
-		send_buffer(fd, (char *)result.data);
-		free(result.data);
-	} else if (ret < 0)
+	if (!ret)
+		return 0;
+	if (ret < 0) {
 		send_va_buffer(fd, "%s\n", para_strerror(-ret));
+		return ret;
+	}
+	ret = send_buffer(fd, (char *)result.data);
+	free(result.data);
 	return ret;
 }
 
@@ -2117,11 +2119,14 @@ int com_rm(int fd, int argc,  char * const * const argv)
 		return -E_AFT_SYNTAX;
 	ret = send_option_arg_callback_request(&query, argc - i, argv + i,
 		com_rm_callback, &result);
-	if (ret > 0) {
-		send_buffer(fd, (char *)result.data);
-		free(result.data);
-	} else if (ret < 0)
+	if (!ret)
+		return 0;
+	if (ret < 0) {
 		send_va_buffer(fd, "%s\n", para_strerror(-ret));
+		return ret;
+	}
+	ret = send_buffer(fd, (char *)result.data);
+	free(result.data);
 	return ret;
 }
 
@@ -2278,11 +2283,14 @@ int com_cpsi(int fd, int argc,  char * const * const argv)
 		flags = ~(unsigned)CPSI_FLAG_VERBOSE | flags;
 	ret = send_option_arg_callback_request(&options, argc - i, argv + i,
 		com_cpsi_callback, &result);
-	if (ret > 0) {
-		send_buffer(fd, (char *)result.data);
-		free(result.data);
-	} else
+	if (!ret)
+		return 0;
+	if (ret < 0) {
 		send_va_buffer(fd, "%s\n", para_strerror(-ret));
+		return ret;
+	}
+	ret = send_buffer(fd, (char *)result.data);
+	free(result.data);
 	return ret;
 }