X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=aft.c;h=c255b245fdf0209f0c8b09ba0b28310fddcb8fa5;hp=acf751566c61d82e23cc34565c1189f2db147917;hb=9602629057e1016f8ca7dfa2aae1477e4faece65;hpb=e9b00a14a4653d767a9d0fe885aa0b6d56c42180

diff --git a/aft.c b/aft.c
index acf75156..c255b245 100644
--- a/aft.c
+++ b/aft.c
@@ -748,62 +748,50 @@ static int write_attribute_items(struct para_buffer *b,
 	char *att_text;
 	int ret;
 
-	ret = WRITE_STATUS_ITEM(b, SI_ATTRIBUTES_BITMAP, "%s\n", att_bitmap);
-	if (ret < 0)
-		return ret;
+	WRITE_STATUS_ITEM(b, SI_ATTRIBUTES_BITMAP, "%s\n", att_bitmap);
 	ret = get_attribute_text(&afsi->attributes, " ", &att_text);
 	if (ret < 0)
 		return ret;
-	ret = WRITE_STATUS_ITEM(b, SI_ATTRIBUTES_TXT, "%s\n", att_text);
+	WRITE_STATUS_ITEM(b, SI_ATTRIBUTES_TXT, "%s\n", att_text);
 	free(att_text);
 	return ret;
 }
 
-static int write_lyrics_items(struct para_buffer *b, struct afs_info *afsi)
+static void write_lyrics_items(struct para_buffer *b, struct afs_info *afsi)
 {
 	char *lyrics_name;
-	int ret;
 
-	ret = WRITE_STATUS_ITEM(b, SI_LYRICS_ID, "%u\n", afsi->lyrics_id);
-	if (ret < 0)
-		return ret;
+	WRITE_STATUS_ITEM(b, SI_LYRICS_ID, "%u\n", afsi->lyrics_id);
 	lyr_get_name_by_id(afsi->lyrics_id, &lyrics_name);
-	return WRITE_STATUS_ITEM(b, SI_LYRICS_NAME, "%s\n", lyrics_name?
+	WRITE_STATUS_ITEM(b, SI_LYRICS_NAME, "%s\n", lyrics_name?
 		lyrics_name : "(none)");
 }
 
-static int write_image_items(struct para_buffer *b, struct afs_info *afsi)
+static void write_image_items(struct para_buffer *b, struct afs_info *afsi)
 {
 	char *image_name;
-	int ret;
 
-	ret = WRITE_STATUS_ITEM(b, SI_IMAGE_ID, "%u\n", afsi->image_id);
-	if (ret < 0)
-		return ret;
+	WRITE_STATUS_ITEM(b, SI_IMAGE_ID, "%u\n", afsi->image_id);
 	img_get_name_by_id(afsi->image_id, &image_name);
-	return WRITE_STATUS_ITEM(b, SI_IMAGE_NAME, "%s\n", image_name?
+	WRITE_STATUS_ITEM(b, SI_IMAGE_NAME, "%s\n", image_name?
 		image_name : "(none)");
 }
 
-static int write_filename_items(struct para_buffer *b, const char *path,
+static void write_filename_items(struct para_buffer *b, const char *path,
 		unsigned flags)
 {
 	char *val;
-	int ret;
 
-	if (!(flags & LS_FLAG_FULL_PATH))
-		return WRITE_STATUS_ITEM(b, SI_BASENAME, "%s\n", path);
-	ret = WRITE_STATUS_ITEM(b, SI_PATH, "%s\n", path);
-	if (ret < 0)
-		return ret;
+	if (!(flags & LS_FLAG_FULL_PATH)) {
+		WRITE_STATUS_ITEM(b, SI_BASENAME, "%s\n", path);
+		return;
+	}
+	WRITE_STATUS_ITEM(b, SI_PATH, "%s\n", path);
 	val = para_basename(path);
-	ret = WRITE_STATUS_ITEM(b, SI_BASENAME, "%s\n", val? val : "");
-	if (ret < 0)
-		return ret;
+	WRITE_STATUS_ITEM(b, SI_BASENAME, "%s\n", val? val : "");
 	val = para_dirname(path);
-	ret = WRITE_STATUS_ITEM(b, SI_DIRECTORY, "%s\n", val? val : "");
+	WRITE_STATUS_ITEM(b, SI_DIRECTORY, "%s\n", val? val : "");
 	free(val);
-	return ret;
 }
 
 static int print_chunk_table(struct ls_data *d, struct para_buffer *b)
@@ -820,32 +808,27 @@ static int print_chunk_table(struct ls_data *d, struct para_buffer *b)
 		AFTCOL_CHUNKS, &chunk_table_obj));
 	if (ret < 0)
 		return ret;
-	ret = para_printf(b, "%s\n"
+	para_printf(b, "%s\n"
 		"chunk_time: %lu:%lu\nchunk_offsets: ",
 		d->path,
 		(long unsigned) d->afhi.chunk_tv.tv_sec,
 		(long unsigned) d->afhi.chunk_tv.tv_usec
 	);
-	if (ret < 0)
-		goto out;
 	buf = chunk_table_obj.data;
-	for (i = 0; i <= d->afhi.chunks_total; i++) {
-		ret = para_printf(b, "%u ", (unsigned) read_u32(buf + 4 * i));
-		if (ret < 0)
-			goto out;
-	}
-	ret = para_printf(b, "\n");
-out:
+	for (i = 0; i <= d->afhi.chunks_total; i++)
+		para_printf(b, "%u ", (unsigned) read_u32(buf + 4 * i));
+	para_printf(b, "\n");
+	ret = 1;
 	osl_close_disk_object(&chunk_table_obj);
 	return ret;
 }
 
-static int write_score(struct para_buffer *b, struct ls_data *d,
+static void write_score(struct para_buffer *b, struct ls_data *d,
 		struct ls_options *opts)
 {
 	if (!(opts->flags & LS_FLAG_ADMISSIBLE_ONLY)) /* no score*/
-		return 0;
-	return WRITE_STATUS_ITEM(b, SI_SCORE, "%li\n", d->score);
+		return;
+	WRITE_STATUS_ITEM(b, SI_SCORE, "%li\n", d->score);
 }
 
 static int print_list_item(struct ls_data *d, struct ls_options *opts,
@@ -860,7 +843,8 @@ static int print_list_item(struct ls_data *d, struct ls_options *opts,
 	char asc_hash[2 * HASH_SIZE + 1];
 
 	if (opts->mode == LS_MODE_SHORT) {
-		ret = para_printf(b, "%s\n", d->path);
+		para_printf(b, "%s\n", d->path);
+		ret = 1;
 		goto out;
 	}
 	if (opts->mode == LS_MODE_CHUNKS) {
@@ -881,12 +865,10 @@ static int print_list_item(struct ls_data *d, struct ls_options *opts,
 	if (opts->mode == LS_MODE_LONG) {
 		struct ls_widths *w = &opts->widths;
 		if (opts->flags & LS_FLAG_ADMISSIBLE_ONLY) {
-			ret = para_printf(b, "%*li ",
-				opts->widths.score_width, d->score);
-			if (ret < 0)
-				goto out;
+			para_printf(b, "%*li ", opts->widths.score_width,
+				d->score);
 		}
-		ret = para_printf(b,
+		para_printf(b,
 			"%s "   /* attributes */
 			"%*u "  /* amp */
 			"%*d "  /* image_id  */
@@ -913,98 +895,50 @@ static int print_list_item(struct ls_data *d, struct ls_options *opts,
 			last_played_time,
 			d->path
 		);
+		ret = 1;
 		goto out;
 	}
 	if (opts->mode == LS_MODE_MBOX) {
 		const char *bn = para_basename(d->path);
-		ret = para_printf(b,
+		para_printf(b,
 			"From foo@localhost %s\n"
 			"Received: from\nTo: bar\nFrom: a\n"
 			"Subject: %s\n\n",
 			last_played_time,
 			bn? bn : "?");
-		if (ret < 0)
-			goto out;
 	}
-	ret = write_filename_items(b, d->path, opts->flags);
-	if (ret < 0)
-		goto out;
-	ret = write_score(b, d, opts);
-	if (ret < 0)
-		goto out;
+	write_filename_items(b, d->path, opts->flags);
+	write_score(b, d, opts);
 	ret = write_attribute_items(b, att_buf, afsi);
 	if (ret < 0)
 		goto out;
-	ret = write_image_items(b, afsi);
-	if (ret < 0)
-		goto out;
-	ret = write_lyrics_items(b, afsi);
-	if (ret < 0)
-		goto out;
+	write_image_items(b, afsi);
+	write_lyrics_items(b, afsi);
 	hash_to_asc(d->hash, asc_hash);
-	ret = WRITE_STATUS_ITEM(b, SI_HASH, "%s\n", asc_hash);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_BITRATE, "%dkbit/s\n", afhi->bitrate);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_FORMAT, "%s\n",
+	WRITE_STATUS_ITEM(b, SI_HASH, "%s\n", asc_hash);
+	WRITE_STATUS_ITEM(b, SI_BITRATE, "%dkbit/s\n", afhi->bitrate);
+	WRITE_STATUS_ITEM(b, SI_FORMAT, "%s\n",
 		audio_format_name(afsi->audio_format_id));
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_FREQUENCY, "%dHz\n", afhi->frequency);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_CHANNELS, "%d\n", afhi->channels);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_DURATION, "%s\n", duration_buf);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_SECONDS_TOTAL, "%lu\n",
-		afhi->seconds_total);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_LAST_PLAYED, "%s\n", last_played_time);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_NUM_PLAYED, "%d\n", afsi->num_played);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_AMPLIFICATION, "%u\n", afsi->amp);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_CHUNK_TIME, "%lu\n",
-		tv2ms(&afhi->chunk_tv));
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_NUM_CHUNKS, "%lu\n",
-		afhi->chunks_total);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_TECHINFO, "%s\n", afhi->techinfo);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_ARTIST, "%s\n", afhi->tags.artist);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_TITLE, "%s\n", afhi->tags.title);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_YEAR, "%s\n", afhi->tags.year);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_ALBUM, "%s\n", afhi->tags.album);
-	if (ret < 0)
-		goto out;
-	ret = WRITE_STATUS_ITEM(b, SI_COMMENT, "%s\n", afhi->tags.comment);
-	if (ret < 0)
-		goto out;
+	WRITE_STATUS_ITEM(b, SI_FREQUENCY, "%dHz\n", afhi->frequency);
+	WRITE_STATUS_ITEM(b, SI_CHANNELS, "%d\n", afhi->channels);
+	WRITE_STATUS_ITEM(b, SI_DURATION, "%s\n", duration_buf);
+	WRITE_STATUS_ITEM(b, SI_SECONDS_TOTAL, "%lu\n", afhi->seconds_total);
+	WRITE_STATUS_ITEM(b, SI_LAST_PLAYED, "%s\n", last_played_time);
+	WRITE_STATUS_ITEM(b, SI_NUM_PLAYED, "%d\n", afsi->num_played);
+	WRITE_STATUS_ITEM(b, SI_AMPLIFICATION, "%u\n", afsi->amp);
+	WRITE_STATUS_ITEM(b, SI_CHUNK_TIME, "%lu\n", tv2ms(&afhi->chunk_tv));
+	WRITE_STATUS_ITEM(b, SI_NUM_CHUNKS, "%lu\n", afhi->chunks_total);
+	WRITE_STATUS_ITEM(b, SI_TECHINFO, "%s\n", afhi->techinfo);
+	WRITE_STATUS_ITEM(b, SI_ARTIST, "%s\n", afhi->tags.artist);
+	WRITE_STATUS_ITEM(b, SI_TITLE, "%s\n", afhi->tags.title);
+	WRITE_STATUS_ITEM(b, SI_YEAR, "%s\n", afhi->tags.year);
+	WRITE_STATUS_ITEM(b, SI_ALBUM, "%s\n", afhi->tags.album);
+	WRITE_STATUS_ITEM(b, SI_COMMENT, "%s\n", afhi->tags.comment);
 	if (opts->mode == LS_MODE_MBOX) {
 		struct osl_object lyrics_def;
 		lyr_get_def_by_id(afsi->lyrics_id, &lyrics_def);
 		if (lyrics_def.data) {
-			ret = para_printf(b, "Lyrics:\n~~~~~~~\n%s",
+			para_printf(b, "Lyrics:\n~~~~~~~\n%s",
 				(char *)lyrics_def.data);
 			osl_close_disk_object(&lyrics_def);
 		}
@@ -1033,9 +967,8 @@ static void make_inode_status_items(struct para_buffer *pb)
 	ret = strftime(mtime_str, 29, "%b %d %Y", &mtime_tm);
 	assert(ret > 0); /* number of bytes placed in mtime_str */
 out:
-	/* We don't care too much about errors here */
-	(void)WRITE_STATUS_ITEM(pb, SI_MTIME, "%s\n", mtime_str);
-	(void)WRITE_STATUS_ITEM(pb, SI_FILE_SIZE, "%ld\n", statbuf.st_size / 1024);
+	WRITE_STATUS_ITEM(pb, SI_MTIME, "%s\n", mtime_str);
+	WRITE_STATUS_ITEM(pb, SI_FILE_SIZE, "%ld\n", statbuf.st_size / 1024);
 }
 
 static int make_status_items(void)
@@ -1358,7 +1291,7 @@ err:
 	return ret;
 }
 
-static void com_ls_callback(int fd, const struct osl_object *query)
+static int com_ls_callback(int fd, const struct osl_object *query)
 {
 	struct ls_options *opts = query->data;
 	char *p, *pattern_start = (char *)query->data + sizeof(*opts);
@@ -1390,8 +1323,7 @@ static void com_ls_callback(int fd, const struct osl_object *query)
 	if (ret < 0)
 		goto out;
 	if (opts->num_matching_paths == 0) {
-		if (opts->num_patterns > 0)
-			para_printf(&b, "no matches\n");
+		ret = opts->num_patterns > 0? -E_NO_MATCH : 0;
 		goto out;
 	}
 	ret = sort_matching_paths(opts);
@@ -1411,12 +1343,11 @@ static void com_ls_callback(int fd, const struct osl_object *query)
 				goto out;
 		}
 out:
-	if (b.offset)
-		pass_buffer_as_shm(fd, SBD_OUTPUT, b.buf, b.offset);
-	free(b.buf);
+	flush_and_free_pb(&b);
 	free(opts->data);
 	free(opts->data_ptr);
 	free(opts->patterns);
+	return ret;
 }
 
 /*
@@ -1424,7 +1355,7 @@ out:
  */
 int com_ls(struct command_context *cc)
 {
-	int i, ret;
+	int i;
 	unsigned flags = 0;
 	enum ls_sorting_method sort = LS_SORT_BY_PATH;
 	enum ls_listing_mode mode = LS_MODE_SHORT;
@@ -1533,9 +1464,8 @@ int com_ls(struct command_context *cc)
 	opts.sorting = sort;
 	opts.mode = mode;
 	opts.num_patterns = cc->argc - i;
-	ret = send_option_arg_callback_request(&query, opts.num_patterns,
+	return send_option_arg_callback_request(&query, opts.num_patterns,
 		cc->argv + i, com_ls_callback, afs_cb_result_handler, cc);
-	return ret;
 }
 
 /**
@@ -1681,7 +1611,7 @@ enum com_add_flags {
 	ADD_FLAG_ALL = 8,
 };
 
-static void com_add_callback(int fd, const struct osl_object *query)
+static int com_add_callback(int fd, const struct osl_object *query)
 {
 	char *buf = query->data, *path;
 	struct osl_row *pb, *aft_row;
@@ -1719,19 +1649,15 @@ static void com_add_callback(int fd, const struct osl_object *query)
 		goto out;
 	if (hs && pb && hs == pb && !(flags & ADD_FLAG_FORCE)) {
 		if (flags & ADD_FLAG_VERBOSE)
-			ret = para_printf(&msg, "ignoring duplicate\n");
-		else
-			ret = 1;
+			para_printf(&msg, "ignoring duplicate\n");
+		ret = 1;
 		goto out;
 	}
 	if (hs && hs != pb) {
 		struct osl_object obj;
 		if (pb) { /* hs trumps pb, remove pb */
-			if (flags & ADD_FLAG_VERBOSE) {
-				ret = para_printf(&msg, "removing %s\n", path);
-				if (ret < 0)
-					goto out;
-			}
+			if (flags & ADD_FLAG_VERBOSE)
+				para_printf(&msg, "removing %s\n", path);
 			afs_event(AUDIO_FILE_REMOVE, &msg, pb);
 			ret = osl(osl_del_row(audio_file_table, pb));
 			if (ret < 0)
@@ -1744,9 +1670,7 @@ static void com_add_callback(int fd, const struct osl_object *query)
 				AFTCOL_PATH, &obj));
 			if (ret < 0)
 				goto out;
-			ret = para_printf(&msg, "renamed from %s\n", (char *)obj.data);
-			if (ret < 0)
-				goto out;
+			para_printf(&msg, "renamed from %s\n", (char *)obj.data);
 		}
 		ret = osl(osl_update_object(audio_file_table, hs, AFTCOL_PATH,
 			&objs[AFTCOL_PATH]));
@@ -1774,12 +1698,9 @@ static void com_add_callback(int fd, const struct osl_object *query)
 		if (ret < 0)
 			goto out;
 		hash_to_asc(old_hash, old_asc);
-		if (flags & ADD_FLAG_VERBOSE) {
-			ret = para_printf(&msg, "file change: %s -> %s\n",
-				old_asc, asc);
-			if (ret < 0)
-				goto out;
-		}
+		if (flags & ADD_FLAG_VERBOSE)
+			para_printf(&msg, "file change: %s -> %s\n", old_asc,
+				asc);
 		ret = osl_update_object(audio_file_table, pb, AFTCOL_HASH,
 			&objs[AFTCOL_HASH]);
 		if (ret < 0)
@@ -1788,11 +1709,8 @@ static void com_add_callback(int fd, const struct osl_object *query)
 	if (hs || pb) { /* (hs != NULL and pb != NULL) implies hs == pb */
 		struct osl_row *row = pb? pb : hs;
 		/* update afhi and chunk_table */
-		if (flags & ADD_FLAG_VERBOSE) {
-			ret = para_printf(&msg, "updating afhi and chunk table\n");
-			if (ret < 0)
-				goto out;
-		}
+		if (flags & ADD_FLAG_VERBOSE)
+			para_printf(&msg, "updating afhi and chunk table\n");
 		ret = osl(osl_update_object(audio_file_table, row, AFTCOL_AFHI,
 			&objs[AFTCOL_AFHI]));
 		if (ret < 0)
@@ -1805,11 +1723,8 @@ static void com_add_callback(int fd, const struct osl_object *query)
 		goto out;
 	}
 	/* new entry, use default afsi */
-	if (flags & ADD_FLAG_VERBOSE) {
-		ret = para_printf(&msg, "new file\n");
-		if (ret < 0)
-			goto out;
-	}
+	if (flags & ADD_FLAG_VERBOSE)
+		para_printf(&msg, "new file\n");
 	default_afsi.last_played = time(NULL) - 365 * 24 * 60 * 60;
 	default_afsi.audio_format_id = read_u8(buf + CAB_AUDIO_FORMAT_OFFSET);
 
@@ -1820,10 +1735,9 @@ static void com_add_callback(int fd, const struct osl_object *query)
 	afs_event(AUDIO_FILE_ADD, &msg, aft_row);
 out:
 	if (ret < 0)
-		para_printf(&msg, "%s\n", para_strerror(-ret));
-	if (msg.offset)
-		pass_buffer_as_shm(fd, SBD_OUTPUT, msg.buf, msg.offset);
-	free(msg.buf);
+		para_printf(&msg, "could not add %s\n", path);
+	flush_and_free_pb(&msg);
+	return ret;
 }
 
 /** Used by com_add(). */
@@ -1834,26 +1748,26 @@ struct private_add_data {
 	uint32_t flags;
 };
 
-static void path_brother_callback(int fd, const struct osl_object *query)
+static int path_brother_callback(int fd, const struct osl_object *query)
 {
 	char *path = query->data;
 	struct osl_row *path_brother;
 	int ret = aft_get_row_of_path(path, &path_brother);
 	if (ret < 0)
-		return;
-	pass_buffer_as_shm(fd, SBD_OUTPUT, (char *)&path_brother,
+		return ret;
+	return pass_buffer_as_shm(fd, SBD_OUTPUT, (char *)&path_brother,
 		sizeof(path_brother));
 }
 
-static void hash_sister_callback(int fd, const struct osl_object *query)
+static int hash_sister_callback(int fd, const struct osl_object *query)
 {
 	unsigned char *hash = query->data;
 	struct osl_row *hash_sister;
 
 	hash_sister = find_hash_sister(hash);
 	if (!hash_sister)
-		return;
-	pass_buffer_as_shm(fd, SBD_OUTPUT, (char *)&hash_sister,
+		return 0;
+	return pass_buffer_as_shm(fd, SBD_OUTPUT, (char *)&hash_sister,
 		sizeof(hash_sister));
 }
 
@@ -1861,7 +1775,9 @@ static int get_row_pointer_from_result(struct osl_object *result,
 		__a_unused uint8_t band, void *private)
 {
 	struct osl_row **row = private;
-	*row = *(struct osl_row **)(result->data);
+
+	if (band == SBD_OUTPUT)
+		*row = *(struct osl_row **)(result->data);
 	return 1;
 }
 
@@ -1876,8 +1792,10 @@ static int add_one_audio_file(const char *path, void *private_data)
 	unsigned char hash[HASH_SIZE];
 
 	ret = guess_audio_format(path);
-	if (ret < 0 && !(pad->flags & ADD_FLAG_ALL))
+	if (ret < 0 && !(pad->flags & ADD_FLAG_ALL)) {
+		ret = 0;
 		goto out_free;
+	}
 	query.data = (char *)path;
 	query.size = strlen(path) + 1;
 	ret = send_callback_request(path_brother_callback, &query,
@@ -2055,28 +1973,26 @@ static int touch_audio_file(__a_unused struct osl_table *table,
 	struct afsi_change_event_data aced;
 
 	ret = get_afsi_object_of_row(row, &obj);
-	if (ret < 0)
-		return para_printf(&tad->pb, "%s: %s\n", name, para_strerror(-ret));
+	if (ret < 0) {
+		para_printf(&tad->pb, "cannot touch %s\n", name);
+		return ret;
+	}
 	ret = load_afsi(&old_afsi, &obj);
-	if (ret < 0)
-		return para_printf(&tad->pb, "%s: %s\n", name, para_strerror(-ret));
+	if (ret < 0) {
+		para_printf(&tad->pb, "cannot touch %s\n", name);
+		return ret;
+	}
 	new_afsi = old_afsi;
 	if (no_options) {
 		new_afsi.num_played++;
 		new_afsi.last_played = time(NULL);
-		if (tad->cto->flags & TOUCH_FLAG_VERBOSE) {
-			ret = para_printf(&tad->pb, "%s: num_played = %u, "
+		if (tad->cto->flags & TOUCH_FLAG_VERBOSE)
+			para_printf(&tad->pb, "%s: num_played = %u, "
 				"last_played = now()\n", name,
 				new_afsi.num_played);
-			if (ret < 0)
-				return ret;
-		}
 	} else {
-		if (tad->cto->flags & TOUCH_FLAG_VERBOSE) {
-			ret = para_printf(&tad->pb, "touching %s\n", name);
-			if (ret < 0)
-				return ret;
-		}
+		if (tad->cto->flags & TOUCH_FLAG_VERBOSE)
+			para_printf(&tad->pb, "touching %s\n", name);
 		if (tad->cto->lyrics_id >= 0)
 			new_afsi.lyrics_id = tad->cto->lyrics_id;
 		if (tad->cto->image_id >= 0)
@@ -2095,7 +2011,7 @@ static int touch_audio_file(__a_unused struct osl_table *table,
 	return 1;
 }
 
-static void com_touch_callback(int fd, const struct osl_object *query)
+static int com_touch_callback(int fd, const struct osl_object *query)
 {
 	struct touch_action_data tad = {.cto = query->data,
 		.pb = {
@@ -2107,7 +2023,7 @@ static void com_touch_callback(int fd, const struct osl_object *query)
 			.max_size_handler = afs_max_size_handler
 		}
 	};
-	int ret, ret2 = 0;
+	int ret;
 	struct pattern_match_data pmd = {
 		.table = audio_file_table,
 		.loop_col_num = AFTCOL_HASH,
@@ -2120,13 +2036,10 @@ static void com_touch_callback(int fd, const struct osl_object *query)
 	if (tad.cto->flags & TOUCH_FLAG_FNM_PATHNAME)
 		pmd.fnmatch_flags |= FNM_PATHNAME;
 	ret = for_each_matching_row(&pmd);
-	if (ret < 0)
-		ret2 = para_printf(&tad.pb, "%s\n", para_strerror(-ret));
-	else if (pmd.num_matches == 0)
-		ret2 = para_printf(&tad.pb, "no matches\n");
-	if (ret2 >= 0 && tad.pb.offset)
-		pass_buffer_as_shm(fd, SBD_OUTPUT, tad.pb.buf, tad.pb.offset);
-	free(tad.pb.buf);
+	if (ret >= 0 && pmd.num_matches == 0)
+		ret = -E_NO_MATCH;
+	flush_and_free_pb(&tad.pb);
+	return ret;
 }
 
 int com_touch(struct command_context *cc)
@@ -2196,11 +2109,8 @@ int com_touch(struct command_context *cc)
 	}
 	if (i >= cc->argc)
 		return -E_AFT_SYNTAX;
-	ret = send_option_arg_callback_request(&query, cc->argc - i,
+	return send_option_arg_callback_request(&query, cc->argc - i,
 		cc->argv + i, com_touch_callback, afs_cb_result_handler, cc);
-	if (ret < 0)
-		send_strerror(cc, -ret);
-	return ret;
 }
 
 /** Flags for com_rm(). */
@@ -2227,19 +2137,16 @@ static int remove_audio_file(__a_unused struct osl_table *table,
 	struct com_rm_action_data *crd = data;
 	int ret;
 
-	if (crd->flags & RM_FLAG_VERBOSE) {
-		ret = para_printf(&crd->pb, "removing %s\n", name);
-		if (ret < 0)
-			return ret;
-	}
+	if (crd->flags & RM_FLAG_VERBOSE)
+		para_printf(&crd->pb, "removing %s\n", name);
 	afs_event(AUDIO_FILE_REMOVE, &crd->pb, row);
 	ret = osl(osl_del_row(audio_file_table, row));
 	if (ret < 0)
-		para_printf(&crd->pb, "%s: %s\n", name, para_strerror(-ret));
+		para_printf(&crd->pb, "cannot remove %s\n", name);
 	return ret;
 }
 
-static void com_rm_callback(int fd, const struct osl_object *query)
+static int com_rm_callback(int fd, const struct osl_object *query)
 {
 	struct com_rm_action_data crd = {.flags = *(uint32_t *)query->data,
 		.pb = {
@@ -2264,19 +2171,15 @@ static void com_rm_callback(int fd, const struct osl_object *query)
 	if (crd.flags & RM_FLAG_FNM_PATHNAME)
 		pmd.fnmatch_flags |= FNM_PATHNAME;
 	ret = for_each_matching_row(&pmd);
-	if (ret < 0) {
-		para_printf(&crd.pb, "%s\n", para_strerror(-ret));
-		return;
-	}
-	if ((pmd.num_matches == 0) && !(crd.flags & RM_FLAG_FORCE))
-		ret = para_printf(&crd.pb, "no matches -- nothing removed\n");
-	else if (crd.flags & RM_FLAG_VERBOSE) {
-		ret = para_printf(&crd.pb, "removed %u files\n",
-			pmd.num_matches);
-	}
-	if (ret >= 0 && crd.pb.offset)
-		pass_buffer_as_shm(fd, SBD_OUTPUT, crd.pb.buf, crd.pb.offset);
-	free(crd.pb.buf);
+	if (ret < 0)
+		goto out;
+	if (pmd.num_matches == 0)
+		ret = -E_NO_MATCH;
+	else if (crd.flags & RM_FLAG_VERBOSE)
+		para_printf(&crd.pb, "removed %u file(s)\n", pmd.num_matches);
+out:
+	flush_and_free_pb(&crd.pb);
+	return ret;
 }
 
 /* TODO options: -r (recursive) */
@@ -2284,7 +2187,7 @@ int com_rm(struct command_context *cc)
 {
 	uint32_t flags = 0;
 	struct osl_object query = {.data = &flags, .size = sizeof(flags)};
-	int i, ret;
+	int i;
 
 	for (i = 1; i < cc->argc; i++) {
 		const char *arg = cc->argv[i];
@@ -2310,11 +2213,8 @@ int com_rm(struct command_context *cc)
 	}
 	if (i >= cc->argc)
 		return -E_AFT_SYNTAX;
-	ret = send_option_arg_callback_request(&query, cc->argc - i,
+	return send_option_arg_callback_request(&query, cc->argc - i,
 		cc->argv + i, com_rm_callback, afs_cb_result_handler, cc);
-	if (ret < 0)
-		send_strerror(cc, -ret);
-	return ret;
 }
 
 /**
@@ -2372,18 +2272,15 @@ static int copy_selector_info(__a_unused struct osl_table *table,
 	if (cad->flags & CPSI_FLAG_COPY_ATTRIBUTES)
 		target_afsi.attributes = cad->source_afsi.attributes;
 	save_afsi(&target_afsi, &target_afsi_obj); /* in-place update */
-	if (cad->flags & CPSI_FLAG_VERBOSE) {
-		ret = para_printf(&cad->pb, "copied afsi to %s\n", name);
-		if (ret < 0)
-			return ret;
-	}
+	if (cad->flags & CPSI_FLAG_VERBOSE)
+		para_printf(&cad->pb, "copied afsi to %s\n", name);
 	aced.aft_row = row;
 	aced.old_afsi = &old_afsi;
 	afs_event(AFSI_CHANGE, &cad->pb, &aced);
 	return 1;
 }
 
-static void com_cpsi_callback(int fd, const struct osl_object *query)
+static int com_cpsi_callback(int fd, const struct osl_object *query)
 {
 	struct cpsi_action_data cad = {
 		.flags = *(unsigned *)query->data,
@@ -2413,24 +2310,23 @@ static void com_cpsi_callback(int fd, const struct osl_object *query)
 	if (ret < 0)
 		goto out;
 	ret = for_each_matching_row(&pmd);
-out:
 	if (ret < 0)
-		para_printf(&cad.pb, "%s\n", para_strerror(-ret));
-	else if (pmd.num_matches > 0) {
+		goto out;
+	if (pmd.num_matches > 0) {
 		if (cad.flags & CPSI_FLAG_VERBOSE)
-			para_printf(&cad.pb, "copied requested afsi from %s "
-				"to %u files\n", source_path, pmd.num_matches);
+			para_printf(&cad.pb, "updated afsi of %u file(s)\n",
+				pmd.num_matches);
 	} else
-		para_printf(&cad.pb, "no matches - nothing copied\n");
-	if (cad.pb.offset)
-		pass_buffer_as_shm(fd, SBD_OUTPUT, cad.pb.buf, cad.pb.offset);
-	free(cad.pb.buf);
+		ret = -E_NO_MATCH;
+out:
+	flush_and_free_pb(&cad.pb);
+	return ret;
 }
 
 int com_cpsi(struct command_context *cc)
 {
 	unsigned flags = 0;
-	int i, ret;
+	int i;
 	struct osl_object options = {.data = &flags, .size = sizeof(flags)};
 
 	for (i = 1; i < cc->argc; i++) {
@@ -2471,11 +2367,8 @@ int com_cpsi(struct command_context *cc)
 		return -E_AFT_SYNTAX;
 	if (!(flags & ~CPSI_FLAG_VERBOSE)) /* no copy flags given */
 		flags = ~(unsigned)CPSI_FLAG_VERBOSE | flags;
-	ret = send_option_arg_callback_request(&options, cc->argc - i,
+	return send_option_arg_callback_request(&options, cc->argc - i,
 		cc->argv + i, com_cpsi_callback, afs_cb_result_handler, cc);
-	if (ret < 0)
-		send_strerror(cc, -ret);
-	return ret;
 }
 
 struct change_atts_data {
@@ -2509,7 +2402,7 @@ static int change_atts(__a_unused struct osl_table *table,
 	return 1;
 }
 
-static void com_setatt_callback(int fd, const struct osl_object *query)
+static int com_setatt_callback(int fd, const struct osl_object *query)
 {
 	char *p;
 	int ret;
@@ -2546,8 +2439,10 @@ static void com_setatt_callback(int fd, const struct osl_object *query)
 			break;
 		p[len - 1] = '\0';
 		ret = get_attribute_bitnum_by_name(p, &bitnum);
-		if (ret < 0)
+		if (ret < 0) {
+			para_printf(&cad.pb, "attribute not found: %s\n", p);
 			goto out;
+		}
 		if (c == '+')
 			cad.add_mask |= (1UL << bitnum);
 		else
@@ -2563,13 +2458,10 @@ static void com_setatt_callback(int fd, const struct osl_object *query)
 	if (ret < 0)
 		goto out;
 	if (pmd.num_matches == 0)
-		para_printf(&cad.pb, "no matches\n");
+		ret = -E_NO_MATCH;
 out:
-	if (ret < 0)
-		para_printf(&cad.pb, "%s\n", para_strerror(-ret));
-	if (cad.pb.offset)
-		pass_buffer_as_shm(fd, SBD_OUTPUT, cad.pb.buf, cad.pb.offset);
-	free(cad.pb.buf);
+	flush_and_free_pb(&cad.pb);
+	return ret;
 }
 
 int com_setatt(struct command_context *cc)
@@ -2580,15 +2472,15 @@ int com_setatt(struct command_context *cc)
 		com_setatt_callback, afs_cb_result_handler, cc);
 }
 
-static void afs_stat_callback(int fd, const struct osl_object *query)
+static int afs_stat_callback(int fd, const struct osl_object *query)
 {
 	int *parser_friendly = query->data;
 	char *buf = *parser_friendly?
 		parser_friendly_status_items : status_items;
 
 	if (!buf)
-		return;
-	pass_buffer_as_shm(fd, SBD_OUTPUT, buf, strlen(buf));
+		return 0;
+	return pass_buffer_as_shm(fd, SBD_OUTPUT, buf, strlen(buf));
 }
 
 /**
@@ -2614,7 +2506,7 @@ int send_afs_status(struct command_context *cc, int parser_friendly)
 		afs_cb_result_handler, cc);
 }
 
-/* TODO: optionally fix problems by removing offending rows */
+/* returns success even on errors to keep the loop going */
 static int check_audio_file(struct osl_row *row, void *data)
 {
 	char *path;
@@ -2624,34 +2516,28 @@ static int check_audio_file(struct osl_row *row, void *data)
 	struct afs_info afsi;
 	char *blob_name;
 
-	if (ret < 0)
-		return para_printf(pb, "%s\n", para_strerror(-ret));
-	if (stat(path, &statbuf) < 0) {
-		ret = para_printf(pb, "%s: stat error (%s)\n", path, strerror(errno));
-		if (ret < 0)
-			return ret;
-	} else {
-		if (!S_ISREG(statbuf.st_mode)) {
-			ret = para_printf(pb, "%s: not a regular file\n", path);
-			if (ret < 0)
-				return ret;
-		}
+	if (ret < 0) {
+		para_printf(pb, "%s\n", para_strerror(-ret));
+		return 0;
 	}
+	if (stat(path, &statbuf) < 0)
+		para_printf(pb, "%s: stat error (%s)\n", path, strerror(errno));
+	else if (!S_ISREG(statbuf.st_mode))
+		para_printf(pb, "%s: not a regular file\n", path);
 	ret = get_afsi_of_row(row, &afsi);
-	if (ret < 0)
-		return para_printf(pb, "%s: %s\n", path, para_strerror(-ret));
-	ret = lyr_get_name_by_id(afsi.lyrics_id, &blob_name);
 	if (ret < 0) {
-		ret = para_printf(pb, "%s lyrics id %u: %s\n", path, afsi.lyrics_id,
-			para_strerror(-ret));
-		if (ret < 0)
-			return ret;
+		para_printf(pb, "%s: %s\n", path, para_strerror(-ret));
+		return 1;
 	}
+	ret = lyr_get_name_by_id(afsi.lyrics_id, &blob_name);
+	if (ret < 0)
+		para_printf(pb, "%s lyrics id %u: %s\n", path, afsi.lyrics_id,
+			para_strerror(-ret));
 	ret = img_get_name_by_id(afsi.image_id, &blob_name);
 	if (ret < 0)
-		ret = para_printf(pb, "%s image id %u: %s\n", path, afsi.image_id,
+		para_printf(pb, "%s image id %u: %s\n", path, afsi.image_id,
 			para_strerror(-ret));
-	return ret;
+	return 0;
 }
 
 /**
@@ -2660,11 +2546,11 @@ static int check_audio_file(struct osl_row *row, void *data)
  * \param fd The afs socket.
  * \param query Unused.
  *
- * This function always succeeds.
+ * \return This function always returns zero.
  *
  * \sa com_check().
  */
-void aft_check_callback(int fd, __a_unused const struct osl_object *query)
+int aft_check_callback(int fd, __a_unused const struct osl_object *query)
 {
 	struct para_buffer pb = {
 		.max_size = shm_get_shmmax(),
@@ -2674,14 +2560,10 @@ void aft_check_callback(int fd, __a_unused const struct osl_object *query)
 		},
 		.max_size_handler = afs_max_size_handler
 	};
-	int ret = para_printf(&pb, "checking audio file table...\n");
-
-	if (ret < 0)
-		return;
+	para_printf(&pb, "checking audio file table...\n");
 	audio_file_loop(&pb, check_audio_file);
-	if (pb.offset)
-		pass_buffer_as_shm(fd, SBD_OUTPUT, pb.buf, pb.offset);
-	free(pb.buf);
+	flush_and_free_pb(&pb);
+	return 0;
 }
 
 /**
@@ -2718,9 +2600,9 @@ static int aft_open(const char *dir)
 		PARA_INFO_LOG("audio file table contains %d files\n", num);
 		return ret;
 	}
-	PARA_INFO_LOG("failed to open audio file table\n");
+	PARA_NOTICE_LOG("failed to open audio file table\n");
 	audio_file_table = NULL;
-	if (ret >= 0 || ret == -OSL_ERRNO_TO_PARA_ERROR(E_OSL_NOENT))
+	if (ret == -OSL_ERRNO_TO_PARA_ERROR(E_OSL_NOENT))
 		return 1;
 	return ret;
 }
@@ -2757,11 +2639,9 @@ static int aft_event_handler(enum afs_events event, struct para_buffer *pb,
 	switch (event) {
 	case ATTRIBUTE_REMOVE: {
 		const struct rmatt_event_data *red = data;
-		ret = para_printf(pb, "clearing attribute %s (bit %u) from all "
+		para_printf(pb, "clearing attribute %s (bit %u) from all "
 			"entries in the audio file table\n", red->name,
 			red->bitnum);
-		if (ret < 0)
-			return ret;
 		return audio_file_loop(data, clear_attribute);
 	} case AFSI_CHANGE: {
 		struct afsi_change_event_data *aced = data;