X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=alsa_write.c;h=04a94f733aef71df6da073bfea868a47f258b32c;hp=2e096c0c78856e6d0691f31c5fcba768ab3a695d;hb=74c88020bd325865fe26ed25ea8ad0ace0924136;hpb=b66dfd41e268e64b65d2990bdec3d3a7e119e234

diff --git a/alsa_write.c b/alsa_write.c
index 2e096c0c..04a94f73 100644
--- a/alsa_write.c
+++ b/alsa_write.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2012 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2013 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -15,7 +15,6 @@
 #include <regex.h>
 #include <sys/types.h>
 #include <alsa/asoundlib.h>
-#include <sys/time.h>
 
 #include "para.h"
 #include "fd.h"
@@ -236,7 +235,7 @@ static void alsa_close(struct writer_node *wn)
 	free(pad);
 }
 
-static void alsa_write_post_select(__a_unused struct sched *s,
+static int alsa_write_post_select(__a_unused struct sched *s,
 		struct task *t)
 {
 	struct writer_node *wn = container_of(t, struct writer_node, task);
@@ -247,11 +246,13 @@ static void alsa_write_post_select(__a_unused struct sched *s,
 	snd_pcm_sframes_t frames;
 	int ret;
 
+	ret = task_get_notification(t);
+	if (ret < 0)
+		goto err;
 again:
-	t->error = 0;
 	ret = btr_node_status(btrn, wn->min_iqs, BTR_NT_LEAF);
 	if (ret == 0)
-		return;
+		return 0;
 	btr_merge(btrn, wn->min_iqs);
 	bytes = btr_next_buffer(btrn, &data);
 	if (ret < 0 || bytes < wn->min_iqs) { /* eof */
@@ -264,17 +265,17 @@ again:
 			PARA_DEBUG_LOG("waiting for device to drain\n");
 			tv_add(now, &(struct timeval)EMBRACE(0, 200 * 1000),
 				&pad->drain_barrier);
-			return;
+			return 0;
 		}
 		if (tv_diff(now, &pad->drain_barrier, NULL) > 0)
 			goto err;
-		return;
+		return 0;
 	}
 	if (!pad) {
 		int32_t val;
 
 		if (bytes == 0) /* no data available */
-			return;
+			return 0;
 		pad = para_calloc(sizeof(*pad));
 		get_btr_sample_rate(btrn, &val);
 		pad->sample_rate = val;
@@ -295,7 +296,7 @@ again:
 		goto again;
 	}
 	if (pad->poll_fd < 0 || !FD_ISSET(pad->poll_fd, &s->rfds))
-		return;
+		return 0;
 	frames = bytes / pad->bytes_per_frame;
 	frames = snd_pcm_writei(pad->handle, data, frames);
 	if (frames == 0 || frames == -EAGAIN) {
@@ -309,7 +310,7 @@ again:
 		char buf[100];
 		if (read(pad->poll_fd, buf, 100))
 			do_nothing;
-		return;
+		return 0;
 	}
 	if (frames > 0) {
 		btr_consume(btrn, frames * pad->bytes_per_frame);
@@ -318,28 +319,28 @@ again:
 	if (frames == -EPIPE) {
 		PARA_WARNING_LOG("underrun (tried to write %zu bytes)\n", bytes);
 		snd_pcm_prepare(pad->handle);
-		return;
+		return 0;
 	}
 	PARA_ERROR_LOG("alsa write error: %s\n", snd_strerror(-frames));
 	ret = -E_ALSA;
 err:
 	assert(ret < 0);
 	btr_remove_node(&wn->btrn);
-	t->error = ret;
+	return ret;
 }
 
-__malloc static void *alsa_parse_config_or_die(const char *options)
+__malloc static void *alsa_parse_config_or_die(int argc, char **argv)
 {
 	struct alsa_write_args_info *conf = para_calloc(sizeof(*conf));
 
 	/* exits on errors */
-	alsa_cmdline_parser_string(options, conf, "alsa_write");
+	alsa_write_cmdline_parser(argc, argv, conf);
 	return conf;
 }
 
 static void alsa_free_config(void *conf)
 {
-	alsa_cmdline_parser_free(conf);
+	alsa_write_cmdline_parser_free(conf);
 }
 
 /**
@@ -353,15 +354,15 @@ void alsa_write_init(struct writer *w)
 {
 	struct alsa_write_args_info dummy;
 
-	alsa_cmdline_parser_init(&dummy);
+	alsa_write_cmdline_parser_init(&dummy);
 	w->close = alsa_close;
 	w->pre_select = alsa_write_pre_select;
-	w->post_select = alsa_write_post_select;
+	w->new_post_select = alsa_write_post_select;
 	w->parse_config_or_die = alsa_parse_config_or_die;
 	w->free_config = alsa_free_config;
 	w->help = (struct ggo_help) {
 		.short_help = alsa_write_args_info_help,
 		.detailed_help = alsa_write_args_info_detailed_help
 	};
-	alsa_cmdline_parser_free(&dummy);
+	alsa_write_cmdline_parser_free(&dummy);
 }