X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=alsa_write.c;h=5965159ed9e50af87401f4f2968d7155439bb568;hp=0bad21992c2537f41201a36499b5cf9129b0255e;hb=b4ed16eddb2433f002139ad1e133427b77814d43;hpb=e4426bc694c60ba5aade50fd7161251be33dc16a

diff --git a/alsa_write.c b/alsa_write.c
index 0bad2199..5965159e 100644
--- a/alsa_write.c
+++ b/alsa_write.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2010 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2011 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -14,7 +14,6 @@
 
 #include <regex.h>
 #include <sys/types.h>
-#include <dirent.h>
 #include <alsa/asoundlib.h>
 #include <sys/time.h>
 #include <stdbool.h>
@@ -35,7 +34,7 @@
 struct private_alsa_write_data {
 	/** The alsa handle */
 	snd_pcm_t *handle;
-	/** Determined and set by alsa_open(). */
+	/** Determined and set by alsa_init(). */
 	int bytes_per_frame;
 	/** The approximate maximum buffer duration in us. */
 	unsigned buffer_time;
@@ -142,23 +141,23 @@ static int alsa_init(struct private_alsa_write_data *pad,
 	return 1;
 }
 
-/* Open an instance of the alsa writer. */
-static void alsa_open(__a_unused struct writer_node *wn)
-{
-}
-
 static void alsa_write_pre_select(struct sched *s, struct task *t)
 {
 	struct writer_node *wn = container_of(t, struct writer_node, task);
 	struct private_alsa_write_data *pad = wn->private_data;
-	struct timeval tv;
 	snd_pcm_sframes_t avail, underrun;
 	int ret = btr_node_status(wn->btrn, wn->min_iqs, BTR_NT_LEAF);
 
 	if (ret == 0)
 		return;
-	if (ret < 0 || !pad)
-		return sched_min_delay(s);
+	if (!pad) {
+		sched_min_delay(s);
+		return;
+	}
+	if (ret < 0) {
+		sched_request_barrier_or_min_delay(&pad->drain_barrier, s);
+		return;
+	}
 	/*
 	 * Data is available to be written to the alsa handle.  Compute number
 	 * of milliseconds until next buffer underrun would occur.
@@ -177,8 +176,7 @@ static void alsa_write_pre_select(struct sched *s, struct task *t)
 	if (underrun < 50)
 		underrun = 50;
 	underrun -= 50;
-	ms2tv(underrun, &tv);
-	sched_request_timeout(&tv, s);
+	sched_request_timeout_ms(underrun, s);
 }
 
 static void alsa_close(struct writer_node *wn)
@@ -219,7 +217,7 @@ again:
 	bytes = btr_next_buffer(btrn, &data);
 	if (ret < 0 || bytes < wn->min_iqs) { /* eof */
 		assert(btr_no_parent(btrn));
-		ret = -E_ALSA_EOF;
+		ret = -E_WRITE_COMMON_EOF;
 		if (!pad)
 			goto err;
 		/* wait until pending frames are played */
@@ -236,10 +234,9 @@ again:
 	if (!pad) {
 		int32_t val;
 
-		pad = para_calloc(sizeof(*pad));
-		wn->private_data = pad;
 		if (bytes == 0) /* no data available */
 			return;
+		pad = para_calloc(sizeof(*pad));
 		get_btr_sample_rate(btrn, &val);
 		pad->sample_rate = val;
 		get_btr_channels(btrn, &val);
@@ -250,14 +247,19 @@ again:
 		PARA_INFO_LOG("%d channel(s), %dHz\n", pad->channels,
 			pad->sample_rate);
 		ret = alsa_init(pad, wn->conf);
-		if (ret < 0)
+		if (ret < 0) {
+			free(pad);
 			goto err;
+		}
+		wn->private_data = pad;
 		wn->min_iqs = pad->bytes_per_frame;
 		goto again;
 	}
 	frames = bytes / pad->bytes_per_frame;
 	frames = snd_pcm_writei(pad->handle, data, frames);
-	if (frames >= 0) {
+	if (frames == 0 || frames == -EAGAIN)
+		return;
+	if (frames > 0) {
 		btr_consume(btrn, frames * pad->bytes_per_frame);
 		goto again;
 	}
@@ -266,8 +268,6 @@ again:
 		snd_pcm_prepare(pad->handle);
 		return;
 	}
-	if (frames == -EAGAIN)
-		return;
 	PARA_WARNING_LOG("%s\n", snd_strerror(-frames));
 	ret = -E_ALSA_WRITE;
 err:
@@ -280,7 +280,6 @@ __malloc static void *alsa_parse_config_or_die(const char *options)
 {
 	struct alsa_write_args_info *conf = para_calloc(sizeof(*conf));
 
-	PARA_INFO_LOG("options: %s, %zd\n", options, strcspn(options, " \t"));
 	/* exits on errors */
 	alsa_cmdline_parser_string(options, conf, "alsa_write");
 	return conf;
@@ -303,7 +302,6 @@ void alsa_write_init(struct writer *w)
 	struct alsa_write_args_info dummy;
 
 	alsa_cmdline_parser_init(&dummy);
-	w->open = alsa_open;
 	w->close = alsa_close;
 	w->pre_select = alsa_write_pre_select;
 	w->post_select = alsa_write_post_select;