X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=alsa_write.c;h=8e3688faad4719c39b5819fb738cac1578323eee;hp=67c845d3957c6cde30929b2b045569097a38941d;hb=e2c65e016f5fb330e0360a6fcea60b6ded845460;hpb=d0f36435b0f81368a778fda33f3a7df86830f5ac

diff --git a/alsa_write.c b/alsa_write.c
index 67c845d3..8e3688fa 100644
--- a/alsa_write.c
+++ b/alsa_write.c
@@ -66,6 +66,7 @@ static int alsa_init(struct private_alsa_write_data *pad,
 	snd_pcm_uframes_t period_size;
 	int err;
 
+	PARA_INFO_LOG("opening %s\n", conf->device_arg);
 	err = snd_pcm_open(&pad->handle, conf->device_arg,
 		SND_PCM_STREAM_PLAYBACK, SND_PCM_NONBLOCK);
 	if (err < 0)
@@ -152,7 +153,6 @@ static int alsa_open_btr(struct writer_node *wn)
 {
 	struct private_alsa_write_data *pad = para_calloc(sizeof(*pad));
 
-	sprintf(wn->task.status, "alsa writer");
 	wn->private_data = pad;
 	return 1;
 }
@@ -173,7 +173,7 @@ static int alsa_write_pre_select(struct sched *s, struct writer_node *wn)
 	if (!pad->handle)
 		return 1;
 	if (wn->btrn) {
-		int ret = btr_node_status(wn->btrn, wn->min_iqs);
+		int ret = btr_node_status(wn->btrn, wn->min_iqs, BTR_NT_LEAF);
 		if (ret == 0)
 			return 1;
 		if (ret < 0) {
@@ -291,7 +291,6 @@ static void alsa_close(struct writer_node *wn)
 		snd_pcm_close(pad->handle);
 		snd_config_update_free_global();
 	}
-	alsa_cmdline_parser_free(wn->conf);
 	free(pad);
 }
 
@@ -308,12 +307,12 @@ static void alsa_write_post_select_btr(__a_unused struct sched *s,
 
 again:
 	t->error = 0;
-	ret = btr_node_status(btrn, wn->min_iqs);
+	ret = btr_node_status(btrn, wn->min_iqs, BTR_NT_LEAF);
 	if (ret == 0)
 		return;
 	btr_merge(btrn, wn->min_iqs);
 	bytes = btr_next_buffer(btrn, &data);
-	if (bytes < pad->bytes_per_frame) { /* eof */
+	if (ret < 0 || bytes < pad->bytes_per_frame) { /* eof */
 		assert(btr_no_parent(btrn));
 		ret = -E_ALSA_EOF;
 		if (!pad->handle)
@@ -322,44 +321,29 @@ again:
 		avail = snd_pcm_avail_update(pad->handle);
 		if (avail + 1000 > pad->buffer_frames)
 			goto err;
+		PARA_DEBUG_LOG("waiting for device to drain\n");
 		return;
 	}
 	if (!pad->handle) {
-		char *buf;
 		struct alsa_write_args_info *conf = wn->conf;
 		if (bytes == 0) /* no data available */
 			return;
-		PARA_CRIT_LOG("alsa init\n");
 		/* defaults */
 		pad->samplerate = conf->samplerate_arg;
 		pad->channels = conf->channels_arg;
 		if (!conf->samplerate_given) { /* config option trumps btr_exec */
-			/* ask parent btr nodes */
-			buf = NULL;
-			ret = btr_exec_up(btrn, "samplerate", &buf);
-			PARA_CRIT_LOG("ret: %d\n", ret);
-			if (ret >= 0) {
-				int32_t rate;
-
-				ret = para_atoi32(buf, &rate);
-				free(buf);
-				if (ret < 0) /* should not happen */
-					goto err;
-				pad->samplerate = rate;
-			}
+			int32_t rate;
+			ret = get_btr_samplerate(btrn, &rate);
+			if (ret < 0)
+				goto err;
+			pad->samplerate = rate;
 		}
 		if (!conf->channels_given) {
-			buf = NULL;
-			ret = btr_exec_up(btrn, "channels", &buf);
-			if (ret >= 0) {
-				int32_t ch;
-
-				ret = para_atoi32(buf, &ch);
-				freep(&buf);
-				if (ret < 0)
-					goto err;
-				pad->channels = ch;
-			}
+			int32_t ch;
+			ret = get_btr_channels(btrn, &ch);
+			if (ret < 0)
+				goto err;
+			pad->channels = ch;
 		}
 		PARA_INFO_LOG("%d channel(s), %dHz\n", pad->channels, pad->samplerate);
 		ret = 1;
@@ -410,12 +394,17 @@ err_out:
 	return NULL;
 }
 
+static void alsa_free_config(void *conf)
+{
+	alsa_cmdline_parser_free(conf);
+}
+
 /**
- * the init function of the alsa writer
+ * The init function of the alsa writer.
  *
- * \param w pointer to the writer to initialize
+ * \param w Pointer to the writer to initialize.
  *
- * \sa struct writer
+ * \sa \ref struct writer.
  */
 void alsa_write_init(struct writer *w)
 {
@@ -430,6 +419,7 @@ void alsa_write_init(struct writer *w)
 	w->post_select_btr = alsa_write_post_select_btr;
 	w->parse_config = alsa_parse_config;
 	w->shutdown = NULL; /* nothing to do */
+	w->free_config = alsa_free_config;
 	w->help = (struct ggo_help) {
 		.short_help = alsa_write_args_info_help,
 		.detailed_help = alsa_write_args_info_detailed_help