X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=amp_filter.c;h=f62ea8a2f50962182e158ce8da7f18fb4ec1df4f;hp=9484966380a3610a8a0bab0a7eeef4bc67f9a21f;hb=5cb5db1fbf8f9b96c3b5a1e0cc7de9e710757540;hpb=3879481ddabc38236b9eee979a090c2a9bfa74d3

diff --git a/amp_filter.c b/amp_filter.c
index 94849663..f62ea8a2 100644
--- a/amp_filter.c
+++ b/amp_filter.c
@@ -22,7 +22,6 @@ extern char *stat_item_values[NUM_STAT_ITEMS];
 
 /** Data specific to the amplify filter. */
 struct private_amp_data {
-	/** Points to the configuration data for this instance of this filter. */
 	/** Amplification factor. */
 	unsigned amp;
 };
@@ -63,7 +62,7 @@ static void amp_open(struct filter_node *fn)
 		pad->amp, pad->amp / 64.0 + 1.0);
 }
 
-static void amp_post_select(__a_unused struct sched *s, struct task *t)
+static int amp_post_select(__a_unused struct sched *s, struct task *t)
 {
 	struct filter_node *fn = container_of(t, struct filter_node, task);
 	struct private_amp_data *pad = fn->private_data;
@@ -74,16 +73,15 @@ static void amp_post_select(__a_unused struct sched *s, struct task *t)
 	bool inplace = btr_inplace_ok(btrn);
 
 	if (pad->amp == 0) { /* no amplification */
-		t->error = -E_AMP_ZERO_AMP;
 		btr_splice_out_node(btrn);
-		return;
+		return -E_AMP_ZERO_AMP;
 	}
 next_buffer:
 	ret = btr_node_status(btrn, fn->min_iqs, BTR_NT_INTERNAL);
 	if (ret < 0)
 		goto err;
 	if (ret == 0)
-		return;
+		return 0;
 	btr_merge(btrn, fn->min_iqs);
 	in_bytes = btr_next_buffer(btrn, (char **)&in);
 	len = in_bytes / 2;
@@ -111,12 +109,11 @@ next_buffer:
 		btr_consume(btrn, len * 2);
 		btr_add_output((char *)out, len * 2, btrn);
 	}
-	t->error = 0;
 	goto next_buffer;
 err:
 	assert(ret < 0);
-	t->error = ret;
 	btr_remove_node(&fn->btrn);
+	return ret;
 }
 
 static void amp_free_config(void *conf)
@@ -140,8 +137,5 @@ void amp_filter_init(struct filter *f)
 	f->post_select = amp_post_select;
 	f->parse_config = amp_parse_config;
 	f->free_config = amp_free_config;
-	f->help = (struct ggo_help) {
-		.short_help = amp_filter_args_info_help,
-		.detailed_help = amp_filter_args_info_detailed_help
-	};
+	f->help = (struct ggo_help)DEFINE_GGO_HELP(amp_filter);
 }