X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=attribute.c;h=b130ab2989a0a3f0e439fe4942d9cdb5387da7a7;hp=48f108c7fe8be8a96ac6b4d77b7d7737bb46db1c;hb=e63886e85c55c99e9732e5715b7ce641eff09914;hpb=53d503ce75eb1d9439cfb75053d3cff4cbca6ff9;ds=sidebyside

diff --git a/attribute.c b/attribute.c
index 48f108c7..b130ab29 100644
--- a/attribute.c
+++ b/attribute.c
@@ -281,23 +281,6 @@ int com_setatt(__a_unused int fd, int argc, char * const * const argv)
 		NULL);
 }
 
-/* TODO: make it faster by only extracting the attribute member from afsi */
-static int logical_and_attribute(struct osl_row *aft_row, void *attribute_ptr)
-{
-	struct afs_info afsi;
-	uint64_t *att = attribute_ptr;
-	struct osl_object obj;
-	int ret = get_afsi_object_of_row(aft_row, &obj);
-	if (ret < 0)
-		return ret;
-	ret = load_afsi(&afsi, &obj);
-	if (ret < 0)
-		return ret;
-	afsi.attributes &= *att;
-	save_afsi(&afsi, &obj);
-	return 1;
-}
-
 static int com_addatt_callback(const struct osl_object *query,
 		struct osl_object *result)
 {
@@ -311,6 +294,7 @@ static int com_addatt_callback(const struct osl_object *query,
 		struct osl_row *row;
 		unsigned char bitnum;
 		len = strlen(p);
+		struct addatt_event_data aed;
 
 		if (!len || p[len - 1] == '-' || p[len - 1] == '+') {
 			para_printf(&pb, "invalid attribute name: %s\n", p);
@@ -320,14 +304,14 @@ static int com_addatt_callback(const struct osl_object *query,
 		objs[ATTCOL_NAME].data = p;
 		objs[ATTCOL_NAME].size = len + 1;
 		ret = osl_get_row(attribute_table, ATTCOL_NAME,
-			&objs[ATTCOL_NAME], &row); /* expected to fail */
+			&objs[ATTCOL_NAME], &row); /* expected to fail FIXME: Use get_attribute_bitnum_by_name() */
 		if (ret >= 0) {
 			para_printf(&pb, "attribute %s already exists\n", p);
 			continue;
 		}
 		if (ret != -E_RB_KEY_NOT_FOUND) /* error */
 			goto out;
-		/* find smallest non-used attribute */
+		/* find smallest non-used attribute FIXME: Use find_greatest_att_bitnum() */
 		for (bitnum = 0; bitnum < 64; bitnum++) {
 			objs[ATTCOL_BITNUM].data = &bitnum;
 			ret = osl_get_row(attribute_table, ATTCOL_BITNUM,
@@ -345,6 +329,9 @@ static int com_addatt_callback(const struct osl_object *query,
 		ret = osl_add_row(attribute_table, objs);
 		if (ret < 0)
 			goto out;
+		aed.name = p;
+		aed.bitnum = bitnum;
+		afs_event(ATTRIBUTE_ADD, &pb, &aed);
 		greatest_att_bitnum = PARA_MAX(greatest_att_bitnum, bitnum);
 	}
 out:
@@ -375,6 +362,56 @@ int com_addatt(int fd, int argc, char * const * const argv)
 	return ret;
 }
 
+static int com_mvatt_callback(const struct osl_object *query,
+		struct osl_object *result)
+{
+	char *old = query->data;
+	size_t size = strlen(old) + 1;
+	char *new = old + size;
+	struct osl_object obj = {.data = old, .size = size};
+	struct osl_row *row;
+	struct para_buffer pb = {.size = 0};
+	int ret;
+
+	ret = osl_get_row(attribute_table, ATTCOL_NAME, &obj, &row);
+	if (ret < 0)
+		goto out;
+	obj.data = new;
+	obj.size = strlen(new) + 1;
+	ret = osl_update_object(attribute_table, row, ATTCOL_NAME, &obj);
+out:
+	if (ret < 0)
+		para_printf(&pb, "%s\n", PARA_STRERROR(-ret));
+	else
+		afs_event(ATTRIBUTE_RENAME, &pb, NULL);
+	if (!pb.buf)
+		return 0;
+	result->data = pb.buf;
+	result->size = pb.size;
+	return 1;
+}
+
+int com_mvatt(int fd, int argc, char * const * const argv)
+{
+	struct osl_object result;
+	int ret;
+
+	if (argc != 3)
+		return -E_ATTR_SYNTAX;
+	ret = send_standard_callback_request(argc - 1, argv + 1, com_mvatt_callback,
+		&result);
+	if (!ret)
+		return 1;
+	if (ret < 0)
+		return ret;
+	if (!result.data || !result.size)
+		return 1;
+	ret =  send_va_buffer(fd, "%s", (char *) result.data);
+	free(result.data);
+	return ret;
+}
+
+
 struct remove_attribute_action_data {
 	struct para_buffer pb;
 	int num_removed;
@@ -385,10 +422,10 @@ static int remove_attribute(struct osl_table *table, struct osl_row *row,
 		const char *name, void *data)
 {
 	struct remove_attribute_action_data *raad = data;
-	unsigned char bitnum;
 	int ret;
+	struct rmatt_event_data red = {.name = name};
 
-	ret = get_attribute_bitnum_by_name(name, &bitnum);
+	ret = get_attribute_bitnum_by_name(name, &red.bitnum);
 	if (ret < 0) {
 		para_printf(&raad->pb, "%s: %s\n", name, PARA_STRERROR(-ret));
 		return 1;
@@ -398,9 +435,10 @@ static int remove_attribute(struct osl_table *table, struct osl_row *row,
 		para_printf(&raad->pb, "%s: %s\n", name, PARA_STRERROR(-ret));
 		return 1;
 	}
-	para_printf(&raad->pb, "removed %s\n", name);
+	para_printf(&raad->pb, "removed attribute %s\n", name);
 	raad->num_removed++;
-	raad->mask_of_removed_atts |= (1 << bitnum);
+	raad->mask_of_removed_atts |= (1 << red.bitnum);
+	afs_event(ATTRIBUTE_REMOVE, &raad->pb, &red);
 	return 1;
 }
 
@@ -420,17 +458,7 @@ static int com_rmatt_callback(const struct osl_object *query,
 	ret = for_each_matching_row(&pmd);
 	if (ret < 0)
 		para_printf(&raad.pb, "%s\n", PARA_STRERROR(-ret));
-	if (raad.num_removed) {
-		uint64_t and_mask = ~raad.mask_of_removed_atts;
-		ret = audio_file_loop(&and_mask, logical_and_attribute);
-		if (ret < 0)
-			para_printf(&raad.pb, "%s\n", PARA_STRERROR(-ret));
-		find_greatest_att_bitnum();
-		ret = reload_current_mood();
-		if (ret < 0)
-			para_printf(&raad.pb, "%s\n", PARA_STRERROR(-ret));
-	}
-	if (!raad.pb.buf)
+	if (!raad.num_removed)
 		para_printf(&raad.pb, "no match -- nothing removed\n");
 	result->data = raad.pb.buf;
 	result->size = raad.pb.size;
@@ -455,7 +483,7 @@ int com_rmatt(int fd, int argc, char * const * const argv)
 }
 
 /**
- * Return a binary representation of the geiven attribute value.
+ * Return a binary representation of the given attribute value.
  *
  * \param atts Pointer to the attribute value.
  * \param buf Result.