X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=attribute.c;h=d74ec92839c2c3753ebadf1caf2a06d2f109645e;hp=8c1f5c535e5b42460b1b4a0fe41fb426b16cc3cb;hb=cad509560a006cd443b0d004793a018d82c17a7d;hpb=fd5f94274de04e4dfed9bea8aadac661262d7cca

diff --git a/attribute.c b/attribute.c
index 8c1f5c53..d74ec928 100644
--- a/attribute.c
+++ b/attribute.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 1997-2013 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 1997 Andre Noll <maan@tuebingen.mpg.de>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -162,7 +162,7 @@ static void com_lsatt_callback(int fd, const struct osl_object *query)
 	};
 	struct pattern_match_data pmd = {
 		.table = attribute_table,
-		.loop_col_num = ATTCOL_BITNUM,
+		.loop_col_num = ATTCOL_NAME,
 		.match_col_num = ATTCOL_NAME,
 		.patterns = {.data = (char *)query->data + sizeof(laad.flags),
 			.size = query->size - sizeof(laad.flags)},
@@ -171,7 +171,7 @@ static void com_lsatt_callback(int fd, const struct osl_object *query)
 		.action = print_attribute
 	};
 	if (laad.flags & LSATT_FLAG_SORT_BY_ID)
-		pmd.loop_col_num = ATTCOL_NAME;
+		pmd.loop_col_num = ATTCOL_BITNUM;
 	if (laad.flags & LSATT_FLAG_REVERSE)
 		pmd.pm_flags |= PM_REVERSE_LOOP;
 	for_each_matching_row(&pmd);
@@ -212,10 +212,7 @@ int com_lsatt(struct command_context *cc)
 	if (ret < 0)
 		send_strerror(cc, -ret);
 	else if (ret == 0 && cc->argc > 1)
-		ret = cc->use_sideband?
-			send_sb_va(&cc->scc, SBD_ERROR_LOG, "no matches\n")
-		:
-			sc_send_va_buffer(&cc->scc, "no matches\n");
+		ret = send_sb_va(&cc->scc, SBD_ERROR_LOG, "no matches\n");
 	return ret;
 }
 
@@ -358,7 +355,7 @@ int com_mvatt(struct command_context *cc)
 struct remove_attribute_action_data {
 	/** Message buffer. */
 	struct para_buffer pb;
-	/** Numver of attributes removed. */
+	/** Number of attributes removed. */
 	int num_removed;
 	/** Bitwise "or" of the removed attributes. */
 	uint64_t mask_of_removed_atts;
@@ -441,7 +438,7 @@ int com_rmatt(struct command_context *cc)
  * used for unset attributes.
  *
  * In practice, not all 64 attributes are defined. In this case, the function
- * only prints \a N + 1 charaters where \a N is the greatest id of a defined
+ * only prints \a N + 1 characters where \a N is the greatest id of a defined
  * attribute.
  */
 void get_attribute_bitmap(const uint64_t *atts, char *buf)
@@ -534,7 +531,7 @@ static int attribute_open(const char *dir)
 		return ret;
 	}
 	attribute_table = NULL;
-	if (ret >= 0 || ret == -OSL_ERRNO_TO_PARA_ERROR(E_OSL_NOENT))
+	if (ret == -OSL_ERRNO_TO_PARA_ERROR(E_OSL_NOENT))
 		return 1;
 	return ret;
 }