X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=audiod.c;h=61711dc3f5591d9396ebe62496871404834dea47;hp=7029ea9116f9c115a5c4d5d41599fcd414ea930e;hb=89cde2c587229f04d779e3a387c4a801261d87f0;hpb=5fde5b4d4abeb795f71101d1fd3524f8a27971eb

diff --git a/audiod.c b/audiod.c
index 7029ea91..61711dc3 100644
--- a/audiod.c
+++ b/audiod.c
@@ -609,17 +609,14 @@ __malloc static char *glob_cmd(char *cmd)
 	else
 		tv_diff(&server_stream_start, &sa_time_diff, &rss);
 	tv_add(&rss, &delay, &tmp);
-	replacement = make_message("%lu:%lu", tmp.tv_sec, tmp.tv_usec);
+	replacement = make_message("%lu:%lu",
+		(long unsigned)tmp.tv_sec,
+		(long unsigned)tmp.tv_usec);
 	ret = s_a_r(cmd, "STREAM_START", replacement);
 	free(replacement);
 	if (!ret)
 		goto out;
 	PARA_INFO_LOG("cmd: %s, repl: %s\n", cmd, ret);
-	{
-	struct timeval now;
-	gettimeofday(&now, NULL);
-	PARA_INFO_LOG("now: %lu:%lu\n", now.tv_sec, now.tv_usec);
-	}
 out:
 	return ret;
 }
@@ -699,7 +696,7 @@ static void start_stream_writer(int slot_num)
 	if (a->write_cmd)
 		glob = glob_cmd(a->write_cmd);
 	if (!glob)
-		glob = para_strdup("para_play");
+		glob = para_strdup("para_write -w alsa");
 	PARA_INFO_LOG("starting stream writer: %s\n", glob);
 	open_filters(slot_num);
 	ret = para_exec_cmdline_pid(&s->wpid, glob, fds);
@@ -797,20 +794,22 @@ static void compute_time_diff(const struct timeval *status_time)
 		count > 10? sign : sign * time_smooth, &diff,
 		&tmp);
 	sa_time_diff = tmp;
-	PARA_INFO_LOG("time diff (cur/avg): "
-		"%li:%lu/%li:%lu\n",
-		sign * diff.tv_sec, (diff.tv_usec + 500) / 1000,
-		sa_time_diff_sign * sa_time_diff.tv_sec,
-		(sa_time_diff.tv_usec + 500)/ 1000);
+	PARA_INFO_LOG("time diff (cur/avg): %s%lums/%s%lums\n",
+		sign > 0? "+" : "-",
+		tv2ms(&diff),
+		sa_time_diff_sign ? "+" : "-",
+		tv2ms(&sa_time_diff)
+	);
 }
 
 static void check_stat_line(char *line)
 {
 	int itemnum;
 	size_t ilen = 0;
-	struct timeval tv;
+	long unsigned sec, usec;
 	char *tmp;
 
+	PARA_INFO_LOG("line: %s\n", line);
 	if (!line)
 		return;
 	itemnum = stat_line_valid(line);
@@ -839,14 +838,16 @@ static void check_stat_line(char *line)
 		length_seconds = atoi(line + ilen + 1);
 		break;
 	case SI_STREAM_START:
-		if (sscanf(line + ilen + 1, "%lu.%lu",
-				&tv.tv_sec, &tv.tv_usec) == 2)
-			server_stream_start = tv;
+		if (sscanf(line + ilen + 1, "%lu.%lu", &sec, &usec) == 2) {
+			server_stream_start.tv_sec = sec;
+			server_stream_start.tv_usec = usec;
+		}
 		break;
 	case SI_CURRENT_TIME:
-		if (sscanf(line + ilen + 1, "%lu.%lu", &tv.tv_sec,
-				&tv.tv_usec) == 2)
+		if (sscanf(line + ilen + 1, "%lu.%lu", &sec, &usec) == 2) {
+			struct timeval tv = {sec, usec};
 			compute_time_diff(&tv);
+		}
 		break;
 	}
 }
@@ -1107,7 +1108,7 @@ out:
 
 static int init_stream_io(void)
 {
-	int i, ret, receiver_num;
+	int i, ret, receiver_num, nf;
 	char *cmd;
 
 	for (i = 0; i < conf.stream_write_cmd_given; i++) {
@@ -1156,9 +1157,11 @@ static int init_stream_io(void)
 	free(cmd);
 	/* filters */
 	filter_init(filters);
+	nf = PARA_MAX(2,  conf.filter_given) + 1;
+	PARA_INFO_LOG("allocating space for %d filters\n", nf);
 	FOR_EACH_AUDIO_FORMAT(i) {
-		afi[i].filter_conf = para_malloc((conf.filter_given + 1) * sizeof(char *));
-		afi[i].filters = para_malloc((conf.filter_given + 1) * sizeof(struct filter *));
+		afi[i].filter_conf = para_malloc(nf * sizeof(char *));
+		afi[i].filters = para_malloc(nf * sizeof(struct filter *));
 	}
 	if (!conf.no_default_filters_given)
 		return setup_default_filters();
@@ -1240,7 +1243,7 @@ out:
 	return ret;
 }
 
-static int com_stat(int fd, __unused int argc, __unused char **argv)
+static int com_stat(int fd, __a_unused int argc, __a_unused char **argv)
 {
 	int i, ret;
 	char *buf = NULL;
@@ -1370,27 +1373,27 @@ err_out:
 	return 1;
 }
 
-static int __noreturn com_term(int fd, __unused int argc, __unused char **argv)
+static int __noreturn com_term(int fd, __a_unused int argc, __a_unused char **argv)
 {
 	close(fd);
 	clean_exit(EXIT_SUCCESS, "terminating on user request");
 }
 
-static int com_on(int fd, __unused int argc, __unused char **argv)
+static int com_on(int fd, __a_unused int argc, __a_unused char **argv)
 {
 	audiod_status = AUDIOD_ON;
 	close(fd);
 	return 1;
 }
 
-static int com_off(int fd, __unused int argc, __unused char **argv)
+static int com_off(int fd, __a_unused int argc, __a_unused char **argv)
 {
 	audiod_status = AUDIOD_OFF;
 	close(fd);
 	return 1;
 }
 
-static int com_sb(int fd, __unused int argc, __unused char **argv)
+static int com_sb(int fd, __a_unused int argc, __a_unused char **argv)
 {
 	audiod_status = AUDIOD_STANDBY;
 	close(fd);
@@ -1414,14 +1417,14 @@ static int com_cycle(int fd, int argc, char **argv)
 	return 1;
 }
 
-static int check_perms(struct ucred *c)
+static int check_perms(uid_t uid)
 {
 	int i;
 
 	if (!conf.user_allow_given)
 		return 1;
 	for (i = 0; i < conf.user_allow_given; i++)
-		if (c->uid == conf.user_allow_arg[i])
+		if (uid == conf.user_allow_arg[i])
 			return 1;
 	return -E_UCRED_PERM;
 }
@@ -1429,7 +1432,6 @@ static int check_perms(struct ucred *c)
 static int handle_connect(void)
 {
 	int i, argc, ret, clifd = -1;
-	struct ucred c;
 	char *buf = para_malloc(MAXLINE), **argv = NULL;
 	struct sockaddr_un unix_addr;
 
@@ -1437,20 +1439,19 @@ static int handle_connect(void)
 	if (ret < 0)
 		goto out;
 	clifd = ret;
-	ret = recv_cred_buffer(clifd, buf, MAXLINE - 1, &c);
+	ret = recv_cred_buffer(clifd, buf, MAXLINE - 1);
 	if (ret < 0)
 		goto out;
-	PARA_INFO_LOG("pid: %i, uid: %i, gid: %i, ret: %i, buf: %s\n", c.pid, c.uid, c.gid, ret, buf);
-	buf[ret] = '\0';
-	ret = check_perms(&c);
+	PARA_INFO_LOG("connection from user %i\n",  ret);
+	ret = check_perms(ret);
 	if (ret < 0)
 		goto out;
-	argc = split_args(buf, &argv, '\n');
-	PARA_INFO_LOG("argv[0]: %s\n", argv[0]);
+	argc = split_args(buf, &argv, "\n");
+	PARA_INFO_LOG("argv[0]: %s, argc= %d\n", argv[0], argc);
 	for (i = 0; cmds[i].name; i++) {
 		if (strcmp(cmds[i].name, argv[0]))
 			continue;
-		ret = cmds[i].handler(clifd, argc + 1, argv);
+		ret = cmds[i].handler(clifd, argc, argv);
 		goto out;
 	}
 	ret = -E_INVALID_AUDIOD_CMD; /* cmd not found */
@@ -1522,7 +1523,7 @@ static void audiod_pre_select(fd_set *rfds, fd_set *wfds, struct timeval *tv,
 		a = &afi[s->format];
 		ret = a->receiver->pre_select(rn, rfds, wfds, tv);
 //		PARA_NOTICE_LOG("%s preselect: %d\n", a->receiver->name, ret);
-		*max_fileno = MAX(*max_fileno, ret);
+		*max_fileno = PARA_MAX(*max_fileno, ret);
 	}
 }
 static void audiod_post_select(int select_ret, fd_set *rfds, fd_set *wfds)
@@ -1561,8 +1562,7 @@ repeat:
 	FD_ZERO(&wfds);
 	FD_ZERO(&rfds);
 	/* always check signal pipe and the local socket */
-	FD_SET(signal_pipe, &rfds);
-	max_fileno = signal_pipe;
+	para_fd_set(signal_pipe, &rfds, &max_fileno);
 	para_fd_set(audiod_socket, &rfds, &max_fileno);
 
 	if (audiod_status != AUDIOD_ON)
@@ -1643,6 +1643,7 @@ int __noreturn main(int argc, char *argv[])
 	char *cf;
 	int i;
 
+	fprintf(stderr, "argc: %d\n", argc);
 	valid_fd_012();
 	hostname = para_hostname();
 	cmdline_parser(argc, argv, &conf);