X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=audiod_command.c;h=278e6ef69e9f38a081aea8637405de8fcdc6e600;hp=76c185711b33c0b431c1366805a04539ccf785c5;hb=9cc91f2d8d746e77947eeb2fd7af711a43c3a56a;hpb=837cd1ab890645d9fd7d0d85139fdf076d987ea4

diff --git a/audiod_command.c b/audiod_command.c
index 76c18571..278e6ef6 100644
--- a/audiod_command.c
+++ b/audiod_command.c
@@ -42,6 +42,12 @@ static audiod_command_handler_t AUDIOD_COMMAND_HANDLERS;
 struct audiod_command {
 	const char *name;
 	/* Pointer to the function that handles the command. */
+	/*
+	 * Command handlers must never never close their file descriptor. A
+	 * positive return value tells audiod that the status items have
+	 * changed. In this case audiod will send an updated version of all
+	 * status items to to each connected stat client.
+	 */
 	audiod_command_handler_t *handler;
 	/* One-line description. */
 	const char *description;
@@ -183,8 +189,7 @@ void stat_client_write_item(int item_num)
 			continue;
 		b = (sc->flags & SCF_PARSER_FRIENDLY)? &pfpb : &pb;
 		if (!b->buf)
-			(void)WRITE_STATUS_ITEM(b, item_num, "%s\n",
-				msg? msg : "");
+			WRITE_STATUS_ITEM(b, item_num, "%s\n", msg? msg : "");
 		ret = write(sc->fd, b->buf, b->offset);
 		if (ret == b->offset)
 			continue;
@@ -256,10 +261,11 @@ static int com_help(int fd, int argc, char **argv)
 {
 	int i, ret;
 	char *buf;
-	const char *dflt = "No such command. Available commands:\n";
 
-	if (argc < 2)
-		return dump_commands(fd);
+	if (argc < 2) {
+		ret = dump_commands(fd);
+		goto out;
+	}
 	FOR_EACH_COMMAND(i) {
 		if (strcmp(audiod_cmds[i].name, argv[1]))
 			continue;
@@ -274,12 +280,13 @@ static int com_help(int fd, int argc, char **argv)
 		);
 		ret = client_write(fd, buf);
 		free(buf);
-		return ret;
+		goto out;
 	}
-	ret = client_write(fd, dflt);
+	ret = client_write(fd, "No such command. Available commands:\n");
 	if (ret > 0)
 		ret = dump_commands(fd);
-	return ret;
+out:
+	return ret < 0? ret : 0;
 }
 
 static int com_tasks(int fd, __a_unused int argc, __a_unused char **argv)
@@ -290,7 +297,7 @@ static int com_tasks(int fd, __a_unused int argc, __a_unused char **argv)
 	if (tl)
 		ret = client_write(fd, tl);
 	free(tl);
-	return ret;
+	return ret < 0? ret : 0;
 }
 
 static int com_stat(int fd, int argc, char **argv)
@@ -329,18 +336,19 @@ static int com_stat(int fd, int argc, char **argv)
 		char *item = stat_item_values[i];
 		if (!((one << i) & mask))
 			continue;
-		(void)WRITE_STATUS_ITEM(&b, i, "%s\n", item? item : "");
+		WRITE_STATUS_ITEM(&b, i, "%s\n", item? item : "");
 	}
 	ret = client_write(fd, b.buf);
 	if (ret >= 0)
 		ret = stat_client_add(fd, mask, parser_friendly);
 	free(b.buf);
-	return ret;
+	return ret < 0? ret : 0;
 }
 
 static int com_grab(int fd, int argc, char **argv)
 {
-	return grab_client_new(fd, argc, argv, &sched);
+	int ret = grab_client_new(fd, argc, argv, &sched);
+	return ret < 0? ret : 0;
 }
 
 static int com_term(__a_unused int fd, __a_unused int argc, __a_unused char **argv)
@@ -393,7 +401,7 @@ static int com_version(int fd, int argc, char **argv)
 		msg = make_message("%s\n", version_single_line("audiod"));
 	ret = client_write(fd, msg);
 	free(msg);
-	return ret;
+	return ret < 0? ret : 0;
 }
 
 static int check_perms(uid_t uid, uid_t *whitelist)
@@ -440,7 +448,7 @@ int handle_connect(int accept_fd, fd_set *rfds, uid_t *uid_whitelist)
 	if (ret < 0)
 		goto out;
 	uid = ret;
-	PARA_INFO_LOG("connection from user %i, buf: %s\n",  ret, buf);
+	PARA_INFO_LOG("connection from user %i, buf: %s\n", ret, buf);
 	ret = check_perms(uid, uid_whitelist);
 	if (ret < 0)
 		goto out;