X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=audiod_command.c;h=77a0a1ee32bb7a1b3241afc549d999f124a6073e;hp=2fa7eb148d6d32bb9e003e4da55b7180bff41375;hb=5430c77f1fdf97d92796f44623d257b8124bde24;hpb=1446f99e3adc59d868726382a2ac7cec105372a7

diff --git a/audiod_command.c b/audiod_command.c
index 2fa7eb14..77a0a1ee 100644
--- a/audiod_command.c
+++ b/audiod_command.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2007 Andre Noll <noll@mathematik.tu-darmstadt.de>
+ * Copyright (C) 2005-2007 Andre Noll <maan@systemlinux.org>
  *
  *     This program is free software; you can redistribute it and/or modify
  *     it under the terms of the GNU General Public License as published by
@@ -350,7 +350,7 @@ err_out:
 	return 1;
 }
 
-int __noreturn com_term(int fd, __a_unused int argc, __a_unused char **argv)
+__noreturn int com_term(int fd, __a_unused int argc, __a_unused char **argv)
 {
 	close(fd);
 	clean_exit(EXIT_SUCCESS, "terminating on user request");
@@ -406,6 +406,21 @@ static int check_perms(uid_t uid)
 	return -E_UCRED_PERM;
 }
 
+/**
+ * handle arriving connections on the local socket
+ *
+ * \param accept_fd the fd to call accept() on
+ *
+ * This is called whenever para_audiod's main task detects an incoming
+ * connection by the readability of \a accept_fd. This function reads the
+ * command sent by the peer, checks the connecting user's permissions by using
+ * unix socket credentials (if supported by the OS) and calls the corresponding
+ * command handler if permissions are OK.
+ *
+ * \return positive on success, negative on errors
+ *
+ * \sa para_accept(), recv_cred_buffer()
+ * */
 int handle_connect(int accept_fd)
 {
 	int i, argc, ret, clifd = -1;
@@ -462,7 +477,9 @@ out:
 	}
 	return ret;
 }
-
+/**
+ * send the current audiod status to all connected stat clients
+ */
 void audiod_status_dump(void)
 {
 	struct timeval *t = wstime();
@@ -503,6 +520,7 @@ void audiod_status_dump(void)
 	old = stat_task->stat_item_values[SI_DECODER_FLAGS];
 	new = decoder_flags();
 	if (!old || strcmp(old, new)) {
+		free(old);
 		stat_client_write(new, SI_DECODER_FLAGS);
 		stat_task->stat_item_values[SI_DECODER_FLAGS] = new;
 	} else