X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=audiod_command.c;h=9d92d1c36505ee4599a507e3fbe7d0c0c8e2fc61;hp=bfd7c4aa5df170235f24961813bc4cc2e69790fa;hb=017a63ecd7f2ff30233b50d455355400197bb660;hpb=65a0002eb560b7248cbb0b4f143d00053b66bccc

diff --git a/audiod_command.c b/audiod_command.c
index bfd7c4aa..9d92d1c3 100644
--- a/audiod_command.c
+++ b/audiod_command.c
@@ -1,15 +1,13 @@
 /*
- * Copyright (C) 2005-2011 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2012 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
 
-/** \file audiod_command.c commands for para_audiod */
+/** \file audiod_command.c Commands for para_audiod. */
 
 #include <regex.h>
 #include <sys/types.h>
-#include <dirent.h>
-#include <stdbool.h>
 
 #include "para.h"
 #include "audiod.cmdline.h"
@@ -28,6 +26,7 @@
 #include "fd.h"
 #include "audiod_command_list.h"
 
+extern struct sched sched;
 extern char *stat_item_values[NUM_STAT_ITEMS];
 
 /** Iterate over the array of all audiod commands. */
@@ -121,24 +120,22 @@ void stat_client_write_item(int item_num)
 	struct para_buffer pb = {.flags = 0};
 	struct para_buffer pfpb = {.flags = PBF_SIZE_PREFIX};
 	const uint64_t one = 1;
+	char *msg = stat_item_values[item_num];
+	struct para_buffer *b;
 
 	list_for_each_entry_safe(sc, tmp, &client_list, node) {
 		int fd = sc->fd, ret;
 
 		if (!((one << item_num) & sc->item_mask))
 			continue;
-		if (write_ok(fd) > 0) {
-			struct para_buffer *b =
-				(sc->flags & SCF_PARSER_FRIENDLY)? &pfpb : &pb;
-			char *msg = stat_item_values[item_num];
-			if (!b->buf)
-				WRITE_STATUS_ITEM(b, item_num, "%s\n",
-					msg? msg : "");
-			ret = write(fd, b->buf, b->offset);
-			if (ret == b->offset)
-				continue;
-		}
-		/* write error or fd not ready for writing */
+		b = (sc->flags & SCF_PARSER_FRIENDLY)? &pfpb : &pb;
+		if (!b->buf)
+			(void)WRITE_STATUS_ITEM(b, item_num, "%s\n",
+				msg? msg : "");
+		ret = write(fd, b->buf, b->offset);
+		if (ret == b->offset)
+			continue;
+		/* write error or short write */
 		close(fd);
 		num_clients--;
 		PARA_INFO_LOG("deleting client on fd %d\n", fd);
@@ -148,8 +145,6 @@ void stat_client_write_item(int item_num)
 	}
 	free(pb.buf);
 	free(pfpb.buf);
-//	if (num_clients)
-//		PARA_DEBUG_LOG("%d client(s)\n", num_clients);
 }
 
 /**
@@ -199,7 +194,7 @@ static int get_play_time_slot_num(void)
 	FOR_EACH_SLOT(i) {
 		struct slot_info *s = &slot[i];
 		struct timeval wstime;
-		if (!s->wns)
+		if (!s->wns || !s->wns[0].btrn)
 			continue;
 		btr_get_node_start(s->wns[0].btrn, &wstime);
 		if (oldest_slot >= 0 && tv_diff(&wstime, &oldest_wstime, NULL) > 0)
@@ -291,7 +286,7 @@ out:
 
 int com_tasks(int fd, __a_unused int argc, __a_unused char **argv)
 {
-	char *tl = get_task_list();
+	char *tl = get_task_list(&sched);
 	int ret = 1;
 	if (tl)
 		ret = client_write(fd, tl);
@@ -308,6 +303,9 @@ int com_stat(int fd, int argc, char **argv)
 	const uint64_t one = 1;
 	struct para_buffer b = {.flags = 0};
 
+	ret = mark_fd_nonblocking(fd);
+	if (ret < 0)
+		return ret;
 	for (i = 1; i < argc; i++) {
 		const char *arg = argv[i];
 		if (arg[0] != '-')
@@ -335,7 +333,7 @@ int com_stat(int fd, int argc, char **argv)
 		char *item = stat_item_values[i];
 		if (!((one << i) & mask))
 			continue;
-		WRITE_STATUS_ITEM(&b, i, "%s\n", item? item : "");
+		(void)WRITE_STATUS_ITEM(&b, i, "%s\n", item? item : "");
 	}
 	ret = client_write(fd, b.buf);
 	if (ret >= 0)
@@ -346,7 +344,7 @@ int com_stat(int fd, int argc, char **argv)
 
 int com_grab(int fd, int argc, char **argv)
 {
-	return grab_client_new(fd, argc, argv);
+	return grab_client_new(fd, argc, argv, &sched);
 }
 
 __noreturn int com_term(int fd, __a_unused int argc, __a_unused char **argv)
@@ -482,7 +480,7 @@ void audiod_status_dump(void)
 			free(new);
 	}
 
-	new = uptime_str();
+	new = get_server_uptime_str(now);
 	old = stat_item_values[SI_AUDIOD_UPTIME];
 	if (!old || strcmp(old, new)) {
 		free(old);