X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=audiod_command.c;h=b4c50dc86118a6d9f3c756f7d6b2c40a87c34ca9;hp=d424cf2e76f32ca90058685b68186b5a00be6a2b;hb=3dfab6fc800bec957eee78aa642d0b139300d470;hpb=3689799ede7bba230ca544ac953392b428c3d662

diff --git a/audiod_command.c b/audiod_command.c
index d424cf2e..b4c50dc8 100644
--- a/audiod_command.c
+++ b/audiod_command.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2007 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2008 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -70,7 +70,7 @@ static char *get_time_string(struct timeval *newest_stime)
 		total = 0;
 out:
 	return make_message(
-		"%s:%s%d:%02d [%d:%02d] (%d%%/%d:%02d)\n",
+		"%s: %s%d:%02d [%d:%02d] (%d%%/%d:%02d)\n",
 		status_item_list[SI_PLAY_TIME],
 		use_server_time? "~" : "",
 		total / 60,
@@ -88,7 +88,7 @@ __malloc static char *audiod_status_string(void)
 {
 	const char *status = (audiod_status == AUDIOD_ON)?
 		"on" : (audiod_status == AUDIOD_OFF)? "off": "sb";
-	return make_message("%s:%s\n", status_item_list[SI_AUDIOD_STATUS], status);
+	return make_message("%s: %s\n", status_item_list[SI_AUDIOD_STATUS], status);
 }
 
 static struct timeval *wstime(void)
@@ -120,7 +120,7 @@ __malloc static char *decoder_flags(void)
 		flags[i] = flag;
 	}
 	flags[MAX_STREAM_SLOTS] = '\0';
-	return make_message("%s:%s\n", status_item_list[SI_DECODER_FLAGS],
+	return make_message("%s: %s\n", status_item_list[SI_DECODER_FLAGS],
 		flags);
 }
 
@@ -237,7 +237,7 @@ int com_stat(int fd, __a_unused int argc, __a_unused char **argv)
 	}
 	if (mask & (1 << SI_AUDIOD_UPTIME)) {
 		char *tmp, *us = uptime_str();
-		tmp = make_message("%s:%s\n",
+		tmp = make_message("%s: %s\n",
 			status_item_list[SI_AUDIOD_UPTIME], us);
 		free(us);
 		ret = client_write(fd, tmp);
@@ -253,14 +253,13 @@ int com_stat(int fd, __a_unused int argc, __a_unused char **argv)
 		free(s);
 	}
 	if (mask & (1 << SI_DECODER_FLAGS)) {
-		char *df =decoder_flags();
+		char *df = decoder_flags();
 		ret = client_write(fd, df);
 		if (ret < 0)
 			goto out;
 		free(df);
 	}
-
-	for (i = 0; i < NUM_STAT_ITEMS; i++) {
+	FOR_EACH_STATUS_ITEM(i) {
 		char *tmp, *v;
 		if (!((1 << i) & mask))
 			continue;
@@ -280,8 +279,7 @@ out:
 
 static struct filter_node *find_filter_node(int slot_num, int format, int filternum)
 {
-	struct filter_node *fn;
-	int i, j;
+	int i;
 
 	FOR_EACH_SLOT(i) {
 		struct slot_info *s = &slot[i];
@@ -291,14 +289,10 @@ static struct filter_node *find_filter_node(int slot_num, int format, int filter
 			continue;
 		if (format >= 0 && s->format != format)
 			continue;
-		if (num_filters(i) < filternum)
+		if (num_filters(i) <= filternum)
 			continue;
 		/* success */
-		j = 1;
-		list_for_each_entry(fn, &s->fc->filters, node)
-			if (filternum <= 0 || j++ == filternum)
-				break;
-		return fn;
+		return  s->fc->filter_nodes + filternum;
 	}
 	return NULL;
 }
@@ -462,7 +456,7 @@ out:
 	free(buf);
 	free(argv);
 	if (clifd > 0 && ret < 0 && ret != -E_CLIENT_WRITE) {
-		char *tmp = make_message("%s\n", PARA_STRERROR(-ret));
+		char *tmp = make_message("%s\n", para_strerror(-ret));
 		client_write(clifd, tmp);
 		free(tmp);
 		close(clifd);
@@ -492,7 +486,7 @@ void audiod_status_dump(void)
 	old = stat_task->stat_item_values[SI_AUDIOD_UPTIME];
 	if (!old || strcmp(old, new)) {
 		free(old);
-		tmp = make_message("%s:%s\n",
+		tmp = make_message("%s: %s\n",
 			status_item_list[SI_AUDIOD_UPTIME], new);
 		stat_client_write(tmp, SI_AUDIOD_UPTIME);
 		free(tmp);
@@ -529,7 +523,7 @@ void dump_empty_status(void)
 {
 	int i;
 
-	FOR_EACH_STAT_ITEM(i) {
+	FOR_EACH_STATUS_ITEM(i) {
 		char *tmp = make_message("%s:\n", status_item_list[i]);
 		stat_client_write(tmp, i);
 		free(tmp);