X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=blob.c;h=339897cb1faf89fc4337e08605fd45122eeba697;hp=dc71b8e3feb61323279b770effbab33b7c6d4978;hb=74592ed100009a2d73e03861ae9626363f06aca9;hpb=0879c9de4eaf8c78131c243d8e9fec013df0d14a diff --git a/blob.c b/blob.c index dc71b8e3..339897cb 100644 --- a/blob.c +++ b/blob.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2007-2014 Andre Noll + * Copyright (C) 2007 Andre Noll * * Licensed under the GPL v2. For licencing details see COPYING. */ @@ -9,6 +9,7 @@ #include #include #include +#include #include "para.h" #include "error.h" @@ -66,7 +67,7 @@ static struct osl_column_description blob_cols[] = { /** Define an osl table description for a blob table. */ #define DEFINE_BLOB_TABLE_DESC(table_name) \ - struct osl_table_description table_name ## _table_desc = { \ + static struct osl_table_description table_name ## _table_desc = { \ .name = #table_name, \ .num_columns = NUM_BLOB_COLUMNS, \ .flags = OSL_LARGE_TABLE, \ @@ -100,75 +101,60 @@ enum blob_ls_flags { BLOB_LS_FLAG_SORT_BY_ID = 4, }; -/** Structure passed to the \p print_blob function. */ -struct lsblob_action_data { - /** The flags given at the command line. */ - uint32_t flags; - /** Message buffer. */ - struct para_buffer pb; -}; - static int print_blob(struct osl_table *table, struct osl_row *row, const char *name, void *data) { - struct lsblob_action_data *lbad = data; + struct afs_callback_arg *aca = data; + uint32_t flags = *(uint32_t *)aca->query.data; struct osl_object obj; uint32_t id; int ret; - if (!(lbad->flags & BLOB_LS_FLAG_LONG)) - return para_printf(&lbad->pb, "%s\n", name); + if (!(flags & BLOB_LS_FLAG_LONG)) { + para_printf(&aca->pbout, "%s\n", name); + return 0; + } ret = osl(osl_get_object(table, row, BLOBCOL_ID, &obj)); if (ret < 0) { - para_printf(&lbad->pb, "%s: %s\n", name, para_strerror(-ret)); + para_printf(&aca->pbout, "cannot list %s\n", name); return ret; } id = *(uint32_t *)obj.data; - return para_printf(&lbad->pb, "%u\t%s\n", id, name); + para_printf(&aca->pbout, "%u\t%s\n", id, name); + return 1; } -static void com_lsblob_callback(struct osl_table *table, - int fd, const struct osl_object *query) +static int com_lsblob_callback(struct osl_table *table, + struct afs_callback_arg *aca) { - struct lsblob_action_data lbad = { - .flags = *(uint32_t *)query->data, - .pb = { - .max_size = shm_get_shmmax(), - .private_data = &(struct afs_max_size_handler_data) { - .fd = fd, - .band = SBD_OUTPUT - }, - .max_size_handler = afs_max_size_handler, - } - }; + uint32_t flags = *(uint32_t *)aca->query.data; struct pattern_match_data pmd = { .table = table, - .patterns = {.data = (char *)query->data + sizeof(uint32_t), - .size = query->size - sizeof(uint32_t)}, + .patterns = {.data = (char *)aca->query.data + sizeof(uint32_t), + .size = aca->query.size - sizeof(uint32_t)}, .pm_flags = PM_NO_PATTERN_MATCHES_EVERYTHING | PM_SKIP_EMPTY_NAME, .match_col_num = BLOBCOL_NAME, - .data = &lbad, + .data = aca, .action = print_blob, }; int ret; - if (lbad.flags & BLOB_LS_FLAG_REVERSE) + if (flags & BLOB_LS_FLAG_REVERSE) pmd.pm_flags |= PM_REVERSE_LOOP; - if (!(lbad.flags & BLOB_LS_FLAG_SORT_BY_ID)) + if (!(flags & BLOB_LS_FLAG_SORT_BY_ID)) pmd.loop_col_num = BLOBCOL_NAME; else pmd.loop_col_num = BLOBCOL_ID; ret = for_each_matching_row(&pmd); if (ret < 0) - para_printf(&lbad.pb, "%s\n", para_strerror(-ret)); - else if (pmd.num_matches == 0 && pmd.patterns.size > 0) - para_printf(&lbad.pb, "no matches\n"); - if (lbad.pb.offset) - pass_buffer_as_shm(fd, SBD_OUTPUT, lbad.pb.buf, lbad.pb.offset); - free(lbad.pb.buf); + goto out; + if (pmd.num_matches == 0 && pmd.patterns.size > 0) + ret = -E_NO_MATCH; +out: + return ret; } -static int com_lsblob(callback_function *f, struct command_context *cc) +static int com_lsblob(afs_callback *f, struct command_context *cc) { uint32_t flags = 0; struct osl_object options = {.data = &flags, .size = sizeof(flags)}; @@ -217,26 +203,28 @@ static int cat_blob(struct osl_table *table, struct osl_row *row, return (ret < 0)? ret : ret2; } -static void com_catblob_callback(struct osl_table *table, int fd, - const struct osl_object *query) +static int com_catblob_callback(struct osl_table *table, + struct afs_callback_arg *aca) { + int ret; struct pattern_match_data pmd = { .table = table, - .patterns = *query, + .patterns = aca->query, .loop_col_num = BLOBCOL_NAME, .match_col_num = BLOBCOL_NAME, .pm_flags = PM_SKIP_EMPTY_NAME, - .data = &fd, + .data = &aca->fd, .action = cat_blob }; - for_each_matching_row(&pmd); - if (pmd.num_matches == 0) { - char err_msg[] = "no matches\n"; - pass_buffer_as_shm(fd, SBD_OUTPUT, err_msg, sizeof(err_msg)); - } + ret = for_each_matching_row(&pmd); + if (ret < 0) + return ret; + if (pmd.num_matches == 0) + ret = -E_NO_MATCH; + return ret; } -static int com_catblob(callback_function *f, struct command_context *cc) +static int com_catblob(afs_callback *f, struct command_context *cc) { if (cc->argc < 2) return -E_BLOB_SYNTAX; @@ -244,66 +232,46 @@ static int com_catblob(callback_function *f, struct command_context *cc) afs_cb_result_handler, cc); } -/** Used for removing rows from a blob table. */ -struct rmblob_data { - /** Message buffer. */ - struct para_buffer pb; -}; - static int remove_blob(struct osl_table *table, struct osl_row *row, const char *name, void *data) { - struct rmblob_data *rmbd = data; + struct afs_callback_arg *aca = data; int ret = osl(osl_del_row(table, row)); if (ret < 0) { - para_printf(&rmbd->pb, "%s: %s\n", name, para_strerror(-ret)); + para_printf(&aca->pbout, "cannot remove %s\n", name); return ret; } return 1; } -static void com_rmblob_callback(struct osl_table *table, int fd, - const struct osl_object *query) +static int com_rmblob_callback(struct osl_table *table, + struct afs_callback_arg *aca) { - int ret, ret2 = 0; - struct rmblob_data rmbd = { - .pb = { - .max_size = shm_get_shmmax(), - .private_data = &(struct afs_max_size_handler_data) { - .fd = fd, - .band = SBD_OUTPUT - }, - .max_size_handler = afs_max_size_handler, - } - }; + int ret; struct pattern_match_data pmd = { .table = table, - .patterns = *query, + .patterns = aca->query, .loop_col_num = BLOBCOL_NAME, .match_col_num = BLOBCOL_NAME, .pm_flags = PM_SKIP_EMPTY_NAME, - .data = &rmbd, + .data = aca, .action = remove_blob }; ret = for_each_matching_row(&pmd); - if (ret < 0) { - ret2 = para_printf(&rmbd.pb, "%s\n", para_strerror(-ret)); - if (ret2 < 0) - goto out; - } + if (ret < 0) + goto out; if (pmd.num_matches == 0) - ret2 = para_printf(&rmbd.pb, "no matches, nothing removed\n"); + ret = -E_NO_MATCH; else { - ret2 = para_printf(&rmbd.pb, "removed %d blobs\n", pmd.num_matches); - afs_event(BLOB_RENAME, NULL, table); + para_printf(&aca->pbout, "removed %u blob(s)\n", + pmd.num_matches); + ret = afs_event(BLOB_REMOVE, NULL, table); } out: - if (ret2 >= 0 && rmbd.pb.offset) - pass_buffer_as_shm(fd, SBD_OUTPUT, rmbd.pb.buf, rmbd.pb.offset); - free(rmbd.pb.buf); + return ret; } -static int com_rmblob(callback_function *f, struct command_context *cc) +static int com_rmblob(afs_callback *f, struct command_context *cc) { if (cc->argc < 2) return -E_MOOD_SYNTAX; @@ -311,12 +279,12 @@ static int com_rmblob(callback_function *f, struct command_context *cc) afs_cb_result_handler, cc); } -static void com_addblob_callback(struct osl_table *table, int fd, - const struct osl_object *query) +static int com_addblob_callback(struct osl_table *table, + struct afs_callback_arg *aca) { struct osl_object objs[NUM_BLOB_COLUMNS]; - char *name = query->data, *msg; - size_t name_len = strlen(name) + 1, msg_len; + char *name = aca->query.data; + size_t name_len = strlen(name) + 1; uint32_t id; unsigned num_rows; int ret; @@ -349,7 +317,7 @@ static void com_addblob_callback(struct osl_table *table, int fd, goto out; id = *(uint32_t *)obj.data; obj.data = name + name_len; - obj.size = query->size - name_len; + obj.size = aca->query.size - name_len; ret = osl(osl_update_object(table, row, BLOBCOL_DEF, &obj)); goto out; } @@ -374,19 +342,17 @@ static void com_addblob_callback(struct osl_table *table, int fd, objs[BLOBCOL_NAME].data = name; objs[BLOBCOL_NAME].size = name_len; objs[BLOBCOL_DEF].data = name + name_len; - objs[BLOBCOL_DEF].size = query->size - name_len; + objs[BLOBCOL_DEF].size = aca->query.size - name_len; ret = osl(osl_add_row(table, objs)); if (ret < 0) goto out; - afs_event(BLOB_ADD, NULL, table); + ret = afs_event(BLOB_ADD, NULL, table); out: if (ret < 0) - msg_len = xasprintf(&msg, "could not add %s: %s\n", name, - para_strerror(-ret)); + para_printf(&aca->pbout, "cannot add %s\n", name); else - msg_len = xasprintf(&msg, "added %s as id %u\n", name, id); - pass_buffer_as_shm(fd, SBD_OUTPUT, msg, msg_len); - free(msg); + para_printf(&aca->pbout, "added %s as id %u\n", name, id); + return ret; } /* Write input from fd to dynamically allocated buffer, but maximal 10M. */ @@ -426,27 +392,16 @@ again: } /* - * Read data from a file descriptor, and send it to the afs process. - * - * \param cc Contains the file descriptor to read data from. - * \param arg_obj Pointer to the arguments to \a f. - * \param f The callback function. - * \param result_handler See \ref send_callback_request. - * \param private_result_data See \ref send_callback_request. + * Read blob from a file descriptor and send it to afs. * - * This function is used by the addblob commands that instruct para_server to - * store arbitrary data in a blob table. Input data is read and decrypted from - * the file descriptor given by \a cc. This data is concatenated with the - * buffer given by \a arg_obj, and the combined buffer is made available to the - * afs process via the callback method. See \ref send_callback_request for - * details. - * - * \return Negative on errors, the return value of the underlying call to - * send_callback_request() otherwise. + * This function is called from the addblob command handlers to instruct the + * afs process to store the input in a blob table. Input is read and decrypted + * from the file descriptor given by cc and appended to arg_obj, which contains + * the name of the blob to create. The combined buffer is made available to the + * afs process via the callback method. */ static int stdin_command(struct command_context *cc, struct osl_object *arg_obj, - callback_function *f, callback_result_handler *result_handler, - void *private_result_data) + afs_callback *f) { struct osl_object query, stdin_obj; int ret; @@ -464,12 +419,12 @@ static int stdin_command(struct command_context *cc, struct osl_object *arg_obj, memcpy((char *)query.data + arg_obj->size, stdin_obj.data, stdin_obj.size); free(stdin_obj.data); - ret = send_callback_request(f, &query, result_handler, private_result_data); + ret = send_callback_request(f, &query, afs_cb_result_handler, cc); free(query.data); return ret; } -static int com_addblob(callback_function *f, struct command_context *cc) +static int com_addblob(afs_callback *f, struct command_context *cc) { struct osl_object arg_obj; @@ -479,44 +434,47 @@ static int com_addblob(callback_function *f, struct command_context *cc) return -E_BLOB_SYNTAX; arg_obj.size = strlen(cc->argv[1]) + 1; arg_obj.data = (char *)cc->argv[1]; - return stdin_command(cc, &arg_obj, f, afs_cb_result_handler, cc); + return stdin_command(cc, &arg_obj, f); } -/* FIXME: Print output to client, not to log file */ -static void com_mvblob_callback(struct osl_table *table, __a_unused int fd, - const struct osl_object *query) +static int com_mvblob_callback(struct osl_table *table, + struct afs_callback_arg *aca) { - char *src = (char *) query->data; + char *src = (char *)aca->query.data; struct osl_object obj = {.data = src, .size = strlen(src) + 1}; char *dest = src + obj.size; struct osl_row *row; int ret = osl(osl_get_row(table, BLOBCOL_NAME, &obj, &row)); - if (ret < 0) + if (ret < 0) { + para_printf(&aca->pbout, "cannot find source blob %s\n", src); goto out; + } obj.data = dest; obj.size = strlen(dest) + 1; ret = osl(osl_update_object(table, row, BLOBCOL_NAME, &obj)); - if (ret < 0) + if (ret < 0) { + para_printf(&aca->pbout, "cannot rename blob %s to %s\n", + src, dest); goto out; - afs_event(BLOB_RENAME, NULL, table); + } + ret = afs_event(BLOB_RENAME, NULL, table); out: - if (ret < 0) - PARA_NOTICE_LOG("%s\n", para_strerror(-ret)); + return ret; } -static int com_mvblob(callback_function *f, struct command_context *cc) +static int com_mvblob(afs_callback *f, struct command_context *cc) { if (cc->argc != 3) return -E_MOOD_SYNTAX; return send_option_arg_callback_request(NULL, cc->argc - 1, - cc->argv + 1, f, NULL, NULL); + cc->argv + 1, f, afs_cb_result_handler, cc); } #define DEFINE_BLOB_COMMAND(cmd_name, table_name, cmd_prefix) \ - static void com_ ## cmd_name ## cmd_prefix ## _callback(int fd, const struct osl_object *query) \ + static int com_ ## cmd_name ## cmd_prefix ## _callback(struct afs_callback_arg *aca) \ { \ - return com_ ## cmd_name ## blob_callback(table_name ## _table, fd, query); \ + return com_ ## cmd_name ## blob_callback(table_name ## _table, aca); \ } \ int com_ ## cmd_name ## cmd_prefix(struct command_context *cc) \ { \ @@ -530,7 +488,8 @@ static int blob_get_name_by_id(struct osl_table *table, uint32_t id, struct osl_object obj = {.data = &id, .size = sizeof(id)}; int ret; - *name = NULL; + if (name) + *name = NULL; if (!id) return 1; ret = osl(osl_get_row(table, BLOBCOL_ID, &obj, &row)); @@ -539,7 +498,10 @@ static int blob_get_name_by_id(struct osl_table *table, uint32_t id, ret = osl(osl_get_object(table, row, BLOBCOL_NAME, &obj)); if (ret < 0) return ret; - *name = (char *)obj.data; + if (*(char *)obj.data == '\0') + return -E_DUMMY_ROW; + if (name) + *name = (char *)obj.data; return 1; } @@ -629,7 +591,7 @@ static int blob_get_name_and_def_by_row(struct osl_table *table, static int table_name ## _create(const char *dir) \ { \ table_name ## _table_desc.dir = dir; \ - return osl_create_table(&table_name ## _table_desc); \ + return osl(osl_create_table(&table_name ## _table_desc)); \ } static int blob_open(struct osl_table **table,