X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=client.c;h=2d6ef31f590bca1736d458cc61c4fbe67459641b;hp=f0f3b2617be6f3554250cedfafbbcc92c38f54b7;hb=e2eebf654cae2fc004cee516a0e165127c0214ca;hpb=02dd632ab2a6696aff7b6c6d108069704cfe871a

diff --git a/client.c b/client.c
index f0f3b261..2d6ef31f 100644
--- a/client.c
+++ b/client.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 1997-2012 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 1997-2013 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -54,7 +54,7 @@ static void exec_pre_select(struct sched *s, struct task *t)
 		sched_min_delay(s);
 }
 
-static void exec_post_select(__a_unused struct sched *s, struct task *t)
+static int exec_post_select(__a_unused struct sched *s, struct task *t)
 {
 	struct exec_task *et = container_of(t, struct exec_task, task);
 	struct btr_node *btrn = et->btrn;
@@ -63,10 +63,8 @@ static void exec_post_select(__a_unused struct sched *s, struct task *t)
 	int ret;
 
 	ret = btr_node_status(btrn, 0, BTR_NT_LEAF);
-	if (ret <= 0) {
-		t->error = ret;
-		return;
-	}
+	if (ret <= 0)
+		return ret;
 	sz = btr_next_buffer(btrn, &buf);
 	if (sz <= 1)
 		goto out;
@@ -76,6 +74,7 @@ static void exec_post_select(__a_unused struct sched *s, struct task *t)
 	et->result_buf[et->result_size - 1] = '\0';
 out:
 	btr_consume(btrn, sz);
+	return 0;
 }
 
 static int make_client_argv(const char *line)
@@ -114,11 +113,11 @@ static int execute_client_command(const char *cmd, char **result)
 		goto out;
 	schedule(&command_sched);
 	*result = exec_task.result_buf;
-	btr_remove_node(exec_task.btrn);
+	btr_remove_node(&exec_task.btrn);
 	client_disconnect(ct);
 	ret = 1;
 out:
-	btr_free_node(exec_task.btrn);
+	btr_remove_node(&exec_task.btrn);
 	if (ret < 0)
 		free(exec_task.result_buf);
 	return ret;
@@ -446,11 +445,9 @@ static int client_i9e_line_handler(char *line)
 	int ret;
 
 	client_disconnect(ct);
-	if (!line || !*line)
-		return 0;
-	PARA_DEBUG_LOG("line handler: %s\n", line);
+	PARA_DEBUG_LOG("line: %s\n", line);
 	ret = make_client_argv(line);
-	if (ret < 0)
+	if (ret <= 0)
 		return ret;
 	ret = client_connect(ct, &sched, NULL, NULL);
 	if (ret < 0)
@@ -478,7 +475,7 @@ __noreturn static void interactive_session(void)
 		.completers = completers,
 	};
 
-	PARA_NOTICE_LOG("\n%s\n", VERSION_TEXT("client"));
+	PARA_NOTICE_LOG("\n%s\n", version_text("client"));
 	if (ct->conf.history_file_given)
 		history_file = para_strdup(ct->conf.history_file_arg);
 	else {
@@ -531,23 +528,21 @@ __noreturn static void print_completions(void)
 
 #endif /* HAVE_READLINE */
 
-static void supervisor_post_select(struct sched *s, struct task *t)
+static int supervisor_post_select(struct sched *s, __a_unused struct task *t)
 {
-	if (ct->task.error < 0) {
-		t->error = ct->task.error;
-		return;
-	}
+	if (ct->task.error < 0)
+		return ct->task.error;
 	if (ct->status == CL_SENDING) {
 		stdin_set_defaults(&sit);
 		register_task(s, &sit.task);
-		t->error = -E_TASK_STARTED;
-		return;
+		return -E_TASK_STARTED;
 	}
 	if (ct->status == CL_RECEIVING) {
 		stdout_set_defaults(&sot);
 		register_task(s, &sot.task);
-		t->error = -E_TASK_STARTED; return;
+		return -E_TASK_STARTED;
 	}
+	return 0;
 }
 
 static struct task svt = {
@@ -612,14 +607,14 @@ int main(int argc, char *argv[])
 		case -E_BTR_EOF:
 			ret = 0;
 			break;
-		default: ret = ct->task.error;
+		default: ret = -E_SERVER_CMD_FAILURE;
 		}
 	}
 out:
 	if (ret < 0)
 		PARA_ERROR_LOG("%s\n", para_strerror(-ret));
 	client_close(ct);
-	btr_free_node(sit.btrn);
-	btr_free_node(sot.btrn);
+	btr_remove_node(&sit.btrn);
+	btr_remove_node(&sot.btrn);
 	return ret < 0? EXIT_FAILURE : EXIT_SUCCESS;
 }