X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=client_common.c;h=d13892599cd4b503c50164f9a7010ab40c6d2016;hp=409c51df5973d51ec61f04091b322203c3c9a9e0;hb=d830824b39d538a9311ed8a490b8265dc2caa73a;hpb=ef94bc193cdfc8076069ef1fa38cd21f5a3402e7 diff --git a/client_common.c b/client_common.c index 409c51df..d1389259 100644 --- a/client_common.c +++ b/client_common.c @@ -50,8 +50,10 @@ void client_close(struct private_client_data *pcd) { if (pcd) return; - if (pcd->fd >= 0) + if (pcd->fd >= 0) { + disable_crypt(pcd->fd); close(pcd->fd); + } free(pcd->user); free(pcd->config_file); free(pcd->key_file); @@ -129,13 +131,13 @@ void client_pre_select(struct sched *s, struct task *t) pcd->check_w = 1; return; - case CL_RECEIVING_SERVER_OUTPUT: + case CL_RECEIVING: if (pcd->loaded < CLIENT_BUFSIZE - 1) { para_fd_set(pcd->fd, &s->rfds, &s->max_fileno); pcd->check_r = 1; } return; - case CL_SENDING_STDIN: + case CL_SENDING: if (*pcd->in_loaded) { PARA_INFO_LOG("loaded: %zd\n", *pcd->in_loaded); para_fd_set(pcd->fd, &s->wfds, &s->max_fileno); @@ -269,21 +271,18 @@ void client_post_select(struct sched *s, struct task *t) return; t->ret = -E_HANDSHAKE_COMPLETE; if (strstr(pcd->buf, AWAITING_DATA_MSG)) - pcd->status = CL_SENDING_STDIN; + pcd->status = CL_SENDING; else - pcd->status = CL_RECEIVING_SERVER_OUTPUT; + pcd->status = CL_RECEIVING; return; - case CL_SENDING_STDIN: /* FIXME: might block */ + case CL_SENDING: /* FIXME: might block */ PARA_INFO_LOG("loaded: %zd\n", *pcd->in_loaded); t->ret = send_bin_buffer(pcd->fd, pcd->inbuf, *pcd->in_loaded); - if (t->ret <= 0) { - if (!t->ret) - t->ret = 1; + if (t->ret < 0) return; - } *pcd->in_loaded = 0; /* FIXME: short writes */ return; - case CL_RECEIVING_SERVER_OUTPUT: + case CL_RECEIVING: t->ret = client_recv_buffer(pcd); return; } @@ -296,29 +295,32 @@ int client_open(struct private_client_data *pcd) struct hostent *he; struct sockaddr_in their_addr; + pcd->fd = -1; ret = get_host_info(pcd->conf.hostname_arg, &he); if (ret < 0) - goto out; + goto err_out; /* get new socket */ ret = get_socket(); if (ret < 0) - goto out; + goto err_out; pcd->fd = ret; /* init their_addr */ init_sockaddr(&their_addr, pcd->conf.server_port_arg, he); ret = para_connect(pcd->fd, &their_addr); if (ret < 0) - goto out; + goto err_out; pcd->status = CL_CONNECTED; ret = mark_fd_nonblock(pcd->fd); if (ret < 0) - goto out; + goto err_out; pcd->task.pre_select = client_pre_select; pcd->task.post_select = client_post_select; pcd->task.private_data = pcd; sprintf(pcd->task.status, "client"); register_task(&pcd->task); - ret = 1; -out: + return 1; +err_out: + if (pcd->fd >= 0) + close(pcd->fd); return ret; }