X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=client_common.c;h=d13892599cd4b503c50164f9a7010ab40c6d2016;hp=b77c192f3a1c31bc0792fd427b39e21518c2fbd1;hb=b3fd38bd1965ca8fec37cdd94552dc0f62f41372;hpb=eb0ecb54495e6486b44e7bb6c5d07ed94ceb0405

diff --git a/client_common.c b/client_common.c
index b77c192f..d1389259 100644
--- a/client_common.c
+++ b/client_common.c
@@ -278,11 +278,8 @@ void client_post_select(struct sched *s, struct task *t)
 	case CL_SENDING: /* FIXME: might block */
 		PARA_INFO_LOG("loaded: %zd\n", *pcd->in_loaded);
 		t->ret = send_bin_buffer(pcd->fd, pcd->inbuf, *pcd->in_loaded);
-		if (t->ret <= 0) {
-			if (!t->ret)
-				t->ret = 1;
+		if (t->ret < 0)
 			return;
-		}
 		*pcd->in_loaded = 0; /* FIXME: short writes */
 		return;
 	case CL_RECEIVING:
@@ -298,29 +295,32 @@ int client_open(struct private_client_data *pcd)
 	struct hostent *he;
 	struct sockaddr_in their_addr;
 
+	pcd->fd = -1;
 	ret = get_host_info(pcd->conf.hostname_arg, &he);
 	if (ret < 0)
-		goto out;
+		goto err_out;
 	/* get new socket */
 	ret = get_socket();
 	if (ret < 0)
-		goto out;
+		goto err_out;
 	pcd->fd = ret;
 	/* init their_addr */
 	init_sockaddr(&their_addr, pcd->conf.server_port_arg, he);
 	ret = para_connect(pcd->fd, &their_addr);
 	if (ret < 0)
-		goto out;
+		goto err_out;
 	pcd->status = CL_CONNECTED;
 	ret = mark_fd_nonblock(pcd->fd);
 	if (ret < 0)
-		goto out;
+		goto err_out;
 	pcd->task.pre_select = client_pre_select;
 	pcd->task.post_select = client_post_select;
 	pcd->task.private_data = pcd;
 	sprintf(pcd->task.status, "client");
 	register_task(&pcd->task);
-	ret = 1;
-out:
+	return 1;
+err_out:
+	if (pcd->fd >= 0)
+		close(pcd->fd);
 	return ret;
 }