X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=command.c;h=bde1458776856d26be371da2e309fb21354c5078;hp=46ede2fe825a9c10c86f59dd6c4e2f244d653468;hb=f60abbe18364a4368fd756f48c79af67d377fca7;hpb=b85ea5b925b31e2aeddf6c69d8ae8a89f8038c78 diff --git a/command.c b/command.c index 46ede2fe..bde14587 100644 --- a/command.c +++ b/command.c @@ -75,13 +75,6 @@ static void dummy(__a_unused int s) { } -static void mmd_dup(struct misc_meta_data *new_mmd) -{ - mutex_lock(mmd_mutex); - *new_mmd = *mmd; - mutex_unlock(mmd_mutex); -} - /* * Compute human readable vss status text. * @@ -533,7 +526,13 @@ static int com_stat(struct command_context *cc) if (i != cc->argc) return -E_COMMAND_SYNTAX; for (;;) { - mmd_dup(nmmd); + /* + * Copy the mmd structure to minimize the time we hold the mmd + * lock. + */ + mutex_lock(mmd_mutex); + *nmmd = *mmd; + mutex_unlock(mmd_mutex); ret = get_status(nmmd, parser_friendly, &s); ret = send_sb(&cc->scc, s, ret, SBD_OUTPUT, false); if (ret < 0)