X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=command.c;h=cba2afb40464a5373ef2320f65b3966845ba357d;hp=077c159d571240815072a34c426f230f21a0c897;hb=7c19c1eab09b846325f20f49cf4d305e46917b83;hpb=8eb77a20423c3dcc44c4584a082e981391272cb2

diff --git a/command.c b/command.c
index 077c159d..cba2afb4 100644
--- a/command.c
+++ b/command.c
@@ -1,8 +1,4 @@
-/*
- * Copyright (C) 1997 Andre Noll <maan@tuebingen.mpg.de>
- *
- * Licensed under the GPL v2. For licencing details see COPYING.
- */
+/* Copyright (C) 1997 Andre Noll <maan@tuebingen.mpg.de>, see file COPYING. */
 
 /** \file command.c Client authentication and server commands. */
 
@@ -111,14 +107,14 @@ static unsigned get_status(struct misc_meta_data *nmmd, bool parser_friendly,
 	 * clang is not smart enough to prove this and complains nevertheless.
 	 * Casting the return value to void silences clang.
 	 */
-	(void)WRITE_STATUS_ITEM(&b, SI_STATUS, "%s\n", status);
-	(void)WRITE_STATUS_ITEM(&b, SI_STATUS_FLAGS, "%s\n", flags);
-	(void)WRITE_STATUS_ITEM(&b, SI_OFFSET, "%li\n", offset);
-	(void)WRITE_STATUS_ITEM(&b, SI_AFS_MODE, "%s\n", mmd->afs_mode_string);
-	(void)WRITE_STATUS_ITEM(&b, SI_STREAM_START, "%lu.%lu\n",
+	(void)WRITE_STATUS_ITEM(&b, SI_status, "%s\n", status);
+	(void)WRITE_STATUS_ITEM(&b, SI_status_flags, "%s\n", flags);
+	(void)WRITE_STATUS_ITEM(&b, SI_offset, "%li\n", offset);
+	(void)WRITE_STATUS_ITEM(&b, SI_afs_mode, "%s\n", mmd->afs_mode_string);
+	(void)WRITE_STATUS_ITEM(&b, SI_stream_start, "%lu.%lu\n",
 		(long unsigned)nmmd->stream_start.tv_sec,
 		(long unsigned)nmmd->stream_start.tv_usec);
-	(void)WRITE_STATUS_ITEM(&b, SI_CURRENT_TIME, "%lu.%lu\n",
+	(void)WRITE_STATUS_ITEM(&b, SI_current_time, "%lu.%lu\n",
 		(long unsigned)current_time.tv_sec,
 		(long unsigned)current_time.tv_usec);
 	free(flags);
@@ -398,7 +394,7 @@ static int com_si(struct command_context *cc,
 		"supported audio formats: %s\n",
 		ut, mmd->num_played,
 		(int)getppid(),
-		(int)mmd->afs_pid,
+		(int)afs_pid,
 		mmd->active_connections,
 		mmd->num_commands,
 		mmd->num_connects,
@@ -426,36 +422,36 @@ EXPORT_SERVER_CMD_HANDLER(version);
 
 /** These status items are cleared if no audio file is currently open. */
 #define EMPTY_STATUS_ITEMS \
-	ITEM(PATH) \
-	ITEM(DIRECTORY) \
-	ITEM(BASENAME) \
-	ITEM(SCORE) \
-	ITEM(ATTRIBUTES_BITMAP) \
-	ITEM(ATTRIBUTES_TXT) \
-	ITEM(HASH) \
-	ITEM(IMAGE_ID) \
-	ITEM(IMAGE_NAME) \
-	ITEM(LYRICS_ID) \
-	ITEM(LYRICS_NAME) \
-	ITEM(BITRATE) \
-	ITEM(FORMAT) \
-	ITEM(FREQUENCY) \
-	ITEM(CHANNELS) \
-	ITEM(DURATION) \
-	ITEM(SECONDS_TOTAL) \
-	ITEM(NUM_PLAYED) \
-	ITEM(LAST_PLAYED) \
-	ITEM(TECHINFO) \
-	ITEM(ARTIST) \
-	ITEM(TITLE) \
-	ITEM(YEAR) \
-	ITEM(ALBUM) \
-	ITEM(COMMENT) \
-	ITEM(MTIME) \
-	ITEM(FILE_SIZE) \
-	ITEM(CHUNK_TIME) \
-	ITEM(NUM_CHUNKS) \
-	ITEM(AMPLIFICATION) \
+	ITEM(path) \
+	ITEM(directory) \
+	ITEM(basename) \
+	ITEM(score) \
+	ITEM(attributes_bitmap) \
+	ITEM(attributes_txt) \
+	ITEM(hash) \
+	ITEM(image_id) \
+	ITEM(image_name) \
+	ITEM(lyrics_id) \
+	ITEM(lyrics_name) \
+	ITEM(bitrate) \
+	ITEM(format) \
+	ITEM(frequency) \
+	ITEM(channels) \
+	ITEM(duration) \
+	ITEM(seconds_total) \
+	ITEM(num_played) \
+	ITEM(last_played) \
+	ITEM(techinfo) \
+	ITEM(artist) \
+	ITEM(title) \
+	ITEM(year) \
+	ITEM(album) \
+	ITEM(comment) \
+	ITEM(mtime) \
+	ITEM(file_size) \
+	ITEM(chunk_time) \
+	ITEM(num_chunks) \
+	ITEM(amplification) \
 
 /*
  * Create a set of audio-file related status items with empty values. These are
@@ -744,12 +740,11 @@ out:
 }
 EXPORT_SERVER_CMD_HANDLER(jmp);
 
-static int com_tasks(struct command_context *cc,
+/* deprecated, does nothing */
+static int com_tasks(__a_unused struct command_context *cc,
 		__a_unused struct lls_parse_result *lpr)
 {
-	char *tl = server_get_tasks();
-	assert(tl);
-	return send_sb(&cc->scc, tl, strlen(tl), SBD_OUTPUT, false);
+	return 1;
 }
 EXPORT_SERVER_CMD_HANDLER(tasks);
 
@@ -808,8 +803,7 @@ out:
 
 #define HANDSHAKE_BUFSIZE 4096
 
-static int run_command(struct command_context *cc, struct iovec *iov,
-		const char *peername)
+static int run_command(struct command_context *cc, struct iovec *iov)
 {
 	int ret, i, argc;
 	char *p, *end, **argv;
@@ -842,8 +836,8 @@ static int run_command(struct command_context *cc, struct iovec *iov,
 		p += strlen(p) + 1;
 	}
 	argv[argc] = NULL;
-	PARA_NOTICE_LOG("calling com_%s() for %s@%s\n", lls_command_name(lcmd),
-		cc->u->name, peername);
+	PARA_NOTICE_LOG("calling com_%s() for user %s\n",
+		lls_command_name(lcmd), cc->u->name);
 	ret = lls(lls_parse(argc, argv, lcmd, &lpr, &errctx));
 	if (ret >= 0) {
 		const struct server_cmd_user_data *ud = lls_user_data(lcmd);
@@ -864,7 +858,6 @@ static int run_command(struct command_context *cc, struct iovec *iov,
  * Perform user authentication and execute a command.
  *
  * \param fd The file descriptor to send output to.
- * \param peername Identifies the connecting peer.
  *
  * Whenever para_server accepts an incoming tcp connection on the port it
  * listens on, it forks and the resulting child calls this function.
@@ -879,13 +872,13 @@ static int run_command(struct command_context *cc, struct iovec *iov,
  * permissions to execute that command, the function calls the corresponding
  * command handler which does argument checking and further processing.
  *
- * In order to cope with a DOS attacks, a timeout is set up which terminates
+ * In order to cope with DOS attacks, a timeout is set up which terminates
  * the function if the connection was not authenticated when the timeout
  * expires.
  *
  * \sa alarm(2), \ref crypt.c, \ref crypt.h.
  */
-__noreturn void handle_connect(int fd, const char *peername)
+__noreturn void handle_connect(int fd)
 {
 	int ret;
 	unsigned char rand_buf[CHALLENGE_SIZE + 2 * SESSION_KEY_LEN];
@@ -971,7 +964,7 @@ __noreturn void handle_connect(int fd, const char *peername)
 	ret = recv_sb(&cc->scc, SBD_COMMAND, MAX_COMMAND_LEN, &iov);
 	if (ret < 0)
 		goto net_err;
-	ret = run_command(cc, &iov, peername);
+	ret = run_command(cc, &iov);
 	free(iov.iov_base);
 	if (ret < 0)
 		goto err_out;