X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=compress_filter.c;h=15bed6dfa33c896421ab17a89ec426669cf4b025;hp=658976423faa1115b710102633beff6f3093151c;hb=62c0894fbb589dd45e69b7d9ef1fd152a9960d62;hpb=764e71ceb1e188086c08e38dfd52d45b67dc15ba

diff --git a/compress_filter.c b/compress_filter.c
index 65897642..15bed6df 100644
--- a/compress_filter.c
+++ b/compress_filter.c
@@ -1,8 +1,4 @@
-/*
- * Copyright (C) 2005 Andre Noll <maan@tuebingen.mpg.de>
- *
- * Licensed under the GPL v2. For licencing details see COPYING.
- */
+/* Copyright (C) 2005 Andre Noll <maan@tuebingen.mpg.de>, see file COPYING. */
 
 /** \file compress_filter.c Paraslash's dynamic audio range compressor. */
 
@@ -52,8 +48,7 @@ static int compress_post_select(__a_unused struct sched *s, void *context)
 	size_t length, i;
 	int16_t *ip, *op;
 	uint32_t inertia = U32_OPTVAL(INERTIA, fn->lpr);
-	unsigned gain_shift = inertia + U32_OPTVAL(DAMP, fn->lpr),
-		mask = (1 << U32_OPTVAL(BLOCKSIZE, fn->lpr)) - 1;
+	unsigned mask = (1U << U32_OPTVAL(BLOCKSIZE, fn->lpr)) - 1U;
 	//inplace = false;
 next_buffer:
 	ret = btr_node_status(btrn, fn->min_iqs, BTR_NT_INTERNAL);
@@ -82,19 +77,22 @@ next_buffer:
 			neg = true;
 		}
 		sample *= pcd->current_gain;
-		sample >>= gain_shift;
+		sample >>= inertia + 1;
 		if (sample > 32767) { /* clip */
+			PARA_WARNING_LOG("clip: %d\n", sample);
 			sample = 32767;
 			pcd->current_gain = (3 * pcd->current_gain +
 				(1 << inertia)) / 4;
 			pcd->peak = 0;
 		} else if (sample > pcd->peak)
 			pcd->peak = sample;
+		sample >>= U32_OPTVAL(DAMP, fn->lpr);
 		op[i] = neg? -sample : sample;
 		if (++pcd->num_samples & mask)
 			continue;
 //		PARA_DEBUG_LOG("gain: %u, peak: %u\n", pcd->current_gain,
 //			pcd->peak);
+
 		if (pcd->peak < U32_OPTVAL(TARGET_LEVEL, fn->lpr)) {
 			if (pcd->current_gain < pcd->max_gain)
 				pcd->current_gain++;
@@ -125,10 +123,43 @@ static void compress_open(struct filter_node *fn)
 	fn->private_data = pcd;
 	fn->min_iqs = 2; /* 16 bit audio */
 	pcd->current_gain = 1U << inertia;
-	pcd->max_gain = 1U << (inertia + aggressiveness);
+	pcd->max_gain = (1U << inertia) * (1.0 + 3.0 * aggressiveness / 10.0);
+}
+
+static void *compress_setup(const struct lls_parse_result *lpr)
+{
+	uint32_t val;
+
+	val = U32_OPTVAL(BLOCKSIZE, lpr);
+	if (val == 0 || val > 31) {
+		PARA_EMERG_LOG("blocksize (%u) out of range\n", val);
+		exit(EXIT_FAILURE);
+	}
+	val = U32_OPTVAL(AGGRESSIVENESS, lpr);
+	if (val > 10) {
+		PARA_EMERG_LOG("aggressiveness (%u) out of range\n", val);
+		exit(EXIT_FAILURE);
+	}
+	val = U32_OPTVAL(INERTIA, lpr);
+	if (val == 0 || val > 14) {
+		PARA_EMERG_LOG("inertia (%u) out of range\n", val);
+		exit(EXIT_FAILURE);
+	}
+	val = U32_OPTVAL(TARGET_LEVEL, lpr);
+	if (val > 32767) {
+		PARA_EMERG_LOG("target-level (%u) out of range\n", val);
+		exit(EXIT_FAILURE);
+	}
+	val = U32_OPTVAL(DAMP, lpr);
+	if (val > 16) {
+		PARA_EMERG_LOG("damp (%u) out of range\n", val);
+		exit(EXIT_FAILURE);
+	}
+	return NULL; /* no need for a config structure */
 }
 
 const struct filter lsg_filter_cmd_com_compress_user_data = {
+	.setup = compress_setup,
 	.open = compress_open,
 	.close = compress_close,
 	.pre_select = generic_filter_pre_select,