X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=crypt_common.c;h=8e52603fffc12ba701ec5a8456634cd751ea4d41;hp=6c71d7e3716829d90485894bc261ee867589d7bf;hb=6be2a7de19d8fe01f67207d8412fba7b468c6b11;hpb=77a0aff9b99cc7cfb6fef28a633300bf709a8d47

diff --git a/crypt_common.c b/crypt_common.c
index 6c71d7e3..8e52603f 100644
--- a/crypt_common.c
+++ b/crypt_common.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2013 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005 Andre Noll <maan@tuebingen.mpg.de>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -90,41 +90,31 @@ int base64_decode(char const *src, unsigned char *target, size_t targsize)
 
 		switch (state) {
 		case 0:
-			if (target) {
-				if (tarindex >= targsize)
-					return -E_BASE64;
-				target[tarindex] = (pos - Base64) << 2;
-			}
+			if (tarindex >= targsize)
+				return -E_BASE64;
+			target[tarindex] = (pos - Base64) << 2;
 			state = 1;
 			break;
 		case 1:
-			if (target) {
-				if (tarindex + 1 >= targsize)
-					return -E_BASE64;
-				target[tarindex]   |=  (pos - Base64) >> 4;
-				target[tarindex+1]  = ((pos - Base64) & 0x0f)
-							<< 4 ;
-			}
+			if (tarindex + 1 >= targsize)
+				return -E_BASE64;
+			target[tarindex] |= (pos - Base64) >> 4;
+			target[tarindex + 1] = ((pos - Base64) & 0x0f) << 4;
 			tarindex++;
 			state = 2;
 			break;
 		case 2:
-			if (target) {
-				if (tarindex + 1 >= targsize)
-					return -E_BASE64;
-				target[tarindex]   |=  (pos - Base64) >> 2;
-				target[tarindex+1]  = ((pos - Base64) & 0x03)
-							<< 6;
-			}
+			if (tarindex + 1 >= targsize)
+				return -E_BASE64;
+			target[tarindex] |= (pos - Base64) >> 2;
+			target[tarindex + 1] = ((pos - Base64) & 0x03) << 6;
 			tarindex++;
 			state = 3;
 			break;
 		case 3:
-			if (target) {
-				if (tarindex >= targsize)
-					return -E_BASE64;
-				target[tarindex] |= (pos - Base64);
-			}
+			if (tarindex >= targsize)
+				return -E_BASE64;
+			target[tarindex] |= pos - Base64;
 			tarindex++;
 			state = 0;
 			break;
@@ -170,7 +160,7 @@ int base64_decode(char const *src, unsigned char *target, size_t targsize)
 			 * zeros.  If we don't check them, they become a
 			 * subliminal channel.
 			 */
-			if (target && target[tarindex] != 0)
+			if (target[tarindex] != 0)
 				return -E_BASE64;
 		}
 	} else {
@@ -266,7 +256,7 @@ int check_ssh_key_header(const unsigned char *blob, int blen)
 		return -E_SSH_KEY_HEADER;
 	if (rlen < strlen(KEY_TYPE_TXT))
 		return -E_SSH_KEY_HEADER;
-	PARA_DEBUG_LOG("type: %s, rlen: %d\n", p, rlen);
+	PARA_DEBUG_LOG("type: %s, rlen: %u\n", p, rlen);
 	if (strncmp((char *)p, KEY_TYPE_TXT, strlen(KEY_TYPE_TXT)))
 		return -E_SSH_KEY_HEADER;
 	return 4 + rlen;