X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=dccp_recv.c;h=a9eab006bd3cf0f0d4ddc6e5ac41ba6beb30199a;hp=647d31a671c4e87fb0eb999385cf21379374b10e;hb=3150a0caa27a34d44556fb77f4a5aebc3d978580;hpb=ed0c68b07ddbc130e033035baa1cc0862e511b46

diff --git a/dccp_recv.c b/dccp_recv.c
index 647d31a6..a9eab006 100644
--- a/dccp_recv.c
+++ b/dccp_recv.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2009 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2011 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -13,7 +13,6 @@
 
 #include <regex.h>
 #include <sys/types.h>
-#include <dirent.h>
 
 #include "para.h"
 #include "error.h"
@@ -39,30 +38,42 @@ struct private_dccp_recv_data {
 	struct btr_pool *btrp;
 };
 
-
 static void dccp_recv_close(struct receiver_node *rn)
 {
-
 	struct private_dccp_recv_data *pdd = rn->private_data;
 
-	if (pdd && pdd->fd > 0)
+	if (!pdd)
+		return;
+	if (pdd->fd > 0)
 		close(pdd->fd);
 	btr_pool_free(pdd->btrp);
-	free(rn->private_data);
+	free(pdd);
 	rn->private_data = NULL;
 }
 
-
 static int dccp_recv_open(struct receiver_node *rn)
 {
 	struct private_dccp_recv_data *pdd;
 	struct dccp_recv_args_info *conf = rn->conf;
-	int fd, ret = makesock(AF_UNSPEC, IPPROTO_DCCP, 0, conf->host_arg,
-	                       conf->port_arg, NULL);
+	struct flowopts *fo = NULL;
+	uint8_t *ccids = NULL;
+	int fd, ret, i;
 
-	if (ret < 0)
-		return ret;
-	fd = ret;
+	/* Copy CCID preference list (u8 array required) */
+	if (conf->ccid_given) {
+		ccids = para_malloc(conf->ccid_given);
+		fo    = flowopt_new();
+
+		for (i = 0; i < conf->ccid_given; i++)
+			ccids[i] = conf->ccid_arg[i];
+
+		OPT_ADD(fo, SOL_DCCP, DCCP_SOCKOPT_CCID, ccids, i);
+	}
+
+	fd = makesock(IPPROTO_DCCP, 0, conf->host_arg, conf->port_arg, fo);
+	free(ccids);
+	if (fd < 0)
+		return fd;
 	/*
 	 * Disable unused CCIDs: the receiver does not send any application
 	 * data to the server. By shutting down this unused path we reduce
@@ -85,11 +96,38 @@ err:
 	return ret;
 }
 
+/**
+ * Check whether the host supports the requested 'ccid' arguments.
+ * \param conf DCCP receiver arguments.
+ * \return True if all CCIDs requested in \a conf are supported.
+ */
+static bool dccp_recv_ccid_support_check(struct dccp_recv_args_info *conf)
+{
+	uint8_t *ccids;
+	int i, j, nccids;
+
+	nccids = dccp_available_ccids(&ccids);
+	if (nccids <= 0)
+		return false;
+
+	for (i = 0; i < conf->ccid_given; i++) {
+		for (j = 0; j < nccids && ccids[j] != conf->ccid_arg[i]; j++)
+			;
+		if (j == nccids) {
+			PARA_ERROR_LOG("'CCID-%d' not supported on this host.\n",
+					conf->ccid_arg[i]);
+			return false;
+		}
+	}
+	return true;
+}
+
 static void *dccp_recv_parse_config(int argc, char **argv)
 {
-	struct dccp_recv_args_info *tmp = para_calloc(sizeof(struct dccp_recv_args_info));
+	struct dccp_recv_args_info *tmp = para_calloc(sizeof(*tmp));
 
-	if (!dccp_recv_cmdline_parser(argc, argv, tmp))
+	if (!dccp_recv_cmdline_parser(argc, argv, tmp) &&
+	    dccp_recv_ccid_support_check(tmp))
 		return tmp;
 	free(tmp);
 	return NULL;
@@ -113,31 +151,27 @@ static void dccp_recv_post_select(struct sched *s, struct task *t)
 	struct btr_node *btrn = rn->btrn;
 	struct iovec iov[2];
 	int ret, iovcnt;
+	size_t num_bytes;
 
 	ret = btr_node_status(btrn, 0, BTR_NT_ROOT);
-	if (ret < 0)
-		goto err;
-	if (ret == 0)
-		return;
-	if (!FD_ISSET(pdd->fd, &s->rfds))
-		return; /* nothing to do */
+	if (ret <= 0)
+		goto out;
 	iovcnt = btr_pool_get_buffers(pdd->btrp, iov);
 	ret = -E_DCCP_OVERRUN;
 	if (iovcnt == 0)
-		goto err;
-	ret = para_readv(pdd->fd, iov, iovcnt);
-	if (ret == 0)
-		ret = -E_RECV_EOF;
-	if (ret < 0)
-		goto err;
-	if (ret <= iov[0].iov_len) /* only the first buffer was filled */
-		btr_add_output_pool(pdd->btrp, ret, btrn);
+		goto out;
+	ret = readv_nonblock(pdd->fd, iov, iovcnt, &s->rfds, &num_bytes);
+	if (num_bytes == 0)
+		goto out;
+	if (num_bytes <= iov[0].iov_len) /* only the first buffer was filled */
+		btr_add_output_pool(pdd->btrp, num_bytes, btrn);
 	else { /* both buffers contain data */
 		btr_add_output_pool(pdd->btrp, iov[0].iov_len, btrn);
-		btr_add_output_pool(pdd->btrp, ret - iov[0].iov_len, btrn);
+		btr_add_output_pool(pdd->btrp, num_bytes - iov[0].iov_len, btrn);
 	}
-	return;
-err:
+out:
+	if (ret >= 0)
+		return;
 	btr_remove_node(rn->btrn);
 	t->error = ret;
 }