X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=dccp_recv.c;h=c751f2f7ce5d85464d506c8c6582556bb424aa7d;hp=f71a7253a0296e8c0f849147287b5cede93233e0;hb=aa74a903545250506fd4c29791e6f4aef3a01c41;hpb=e8089cd5efad59a5eec689117acf563a38b8c6c7

diff --git a/dccp_recv.c b/dccp_recv.c
index f71a7253..c751f2f7 100644
--- a/dccp_recv.c
+++ b/dccp_recv.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2010 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2013 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -13,49 +13,29 @@
 
 #include <regex.h>
 #include <sys/types.h>
-#include <dirent.h>
 
 #include "para.h"
 #include "error.h"
 #include "list.h"
 #include "sched.h"
 #include "ggo.h"
+#include "buffer_tree.h"
 #include "recv.h"
 #include "string.h"
 #include "net.h"
 #include "fd.h"
-#include "buffer_tree.h"
 
 #include "dccp_recv.cmdline.h"
 
-/**
- * data specific to the dccp receiver
- *
- * \sa receiver receiver_node
- */
-struct private_dccp_recv_data {
-	/** the file descriptor for the dccp socket */
-	int fd;
-	struct btr_pool *btrp;
-};
-
-
 static void dccp_recv_close(struct receiver_node *rn)
 {
-
-	struct private_dccp_recv_data *pdd = rn->private_data;
-
-	if (pdd && pdd->fd > 0)
-		close(pdd->fd);
-	btr_pool_free(pdd->btrp);
-	free(rn->private_data);
-	rn->private_data = NULL;
+	if (rn->fd > 0)
+		close(rn->fd);
+	btr_pool_free(rn->btrp);
 }
 
-
 static int dccp_recv_open(struct receiver_node *rn)
 {
-	struct private_dccp_recv_data *pdd;
 	struct dccp_recv_args_info *conf = rn->conf;
 	struct flowopts *fo = NULL;
 	uint8_t *ccids = NULL;
@@ -89,9 +69,8 @@ static int dccp_recv_open(struct receiver_node *rn)
 	ret = mark_fd_nonblocking(fd);
 	if (ret < 0)
 		goto err;
-	rn->private_data = pdd = para_calloc(sizeof(struct private_dccp_recv_data));
-	pdd->btrp = btr_pool_new("dccp_recv", 320 * 1024);
-	pdd->fd = fd;
+	rn->btrp = btr_pool_new("dccp_recv", 320 * 1024);
+	rn->fd = fd;
 	return 1;
 err:
 	close(fd);
@@ -128,61 +107,53 @@ static void *dccp_recv_parse_config(int argc, char **argv)
 {
 	struct dccp_recv_args_info *tmp = para_calloc(sizeof(*tmp));
 
-	if (!dccp_recv_cmdline_parser(argc, argv, tmp) &&
-	    dccp_recv_ccid_support_check(tmp))
-		return tmp;
-	free(tmp);
-	return NULL;
+	dccp_recv_cmdline_parser(argc, argv, tmp);
+	if (!dccp_recv_ccid_support_check(tmp))
+		exit(EXIT_FAILURE);
+	return tmp;
 }
 
 static void dccp_recv_pre_select(struct sched *s, struct task *t)
 {
 	struct receiver_node *rn = container_of(t, struct receiver_node, task);
-	struct private_dccp_recv_data *pdd = rn->private_data;
 
 	t->error = 0;
 	if (generic_recv_pre_select(s, t) <= 0)
 		return;
-	para_fd_set(pdd->fd, &s->rfds, &s->max_fileno);
+	para_fd_set(rn->fd, &s->rfds, &s->max_fileno);
 }
 
-static void dccp_recv_post_select(struct sched *s, struct task *t)
+static int dccp_recv_post_select(struct sched *s, struct task *t)
 {
 	struct receiver_node *rn = container_of(t, struct receiver_node, task);
-	struct private_dccp_recv_data *pdd = rn->private_data;
 	struct btr_node *btrn = rn->btrn;
 	struct iovec iov[2];
 	int ret, iovcnt;
+	size_t num_bytes;
 
-	ret = btr_node_status(btrn, 0, BTR_NT_ROOT);
+	ret = task_get_notification(t);
 	if (ret < 0)
-		goto err;
-	if (ret == 0)
-		return;
-	if (!FD_ISSET(pdd->fd, &s->rfds))
-		return; /* nothing to do */
-	iovcnt = btr_pool_get_buffers(pdd->btrp, iov);
+		goto out;
+	ret = btr_node_status(btrn, 0, BTR_NT_ROOT);
+	if (ret <= 0)
+		goto out;
+	iovcnt = btr_pool_get_buffers(rn->btrp, iov);
 	ret = -E_DCCP_OVERRUN;
 	if (iovcnt == 0)
-		goto err;
-	ret = para_readv(pdd->fd, iov, iovcnt);
-	/* EAGAIN is possible even if FD_ISSET */
-	if (ret < 0 && is_errno(-ret, EAGAIN))
-		return;
-	if (ret == 0)
-		ret = -E_RECV_EOF;
-	if (ret < 0)
-		goto err;
-	if (ret <= iov[0].iov_len) /* only the first buffer was filled */
-		btr_add_output_pool(pdd->btrp, ret, btrn);
+		goto out;
+	ret = readv_nonblock(rn->fd, iov, iovcnt, &s->rfds, &num_bytes);
+	if (num_bytes == 0)
+		goto out;
+	if (num_bytes <= iov[0].iov_len) /* only the first buffer was filled */
+		btr_add_output_pool(rn->btrp, num_bytes, btrn);
 	else { /* both buffers contain data */
-		btr_add_output_pool(pdd->btrp, iov[0].iov_len, btrn);
-		btr_add_output_pool(pdd->btrp, ret - iov[0].iov_len, btrn);
+		btr_add_output_pool(rn->btrp, iov[0].iov_len, btrn);
+		btr_add_output_pool(rn->btrp, num_bytes - iov[0].iov_len, btrn);
 	}
-	return;
-err:
-	btr_remove_node(rn->btrn);
-	t->error = ret;
+out:
+	if (ret < 0)
+		btr_remove_node(&rn->btrn);
+	return ret;
 }
 
 static void dccp_recv_free_config(void *conf)
@@ -209,9 +180,6 @@ void dccp_recv_init(struct receiver *r)
 	r->post_select = dccp_recv_post_select;
 	r->parse_config = dccp_recv_parse_config;
 	r->free_config = dccp_recv_free_config;
-	r->help = (struct ggo_help) {
-		.short_help = dccp_recv_args_info_help,
-		.detailed_help = dccp_recv_args_info_detailed_help
-	};
+	r->help = (struct ggo_help)DEFINE_GGO_HELP(dccp_recv);
 	dccp_recv_cmdline_parser_free(&dummy);
 }