X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=dccp_recv.c;h=ca3432a31de2fc3eaadf13572cef68358f85c0a2;hp=eb442f303483980aaf49dd31a85876dbcc675f97;hb=6fb1fc05a236d8732b0ae9581cc84d9958b3af76;hpb=3879481ddabc38236b9eee979a090c2a9bfa74d3 diff --git a/dccp_recv.c b/dccp_recv.c index eb442f30..ca3432a3 100644 --- a/dccp_recv.c +++ b/dccp_recv.c @@ -11,8 +11,13 @@ * (C) 2005 Ian McDonald */ +#include +#include #include #include +#include +#include +#include #include "para.h" #include "error.h" @@ -53,6 +58,7 @@ static int dccp_recv_open(struct receiver_node *rn) } fd = makesock(IPPROTO_DCCP, 0, conf->host_arg, conf->port_arg, fo); + flowopt_cleanup(fo); free(ccids); if (fd < 0) return fd; @@ -107,11 +113,10 @@ static void *dccp_recv_parse_config(int argc, char **argv) { struct dccp_recv_args_info *tmp = para_calloc(sizeof(*tmp)); - if (!dccp_recv_cmdline_parser(argc, argv, tmp) && - dccp_recv_ccid_support_check(tmp)) - return tmp; - free(tmp); - return NULL; + dccp_recv_cmdline_parser(argc, argv, tmp); + if (!dccp_recv_ccid_support_check(tmp)) + exit(EXIT_FAILURE); + return tmp; } static void dccp_recv_pre_select(struct sched *s, struct task *t) @@ -124,7 +129,7 @@ static void dccp_recv_pre_select(struct sched *s, struct task *t) para_fd_set(rn->fd, &s->rfds, &s->max_fileno); } -static void dccp_recv_post_select(struct sched *s, struct task *t) +static int dccp_recv_post_select(struct sched *s, struct task *t) { struct receiver_node *rn = container_of(t, struct receiver_node, task); struct btr_node *btrn = rn->btrn; @@ -152,10 +157,9 @@ static void dccp_recv_post_select(struct sched *s, struct task *t) btr_add_output_pool(rn->btrp, num_bytes - iov[0].iov_len, btrn); } out: - if (ret >= 0) - return; - btr_remove_node(&rn->btrn); - t->error = ret; + if (ret < 0) + btr_remove_node(&rn->btrn); + return ret; } static void dccp_recv_free_config(void *conf) @@ -182,9 +186,6 @@ void dccp_recv_init(struct receiver *r) r->post_select = dccp_recv_post_select; r->parse_config = dccp_recv_parse_config; r->free_config = dccp_recv_free_config; - r->help = (struct ggo_help) { - .short_help = dccp_recv_args_info_help, - .detailed_help = dccp_recv_args_info_detailed_help - }; + r->help = (struct ggo_help)DEFINE_GGO_HELP(dccp_recv); dccp_recv_cmdline_parser_free(&dummy); }