X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=error.h;h=ff85c8d18455e356f6e220c642b776570db86111;hp=5d5666c63285835691ca65e95411e7dfc40eb99e;hb=0b6e7a20c19d642f9d8e65683e1525c91dd3de39;hpb=0f4910b50116416fefb09ca67a615679067ef359

diff --git a/error.h b/error.h
index 5d5666c6..ff85c8d1 100644
--- a/error.h
+++ b/error.h
@@ -103,7 +103,7 @@ extern const char **para_errlist[];
 
 
 #define AFH_RECV_ERRORS \
-	PARA_ERROR(AFH_RECV_BAD_FILENAME, "invalid file name"), \
+	PARA_ERROR(AFH_RECV_BAD_FILENAME, "no file name given"), \
 
 
 #define OGG_AFH_COMMON_ERRORS \
@@ -246,7 +246,6 @@ extern const char **para_errlist[];
 
 #define MOOD_ERRORS \
 	PARA_ERROR(NO_MOOD, "no mood available"), \
-	PARA_ERROR(DUMMY_ROW, "attempted to access blob dummy object"), \
 
 
 #define MM_ERRORS \
@@ -261,6 +260,7 @@ extern const char **para_errlist[];
 
 #define BLOB_ERRORS \
 	PARA_ERROR(BLOB_SYNTAX, "blob syntax error"), \
+	PARA_ERROR(DUMMY_ROW, "attempted to access blob dummy object"), \
 
 
 #define PLAYLIST_ERRORS \
@@ -306,7 +306,6 @@ extern const char **para_errlist[];
 	PARA_ERROR(SERVER_EOF, "connection closed by para_server"), \
 	PARA_ERROR(SERVER_CMD_SUCCESS, "command terminated successfully"), \
 	PARA_ERROR(SERVER_CMD_FAILURE, "command failed"), \
-	PARA_ERROR(INCOMPAT_FEAT, "client/server incompatibility"), \
 
 
 #define NET_ERRORS \
@@ -396,6 +395,7 @@ extern const char **para_errlist[];
 	PARA_ERROR(SIZE_PREFIX, "bad size prefix"), \
 	PARA_ERROR(REGEX, "regular expression error"), \
 	PARA_ERROR(ARG_NOT_FOUND, "argument not found in arg vector"), \
+	PARA_ERROR(BAD_LL, "invalid loglevel"), \
 
 
 #define EXEC_ERRORS \
@@ -409,7 +409,7 @@ extern const char **para_errlist[];
 	PARA_ERROR(HEADER_FREQ, "invalid header frequency"), \
 	PARA_ERROR(HEADER_BITRATE, "invalid header bitrate"), \
 	PARA_ERROR(ID3_DETACH, "could not detach id3 frame"), \
-	PARA_ERROR(ID3_ATTACH, "could not atttach id3 frame"), \
+	PARA_ERROR(ID3_ATTACH, "could not attach id3 frame"), \
 	PARA_ERROR(ID3_SETENCODING, "could not set id3 text encoding field"), \
 	PARA_ERROR(ID3_SETSTRING, "could not set id3 string field"), \
 
@@ -418,7 +418,6 @@ extern const char **para_errlist[];
 	PARA_ERROR(MP4ASC, "audio spec config error"), \
 	PARA_ERROR(AAC_AFH_INIT, "failed to init aac decoder"), \
 	PARA_ERROR(MP4V2, "mp4v2 library error"), \
-	PARA_ERROR(NO_AUDIO_TRACK, "file contains no valid audio track"), \
 
 #define AAC_COMMON_ERRORS \
 	PARA_ERROR(ESDS, "did not find esds atom"), \
@@ -440,9 +439,10 @@ extern const char **para_errlist[];
 
 #define CRYPT_COMMON_ERRORS \
 	PARA_ERROR(SSH_KEY_HEADER, "ssh key header not found"), \
-	PARA_ERROR(BASE64, "failed to base64-decode ssh public key"), \
 	PARA_ERROR(KEY_PERM, "unprotected private key"), \
 
+#define BASE64_ERRORS \
+	PARA_ERROR(BASE64, "base64 decode error"), \
 
 #define CRYPT_ERRORS \
 	PARA_ERROR(PRIVATE_KEY, "can not read private key"), \
@@ -579,20 +579,8 @@ extern const char **para_errlist[];
 /** Set the osl error bit for the given number. */
 #define OSL_ERRNO_TO_PARA_ERROR(num) ((num) | (1 << OSL_ERROR_BIT))
 
-/** Check whether a given number is a system error number.
- *
- * \param num The value to be checked.
- * \param _errno The system error number.
- *
- * \return True if \a num is paraslash's representation of the system
- * error identified by \a _errno.
- */
-_static_inline_ bool is_errno(int num, int _errno)
-{
-	assert(num > 0 && _errno > 0);
-	return ERRNO_TO_PARA_ERROR(_errno) == num;
-}
 
+static const char *weak_osl_strerror(int) __attribute__ ((weakref("osl_strerror")));
 /**
  * Paraslash's version of strerror(3).
  *
@@ -603,12 +591,12 @@ _static_inline_ bool is_errno(int num, int _errno)
 _static_inline_ const char *para_strerror(int num)
 {
 	assert(num > 0);
-#ifdef _OSL_H
-	if (IS_OSL_ERROR(num))
-		return osl_strerror(num & ((1 << OSL_ERROR_BIT) - 1));
-#endif
+	if (IS_OSL_ERROR(num)) {
+		assert(weak_osl_strerror);
+		return weak_osl_strerror(num & ~(1U << OSL_ERROR_BIT));
+	}
 	if (IS_SYSTEM_ERROR(num))
-		return strerror(num & ((1 << SYSTEM_ERROR_BIT) - 1));
+		return strerror(num & ~(1U << SYSTEM_ERROR_BIT));
 	return para_errlist[ERRNUM_TO_SS(num)][ERRNUM_TO_INDEX(num)];
 }