X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=file_write.c;h=3286ea87a089363036cabe518a98ef16151e12ca;hp=50d3fae7651706cec291f6cbfc4eeb336ba214d0;hb=1dbe0b9828c0fe0fb642361473dedbcef7defc4c;hpb=2c679eeb8bbc93220f85403eca6e9380dc624a6a

diff --git a/file_write.c b/file_write.c
index 50d3fae7..3286ea87 100644
--- a/file_write.c
+++ b/file_write.c
@@ -1,17 +1,20 @@
 /*
- * Copyright (C) 2006-2007 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2009 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
 
 /** \file file_write.c simple output plugin for testing purposes */
 
+#include <regex.h>
 #include <sys/types.h>
 #include <dirent.h>
+#include <sys/time.h>
 
 #include "para.h"
 #include "list.h"
 #include "sched.h"
+#include "ggo.h"
 #include "write.h"
 #include "string.h"
 #include "fd.h"
@@ -26,26 +29,43 @@ struct private_file_write_data {
 	int check_fd;
 };
 
+/*
+ * Get a random filename.
+ *
+ * This is by no means a secure way to create temporary files in a hostile
+ * directory like \p /tmp. However, we use it only for creating temp files in
+ * ~/.paraslash, for which it is OK. Result must be freed by the caller.
+ */
+__must_check __malloc static char *random_filename(void)
+{
+	char *result, *home = para_homedir();
+	struct timeval tv;
+
+	gettimeofday(&tv, NULL);
+	srandom(tv.tv_usec);
+	result = make_message("%s/.paraslash/%08lu", home,
+		para_random(99999999));
+	free(home);
+	return result;
+}
+
 static int file_write_open(struct writer_node *wn)
 {
 	struct private_file_write_data *pfwd = para_calloc(
 		sizeof(struct private_file_write_data));
 	struct file_write_args_info *conf = wn->conf;
 	char *filename;
+
 	if (conf->filename_given)
 		filename = conf->filename_arg;
-	else {
-		char *tmp = para_tmpname(), *home = para_homedir();
-		filename = make_message("%s/.paraslash/%s", home, tmp);
-		free(home);
-		free(tmp);
-	}
+	else
+		filename = random_filename();
 	wn->private_data = pfwd;
 	pfwd->fd = open(filename, O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR);
 	if (!conf->filename_given)
 		free(filename);
 	if (pfwd->fd >= 0)
-		return 8192;
+		return 1;
 	free(pfwd);
 	return -E_FW_OPEN;
 }
@@ -78,7 +98,7 @@ static int file_write_post_select(struct sched *s, struct writer_node *wn)
 	if (!FD_ISSET(pfwd->fd, &s->wfds))
 		return 1;
 //	PARA_INFO_LOG("writing %zd\n", *wng->loaded);
-	ret = write(pfwd->fd, wng->buf + wn->written,
+	ret = write(pfwd->fd, *wng->bufp + wn->written,
 		*wng->loaded - wn->written);
 	if (ret < 0)
 		return -E_FW_WRITE;
@@ -95,10 +115,10 @@ static void file_write_close(struct writer_node *wn)
 
 __malloc static void *file_write_parse_config(const char *options)
 {
-	PARA_INFO_LOG("options: %s\n", options);
 	struct file_write_args_info *conf
 		= para_calloc(sizeof(struct file_write_args_info));
 	int ret = file_cmdline_parser_string(options, conf, "file_write");
+
 	PARA_INFO_LOG("conf->filename_given: %d\n", conf->filename_given);
 	if (!ret)
 		return conf;
@@ -109,10 +129,17 @@ __malloc static void *file_write_parse_config(const char *options)
 /** the init function of the file writer */
 void file_write_init(struct writer *w)
 {
+	struct file_write_args_info dummy;
+
+	file_cmdline_parser_init(&dummy);
 	w->open = file_write_open;
 	w->pre_select = file_write_pre_select;
 	w->post_select = file_write_post_select;
 	w->parse_config = file_write_parse_config;
 	w->close = file_write_close;
 	w->shutdown = NULL; /* nothing to do */
+	w->help = (struct ggo_help) {
+		.short_help = file_write_args_info_help,
+		.detailed_help = file_write_args_info_detailed_help
+	};
 }