X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=file_write.c;h=ef25b0f5695d09c539635cdffe32a3b4cc6dbe53;hp=4b6a5efe6ea8af1c2f14732b5c2030850b02c9ff;hb=224ab3f14af8e08a8a7159160eccea75be30ffd1;hpb=12ccf687f664e92de34b9fbb3164c9495e2cbdff diff --git a/file_write.c b/file_write.c index 4b6a5efe..ef25b0f5 100644 --- a/file_write.c +++ b/file_write.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2006-2009 Andre Noll + * Copyright (C) 2006 Andre Noll * * Licensed under the GPL v2. For licencing details see COPYING. */ @@ -8,9 +8,6 @@ #include #include -#include -#include -#include #include "para.h" #include "list.h" @@ -24,12 +21,10 @@ #include "file_write.cmdline.h" #include "error.h" -/** data specific to the file writer */ +/** Data specific to the file writer. */ struct private_file_write_data { - /** the file descriptor of the output file */ + /** The file descriptor of the output file. */ int fd; - /** non-zero if \a fd was added to the write fd set */ - int check_fd; }; /* @@ -42,113 +37,112 @@ struct private_file_write_data { __must_check __malloc static char *random_filename(void) { char *result, *home = para_homedir(); - struct timeval tv; - gettimeofday(&tv, NULL); - srandom(tv.tv_usec); + srandom(clock_get_realtime(NULL)->tv_usec); result = make_message("%s/.paraslash/%08lu", home, para_random(99999999)); free(home); return result; } -static int file_write_open(struct writer_node *wn) +static int prepare_output_file(struct writer_node *wn) { - struct private_file_write_data *pfwd = para_calloc( - sizeof(struct private_file_write_data)); struct file_write_args_info *conf = wn->conf; char *filename; + int ret; + struct private_file_write_data *pfwd = para_calloc(sizeof(*pfwd)); if (conf->filename_given) filename = conf->filename_arg; else filename = random_filename(); - wn->private_data = pfwd; - pfwd->fd = open(filename, O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR); + ret = para_open(filename, O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR); if (!conf->filename_given) free(filename); - if (pfwd->fd >= 0) - return 1; + if (ret < 0) + goto out; + pfwd->fd = ret; + ret = mark_fd_blocking(pfwd->fd); + if (ret < 0) + goto out_close; + wn->private_data = pfwd; + return 1; +out_close: + close(pfwd->fd); +out: free(pfwd); - return -E_FW_OPEN; + return ret; } -static void file_write_pre_select_btr(struct sched *s, struct task *t) +static void file_write_pre_select(struct sched *s, void *context) { - struct writer_node *wn = container_of(t, struct writer_node, task); + struct writer_node *wn = context; struct private_file_write_data *pfwd = wn->private_data; - int ret; + int ret = btr_node_status(wn->btrn, wn->min_iqs, BTR_NT_LEAF); - t->error = 0; - pfwd->check_fd = 0; - ret = btr_node_status(wn->btrn, wn->min_iqs, BTR_NT_LEAF); - if (ret > 0) { - para_fd_set(pfwd->fd, &s->wfds, &s->max_fileno); - pfwd->check_fd = 1; - } else if (ret < 0) { - s->timeout.tv_sec = 0; - s->timeout.tv_usec = 1; - } + if (ret == 0) + return; + if (ret < 0 || !pfwd) + return sched_min_delay(s); + para_fd_set(pfwd->fd, &s->wfds, &s->max_fileno); } static void file_write_close(struct writer_node *wn) { struct private_file_write_data *pfwd = wn->private_data; + if (!pfwd) + return; close(pfwd->fd); free(pfwd); } -static void file_write_post_select_btr(__a_unused struct sched *s, - struct task *t) +static int file_write_post_select(__a_unused struct sched *s, void *context) { - struct writer_node *wn = container_of(t, struct writer_node, task); + struct writer_node *wn = context; struct private_file_write_data *pfwd = wn->private_data; struct btr_node *btrn = wn->btrn; int ret; char *buf; size_t bytes; - t->error = 0; - ret = btr_node_status(btrn, wn->min_iqs, BTR_NT_LEAF); - if (ret == 0) - return; + ret = task_get_notification(wn->task); if (ret < 0) - goto err; - if (!pfwd->check_fd) - return; + goto out; + ret = btr_node_status(btrn, wn->min_iqs, BTR_NT_LEAF); + if (ret <= 0) + goto out; + if (!pfwd) { + ret = prepare_output_file(wn); + goto out; + } if (!FD_ISSET(pfwd->fd, &s->wfds)) - return; + return 0; bytes = btr_next_buffer(btrn, &buf); assert(bytes > 0); //PARA_INFO_LOG("writing %zu\n", bytes); - ret = write(pfwd->fd, buf, bytes); + ret = xwrite(pfwd->fd, buf, bytes); if (ret < 0) - goto err; + goto out; btr_consume(btrn, ret); - return; -err: - assert(ret < 0); - t->error = ret; - btr_remove_node(btrn); +out: + if (ret < 0) + btr_remove_node(&wn->btrn); + return ret; } -__malloc static void *file_write_parse_config(const char *options) +__malloc static void *file_write_parse_config_or_die(int argc, char **argv) { - struct file_write_args_info *conf - = para_calloc(sizeof(struct file_write_args_info)); - int ret = file_cmdline_parser_string(options, conf, "file_write"); - - PARA_INFO_LOG("conf->filename_given: %d\n", conf->filename_given); - if (!ret) - return conf; - free(conf); - return NULL; + struct file_write_args_info *conf = para_calloc(sizeof(*conf)); + + /* exits on errors */ + file_write_cmdline_parser(argc, argv, conf); + return conf; } static void file_write_free_config(void *conf) { - file_cmdline_parser_free(conf); + file_write_cmdline_parser_free(conf); } /** the init function of the file writer */ @@ -156,17 +150,12 @@ void file_write_init(struct writer *w) { struct file_write_args_info dummy; - file_cmdline_parser_init(&dummy); - w->open = file_write_open; - w->pre_select_btr = file_write_pre_select_btr; - w->post_select_btr = file_write_post_select_btr; - w->parse_config = file_write_parse_config; + file_write_cmdline_parser_init(&dummy); + w->pre_select = file_write_pre_select; + w->post_select = file_write_post_select; + w->parse_config_or_die = file_write_parse_config_or_die; w->free_config = file_write_free_config; w->close = file_write_close; - w->shutdown = NULL; /* nothing to do */ - w->help = (struct ggo_help) { - .short_help = file_write_args_info_help, - .detailed_help = file_write_args_info_detailed_help - }; - file_cmdline_parser_free(&dummy); + w->help = (struct ggo_help)DEFINE_GGO_HELP(file_write); + file_write_cmdline_parser_free(&dummy); }